dc33cf4135
Polish across the form input components, plus two new features and a few
standalone fixes.
Fixes
-----
* Reserve hint/error/success paragraph space (min-h-[1rem]) in 15
components so a single error message no longer shifts neighboring grid
cells: InputText, Email, Password, Phone, Amount, Number, Upload,
Autocomplete, RichText, TextArea, Select, SelectCheckbox, Time,
TimePicker, CalendarField, Checkbox.
* InputPhone: the '+' add button now follows the icon-state cascade
(muted / primary on focus / black when filled / danger / success) like
the other field icons instead of being permanently primary.
* Select and SelectCheckbox: chevron color follows the field state
(muted by default, primary when open, black when an option is
selected, danger / success on error / success) instead of always being
text-current.
* InputTextArea: single-root component (was multi-root). The message
wrapper used to occupy its own grid cell, breaking row-span layouts.
Now flex flex-col, with the textarea area filling the available height
via flex-1 and the message inside the same root.
* Disabled labels use text-m-muted (border-gray) instead of text-black/60
(dark) across InputText, Email, Password, Amount, Phone, Upload,
Autocomplete, TextArea, RichText. Also removes an unreachable
peer-[&:not(:placeholder-shown):not(:focus)]:text-black/60 rule that
twMerge was silently overriding with text-black.
* InputAutocomplete: eliminates four sources of visual jitter when
focusing / opening a field that already has a selected value.
- Drop peer-focus:-translate-y-[1.55rem] extra label translate.
- Drop the .grow-height:focus padding rule (no more height growth or
downward text shift on focus).
- Drop focus:pl-[11px] (no more 1px horizontal jump).
- Replace !border-b-0 with !border-b-transparent so the bottom border
still reserves its 1px while remaining invisible against the
dropdown.
* Select / SelectCheckbox: same anti-jitter treatment.
- Drop .grow-height:focus padding rule (~12px height growth gone).
- Replace !border-b-0 / !border-t-0 with !border-b-transparent /
!border-t-transparent across danger / success / primary branches.
* Button: default width 240px -> 200px to match the form button sizing
used across the app. Test updated to match.
Features
--------
* InputTextArea: scrollbar turns primary blue on focus
(scrollbar-color: rgb(var(--m-primary)) transparent), matching the
Select listbox styling.
* InputAutocomplete: new localFilter prop (default false). When enabled,
filters the options prop client-side based on the input value
(case-insensitive label.includes(query)), so static lists no longer
need a @search listener. Async/API usage keeps the existing behavior.
Playground "Simple statique" and "Avec icône à gauche" examples use
local-filter.
Playground
----------
* client.vue: tighter grid gap (gap-y-5) plus an example error on a
SelectCheckbox to visually exercise the message-space fix.
Tests
-----
All component test files include regression coverage for the above.
720/720 tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
328 lines
11 KiB
TypeScript
328 lines
11 KiB
TypeScript
import {describe, expect, it} from 'vitest'
|
|
import {mount} from '@vue/test-utils'
|
|
import type {DefineComponent} from 'vue'
|
|
import Input from './InputText.vue'
|
|
|
|
type InputProps = {
|
|
id?: string
|
|
label?: string
|
|
name?: string
|
|
autocomplete?: string
|
|
modelValue?: string | null
|
|
inputClass?: string
|
|
labelClass?: string
|
|
groupClass?: string
|
|
required?: boolean
|
|
maxLength?: number | string
|
|
minLength?: number | string
|
|
disabled?: boolean
|
|
readonly?: boolean
|
|
hint?: string
|
|
error?: string
|
|
success?: string
|
|
iconName?: string
|
|
iconPosition?: 'left' | 'right'
|
|
iconSize?: string | number
|
|
iconColor?: string
|
|
}
|
|
|
|
const InputForTest = Input as DefineComponent<InputProps>
|
|
|
|
const mountInput = (props: InputProps = {}) =>
|
|
mount(InputForTest, {
|
|
props,
|
|
global: {
|
|
stubs: {
|
|
IconifyIcon: {
|
|
template: '<span data-test="icon" v-bind="$attrs" />',
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
describe('MalioInputText', () => {
|
|
it('renders the initial input value', () => {
|
|
const wrapper = mountInput({modelValue: 'initialValueTest'})
|
|
|
|
expect(wrapper.get('input').element.value).toBe('initialValueTest')
|
|
})
|
|
|
|
it('renders the label text', () => {
|
|
const wrapper = mountInput({label: 'labelTest'})
|
|
|
|
expect(wrapper.get('label').text()).toBe('labelTest')
|
|
})
|
|
|
|
it('applies the name attribute', () => {
|
|
const wrapper = mountInput({name: 'nameTest'})
|
|
|
|
expect(wrapper.get('input').attributes('name')).toBe('nameTest')
|
|
})
|
|
|
|
it('uses provided id on input and label', () => {
|
|
const wrapper = mountInput({id: 'custom-id', label: 'Label'})
|
|
|
|
expect(wrapper.get('input').attributes('id')).toBe('custom-id')
|
|
expect(wrapper.get('label').attributes('for')).toBe('custom-id')
|
|
})
|
|
|
|
it('keeps the default rounded class on input', () => {
|
|
const wrapper = mountInput()
|
|
|
|
expect(wrapper.get('input').classes()).toContain('rounded-md')
|
|
})
|
|
|
|
it('generates an id when missing and reuses it on label', () => {
|
|
const wrapper = mountInput({label: 'Label'})
|
|
|
|
const inputId = wrapper.get('input').attributes('id')
|
|
|
|
expect(inputId?.startsWith('malio-input-text-')).toBe(true)
|
|
expect(wrapper.get('label').attributes('for')).toBe(inputId)
|
|
})
|
|
|
|
it('applies the autocomplete attribute', () => {
|
|
const wrapper = mountInput({autocomplete: 'autocompleteTest'})
|
|
|
|
expect(wrapper.get('input').attributes('autocomplete')).toBe('autocompleteTest')
|
|
})
|
|
|
|
it('does not set required when false', () => {
|
|
const wrapper = mountInput({required: false})
|
|
|
|
expect(wrapper.get('input').attributes('required')).toBeUndefined()
|
|
})
|
|
|
|
it('sets required when true', () => {
|
|
const wrapper = mountInput({required: true})
|
|
|
|
expect(wrapper.get('input').attributes('required')).toBeDefined()
|
|
})
|
|
|
|
it('does not set readonly when false', () => {
|
|
const wrapper = mountInput({readonly: false})
|
|
|
|
expect(wrapper.get('input').attributes('readonly')).toBeUndefined()
|
|
})
|
|
|
|
it('sets readonly when true', () => {
|
|
const wrapper = mountInput({readonly: true})
|
|
|
|
expect(wrapper.get('input').attributes('readonly')).toBeDefined()
|
|
})
|
|
|
|
it('does not set disabled and keeps text cursor when false', () => {
|
|
const wrapper = mountInput({disabled: false})
|
|
|
|
expect(wrapper.get('input').attributes('disabled')).toBeUndefined()
|
|
expect(wrapper.get('input').classes()).toContain('cursor-text')
|
|
})
|
|
|
|
it('sets disabled styles when true', () => {
|
|
const wrapper = mountInput({disabled: true})
|
|
|
|
expect(wrapper.get('input').attributes('disabled')).toBeDefined()
|
|
expect(wrapper.get('input').classes()).toContain('cursor-not-allowed')
|
|
expect(wrapper.get('input').classes()).toContain('text-black/60')
|
|
})
|
|
|
|
it('shows muted label color when disabled (matches border color)', () => {
|
|
const wrapper = mountInput({label: 'Email', disabled: true, modelValue: 'foo@bar.com'})
|
|
|
|
expect(wrapper.get('label').classes()).toContain('text-m-muted')
|
|
expect(wrapper.get('label').classes()).not.toContain('text-black/60')
|
|
})
|
|
|
|
it('emits update:modelValue on input change', async () => {
|
|
const wrapper = mountInput({modelValue: ''})
|
|
|
|
await wrapper.get('input').setValue('new value')
|
|
|
|
expect(wrapper.emitted('update:modelValue')?.[0]).toEqual(['new value'])
|
|
})
|
|
|
|
it('applies maxLength to input', () => {
|
|
const wrapper = mountInput({maxLength: 25})
|
|
|
|
expect(wrapper.get('input').attributes('maxlength')).toBe('25')
|
|
})
|
|
|
|
it('applies minLength to input', () => {
|
|
const wrapper = mountInput({minLength: 25})
|
|
|
|
expect(wrapper.get('input').attributes('minlength')).toBe('25')
|
|
})
|
|
|
|
it('applies labelClass on label', () => {
|
|
const wrapper = mountInput({label: 'Label', labelClass: 'text-red-500'})
|
|
|
|
expect(wrapper.get('label').classes()).toContain('text-red-500')
|
|
})
|
|
|
|
it('applies inputClass on input', () => {
|
|
const wrapper = mountInput({inputClass: 'text-sm'})
|
|
|
|
expect(wrapper.get('input').classes()).toContain('text-sm')
|
|
})
|
|
|
|
it('shows error message without label and icon', () => {
|
|
const wrapper = mountInput({error: 'Error message test'})
|
|
|
|
expect(wrapper.get('p.text-m-danger').text()).toBe('Error message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-danger')
|
|
expect(wrapper.get('input').attributes('aria-invalid')).toBe('true')
|
|
expect(wrapper.get('p').classes()).toContain('text-m-danger')
|
|
})
|
|
|
|
it('shows error message with label and without icon', () => {
|
|
const wrapper = mountInput({error: 'Error message test', label: 'Error message'})
|
|
|
|
expect(wrapper.get('p.text-m-danger').text()).toBe('Error message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-danger')
|
|
expect(wrapper.get('label').classes()).toContain('text-m-danger')
|
|
expect(wrapper.get('p').classes()).toContain('text-m-danger')
|
|
})
|
|
|
|
it('shows error message with label and icon', () => {
|
|
const wrapper = mountInput({
|
|
error: 'Error message test',
|
|
label: 'Error message',
|
|
iconName: 'mdi:key-outline',
|
|
})
|
|
|
|
expect(wrapper.get('p.text-m-danger').text()).toBe('Error message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-danger')
|
|
expect(wrapper.get('label').classes()).toContain('text-m-danger')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-danger')
|
|
expect(wrapper.get('p').classes()).toContain('text-m-danger')
|
|
})
|
|
|
|
it('shows error message with icon and without label', () => {
|
|
const wrapper = mountInput({error: 'Error message test', iconName: 'mdi:key-outline'})
|
|
|
|
expect(wrapper.get('p.text-m-danger').text()).toBe('Error message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-danger')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-danger')
|
|
})
|
|
|
|
it('shows success message without label and icon', () => {
|
|
const wrapper = mountInput({success: 'Success message test'})
|
|
|
|
expect(wrapper.get('p.text-m-success').text()).toBe('Success message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-success')
|
|
})
|
|
|
|
it('shows success message with label and without icon', () => {
|
|
const wrapper = mountInput({success: 'Success message test', label: 'Success message'})
|
|
|
|
expect(wrapper.get('p.text-m-success').text()).toBe('Success message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-success')
|
|
expect(wrapper.get('label').classes()).toContain('text-m-success')
|
|
})
|
|
|
|
it('shows success message with label and icon', () => {
|
|
const wrapper = mountInput({
|
|
success: 'Success message test',
|
|
label: 'Success message',
|
|
iconName: 'mdi:key-outline',
|
|
})
|
|
|
|
expect(wrapper.get('p.text-m-success').text()).toBe('Success message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-success')
|
|
expect(wrapper.get('label').classes()).toContain('text-m-success')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-success')
|
|
})
|
|
|
|
it('shows success message with icon and without label', () => {
|
|
const wrapper = mountInput({success: 'Success message test', iconName: 'mdi:key-outline'})
|
|
|
|
expect(wrapper.get('p.text-m-success').text()).toBe('Success message test')
|
|
expect(wrapper.get('input').classes()).toContain('border-m-success')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-success')
|
|
})
|
|
|
|
it('prioritizes error over success when both are provided', () => {
|
|
const wrapper = mountInput({
|
|
error: 'Error message test',
|
|
success: 'Success message test',
|
|
})
|
|
|
|
expect(wrapper.find('p.text-m-danger').exists()).toBe(true)
|
|
expect(wrapper.get('p.text-m-danger').text()).toBe('Error message test')
|
|
expect(wrapper.find('p.text-m-success').exists()).toBe(false)
|
|
expect(wrapper.get('input').classes()).toContain('border-m-danger')
|
|
expect(wrapper.get('input').classes()).not.toContain('border-m-success')
|
|
})
|
|
|
|
it('shows hint message', () => {
|
|
const wrapper = mountInput({hint: 'Hint message test'})
|
|
|
|
expect(wrapper.get('p.text-m-muted').text()).toBe('Hint message test')
|
|
})
|
|
|
|
it('reserves space for the message even when no hint/error/success is set', () => {
|
|
const wrapper = mountInput({})
|
|
|
|
const p = wrapper.find('p')
|
|
expect(p.exists()).toBe(true)
|
|
expect(p.text()).toBe('')
|
|
expect(p.classes()).toContain('min-h-[1rem]')
|
|
})
|
|
|
|
it('does not render label when label prop is missing', () => {
|
|
const wrapper = mountInput({labelClass: 'text-red-500'})
|
|
|
|
expect(wrapper.find('label').exists()).toBe(false)
|
|
})
|
|
|
|
it('renders icon with default positioning and muted color', () => {
|
|
const wrapper = mountInput({iconName: 'mdi:key-outline'})
|
|
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-muted')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('pointer-events-none')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('absolute')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('right-[10px]')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('top-1/2')
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('-translate-y-1/2')
|
|
})
|
|
|
|
it('renders icon on the left when requested', () => {
|
|
const wrapper = mountInput({
|
|
iconName: 'mdi:key-outline',
|
|
iconPosition: 'left',
|
|
label: 'Password',
|
|
})
|
|
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('left-[10px]')
|
|
expect(wrapper.get('input').classes()).toContain('!pl-11')
|
|
expect(wrapper.get('label').classes()).toContain('left-11')
|
|
})
|
|
|
|
it('passes icon size props to icon component', () => {
|
|
const wrapper = mountInput({iconName: 'mdi:key-outline', iconSize: '24'})
|
|
|
|
expect(wrapper.get('[data-test="icon"]').attributes('width')).toBe('24')
|
|
expect(wrapper.get('[data-test="icon"]').attributes('height')).toBe('24')
|
|
})
|
|
|
|
it('applies icon color class', () => {
|
|
const wrapper = mountInput({iconName: 'mdi:key-outline', iconColor: 'text-m-primary'})
|
|
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-primary')
|
|
})
|
|
|
|
it('shows primary icon color on focus', async () => {
|
|
const wrapper = mountInput({iconName: 'mdi:key-outline'})
|
|
|
|
await wrapper.get('input').trigger('focus')
|
|
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-m-primary')
|
|
})
|
|
|
|
it('shows black icon color when filled and unfocused', () => {
|
|
const wrapper = mountInput({iconName: 'mdi:key-outline', modelValue: 'hello'})
|
|
|
|
expect(wrapper.get('[data-test="icon"]').classes()).toContain('text-black')
|
|
})
|
|
})
|