Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 583d634a83 | |||
| ee1521384e | |||
| 79dffccc79 | |||
| 1ff335b3fe | |||
| fa47517028 | |||
| 402c83d40d |
+1
-1
@@ -1,2 +1,2 @@
|
|||||||
parameters:
|
parameters:
|
||||||
app.version: '0.1.63'
|
app.version: '0.1.66'
|
||||||
|
|||||||
@@ -44,7 +44,63 @@
|
|||||||
},
|
},
|
||||||
"commercial": {
|
"commercial": {
|
||||||
"title": "Commercial",
|
"title": "Commercial",
|
||||||
"welcome": "Module Commercial"
|
"welcome": "Module Commercial",
|
||||||
|
"clients": {
|
||||||
|
"title": "Répertoire clients",
|
||||||
|
"add": "Ajouter",
|
||||||
|
"export": "Exporter",
|
||||||
|
"empty": "Aucun client pour l'instant.",
|
||||||
|
"column": {
|
||||||
|
"companyName": "Nom",
|
||||||
|
"categories": "Catégories",
|
||||||
|
"sites": "Site",
|
||||||
|
"lastActivity": "Dernière activité"
|
||||||
|
},
|
||||||
|
"filters": {
|
||||||
|
"title": "Filtres",
|
||||||
|
"search": "Recherche",
|
||||||
|
"categories": "Catégories",
|
||||||
|
"sites": "Sites",
|
||||||
|
"status": "Statut",
|
||||||
|
"archivedOnly": "Voir les archivés",
|
||||||
|
"apply": "Voir les résultats",
|
||||||
|
"reset": "Réinitialiser"
|
||||||
|
},
|
||||||
|
"tab": {
|
||||||
|
"information": "Information",
|
||||||
|
"contact": "Contact",
|
||||||
|
"address": "Adresse",
|
||||||
|
"transport": "Transport",
|
||||||
|
"accounting": "Comptabilité",
|
||||||
|
"statistics": "Statistiques",
|
||||||
|
"reports": "Rapports",
|
||||||
|
"exchanges": "Échanges"
|
||||||
|
},
|
||||||
|
"action": {
|
||||||
|
"edit": "Modifier",
|
||||||
|
"archive": "Archiver",
|
||||||
|
"restore": "Restaurer"
|
||||||
|
},
|
||||||
|
"toast": {
|
||||||
|
"createSuccess": "Client créé avec succès",
|
||||||
|
"updateSuccess": "Client mis à jour avec succès",
|
||||||
|
"archiveSuccess": "Client archivé avec succès",
|
||||||
|
"restoreSuccess": "Client restauré avec succès",
|
||||||
|
"error": "Une erreur est survenue. Réessayez.",
|
||||||
|
"exportError": "L'export du répertoire clients a échoué. Réessayez."
|
||||||
|
},
|
||||||
|
"validation": {
|
||||||
|
"informationRequiredForCommercial": "Les informations de l'entreprise sont obligatoires pour le rôle Commerciale.",
|
||||||
|
"contactRequired": "Au moins un contact (nom ou prénom) est obligatoire.",
|
||||||
|
"siteRequired": "Au moins un site Starseed doit être rattaché à l'adresse.",
|
||||||
|
"billingEmailRequired": "L'email de facturation est obligatoire pour une adresse de facturation.",
|
||||||
|
"bankRequiredForTransfer": "La banque est obligatoire pour un règlement par virement.",
|
||||||
|
"ribRequiredForLcr": "Au moins un RIB complet est obligatoire pour un règlement par LCR.",
|
||||||
|
"phoneFormat": "Format de téléphone invalide (attendu : XX XX XX XX XX).",
|
||||||
|
"emailFormat": "Format d'email invalide.",
|
||||||
|
"addressCategoryForbidden": "Une catégorie « Distributeur » ou « Courtier » ne peut pas qualifier une adresse."
|
||||||
|
}
|
||||||
|
}
|
||||||
},
|
},
|
||||||
"auth": {
|
"auth": {
|
||||||
"login": "Connexion",
|
"login": "Connexion",
|
||||||
|
|||||||
@@ -0,0 +1,85 @@
|
|||||||
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||||
|
import type { HydraCollection } from '~/shared/utils/api'
|
||||||
|
import type { Client } from '../useClientsRepository'
|
||||||
|
|
||||||
|
// `useApi` est un auto-import Nuxt : on le stubbe globalement pour intercepter
|
||||||
|
// les appels declenches par usePaginatedList (que useClientsRepository enveloppe)
|
||||||
|
// et controler les reponses. Meme pattern que useCategoriesAdmin.spec.ts.
|
||||||
|
const mockGet = vi.hoisted(() => vi.fn())
|
||||||
|
vi.stubGlobal('useApi', () => ({
|
||||||
|
get: mockGet,
|
||||||
|
post: vi.fn(),
|
||||||
|
put: vi.fn(),
|
||||||
|
patch: vi.fn(),
|
||||||
|
delete: vi.fn(),
|
||||||
|
}))
|
||||||
|
|
||||||
|
// Import APRES le stub pour que useApi soit bien resolu au top-level du module.
|
||||||
|
const { useClientsRepository } = await import('../useClientsRepository')
|
||||||
|
|
||||||
|
/** Envelope Hydra minimale (la liste reelle des membres importe peu ici). */
|
||||||
|
function makeHydra(total: number): HydraCollection<Client> {
|
||||||
|
return { totalItems: total, member: [] }
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('useClientsRepository', () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
mockGet.mockReset()
|
||||||
|
// 25 items → 3 pages a 10/page : permet de tester la navigation page 2.
|
||||||
|
mockGet.mockResolvedValue(makeHydra(25))
|
||||||
|
})
|
||||||
|
|
||||||
|
it('cible la ressource /clients en page 1 par defaut', async () => {
|
||||||
|
const repo = useClientsRepository()
|
||||||
|
await repo.fetch()
|
||||||
|
|
||||||
|
expect(mockGet).toHaveBeenLastCalledWith(
|
||||||
|
'/clients',
|
||||||
|
{ page: 1, itemsPerPage: 10 },
|
||||||
|
expect.objectContaining({ toast: false }),
|
||||||
|
)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('pousse les filtres du drawer (categories multi, sites, archives) et retombe en page 1', async () => {
|
||||||
|
const repo = useClientsRepository()
|
||||||
|
await repo.fetch()
|
||||||
|
await repo.goToPage(2)
|
||||||
|
expect(repo.currentPage.value).toBe(2)
|
||||||
|
|
||||||
|
await repo.setFilters(
|
||||||
|
{
|
||||||
|
search: 'acme',
|
||||||
|
'categoryCode[]': ['DISTRIBUTEUR', 'COURTIER'],
|
||||||
|
'siteId[]': ['1', '2'],
|
||||||
|
archivedOnly: true,
|
||||||
|
},
|
||||||
|
{ replace: true },
|
||||||
|
)
|
||||||
|
|
||||||
|
expect(repo.currentPage.value).toBe(1)
|
||||||
|
expect(mockGet).toHaveBeenLastCalledWith(
|
||||||
|
'/clients',
|
||||||
|
{
|
||||||
|
search: 'acme',
|
||||||
|
'categoryCode[]': ['DISTRIBUTEUR', 'COURTIER'],
|
||||||
|
'siteId[]': ['1', '2'],
|
||||||
|
archivedOnly: true,
|
||||||
|
page: 1,
|
||||||
|
itemsPerPage: 10,
|
||||||
|
},
|
||||||
|
expect.objectContaining({ toast: false }),
|
||||||
|
)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('repasse a une query propre apres reinitialisation des filtres', async () => {
|
||||||
|
const repo = useClientsRepository()
|
||||||
|
await repo.setFilters({ search: 'acme', archivedOnly: true }, { replace: true })
|
||||||
|
await repo.setFilters({}, { replace: true })
|
||||||
|
|
||||||
|
expect(mockGet).toHaveBeenLastCalledWith(
|
||||||
|
'/clients',
|
||||||
|
{ page: 1, itemsPerPage: 10 },
|
||||||
|
expect.objectContaining({ toast: false }),
|
||||||
|
)
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -0,0 +1,53 @@
|
|||||||
|
import { usePaginatedList } from '~/shared/composables/usePaginatedList'
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Site Starseed rattache a une adresse du client, tel qu'embarque en LISTE
|
||||||
|
* (groupe site:read) pour la colonne « Site(s) » du Repertoire (badges colores).
|
||||||
|
*/
|
||||||
|
export interface ClientSite {
|
||||||
|
id: number
|
||||||
|
name: string
|
||||||
|
color: string
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Categorie rattachee au client, embarquee en LISTE (groupe category:read).
|
||||||
|
* Seul le `code` (stable, MAJUSCULE — ERP-78) est affiche dans la colonne
|
||||||
|
* « Catégories ». Les autres champs sont presents mais non utilises ici.
|
||||||
|
*/
|
||||||
|
export interface ClientCategory {
|
||||||
|
code: string
|
||||||
|
name?: string
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Vue MINIMALE d'un client pour le Repertoire (datatable). Volontairement
|
||||||
|
* partielle : seuls les champs des colonnes + l'id (navigation) sont types ici.
|
||||||
|
* Le detail complet (onglets) est hors perimetre de cet ecran (ERP-62).
|
||||||
|
*/
|
||||||
|
export interface Client {
|
||||||
|
id: number
|
||||||
|
companyName: string
|
||||||
|
categories: ClientCategory[]
|
||||||
|
sites: ClientSite[]
|
||||||
|
/** Date ISO de derniere modification (default:read) — colonne « Dernière activité ». */
|
||||||
|
updatedAt: string | null
|
||||||
|
isArchived: boolean
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Repertoire clients (ERP-62) — simple enveloppe de `usePaginatedList<Client>`
|
||||||
|
* sur la ressource `/clients` (RG-13 : pagination serveur obligatoire ; jamais
|
||||||
|
* de chargement integral en memoire).
|
||||||
|
*
|
||||||
|
* Les filtres (recherche, categories, sites, archives) sont pilotes par la page
|
||||||
|
* via `setFilters` du composable partage — la remise en page 1 est garantie.
|
||||||
|
*
|
||||||
|
* Volontairement PAR INSTANCE (pas de singleton module-level) : l'etat tableau
|
||||||
|
* est propre a l'ecran Repertoire et meurt avec lui, comme tout consommateur de
|
||||||
|
* `usePaginatedList` (cf. sites.vue / categories.vue). Aucun reset au logout a
|
||||||
|
* gerer.
|
||||||
|
*/
|
||||||
|
export function useClientsRepository() {
|
||||||
|
return usePaginatedList<Client>({ url: '/clients' })
|
||||||
|
}
|
||||||
@@ -0,0 +1,421 @@
|
|||||||
|
<template>
|
||||||
|
<div>
|
||||||
|
<PageHeader>
|
||||||
|
{{ t('commercial.clients.title') }}
|
||||||
|
<template #actions>
|
||||||
|
<!-- gap-12 = 48px d'espacement entre Ajouter et Filtres. -->
|
||||||
|
<div class="flex items-center gap-12">
|
||||||
|
<MalioButton
|
||||||
|
v-if="canManage"
|
||||||
|
variant="secondary"
|
||||||
|
:label="t('commercial.clients.add')"
|
||||||
|
icon-name="mdi:add-bold"
|
||||||
|
icon-position="left"
|
||||||
|
@click="goToCreate"
|
||||||
|
/>
|
||||||
|
<!-- Bouton Filtres a DROITE d'Ajouter : meme design que
|
||||||
|
l'audit-log. Le compteur reflete les filtres actifs. -->
|
||||||
|
<MalioButton
|
||||||
|
v-if="canView"
|
||||||
|
variant="tertiary"
|
||||||
|
:label="filterButtonLabel"
|
||||||
|
icon-name="mdi:tune"
|
||||||
|
icon-position="left"
|
||||||
|
icon-size="24"
|
||||||
|
button-class="w-[184px] justify-start gap-4 text-black"
|
||||||
|
@click="openFilters"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</template>
|
||||||
|
</PageHeader>
|
||||||
|
|
||||||
|
<!-- Datatable branchee sur usePaginatedList via useClientsRepository :
|
||||||
|
pagination serveur, tri companyName ASC par defaut (cote back). -->
|
||||||
|
<MalioDataTable
|
||||||
|
:columns="columns"
|
||||||
|
:items="rows"
|
||||||
|
:total-items="totalItems"
|
||||||
|
:page="currentPage"
|
||||||
|
:per-page="itemsPerPage"
|
||||||
|
:per-page-options="itemsPerPageOptions"
|
||||||
|
row-clickable
|
||||||
|
table-class="table-fixed"
|
||||||
|
:empty-message="t('commercial.clients.empty')"
|
||||||
|
@row-click="onRowClick"
|
||||||
|
@update:page="goToPage"
|
||||||
|
@update:per-page="setItemsPerPage"
|
||||||
|
>
|
||||||
|
<!-- Categories : codes stables separes par une virgule (ERP-78). -->
|
||||||
|
<template #cell-categories="{ item }">
|
||||||
|
{{ formatCategories(item) }}
|
||||||
|
</template>
|
||||||
|
|
||||||
|
<!-- Sites : badges colores (name + color), agreges des adresses. -->
|
||||||
|
<template #cell-sites="{ item }">
|
||||||
|
<span class="flex flex-wrap gap-1">
|
||||||
|
<span
|
||||||
|
v-for="site in (item.sites as ClientSite[])"
|
||||||
|
:key="site.id"
|
||||||
|
class="inline-flex items-center rounded-full px-2 py-0.5 text-xs font-medium text-white"
|
||||||
|
:style="{ backgroundColor: site.color }"
|
||||||
|
>
|
||||||
|
{{ site.name }}
|
||||||
|
</span>
|
||||||
|
</span>
|
||||||
|
</template>
|
||||||
|
|
||||||
|
<!-- Derniere activite : date de derniere modification (updatedAt). -->
|
||||||
|
<template #cell-lastActivity="{ item }">
|
||||||
|
{{ formatLastActivity(item) }}
|
||||||
|
</template>
|
||||||
|
</MalioDataTable>
|
||||||
|
|
||||||
|
<div class="flex justify-center mt-6">
|
||||||
|
<MalioButton
|
||||||
|
v-if="canView"
|
||||||
|
variant="primary"
|
||||||
|
:label="t('commercial.clients.export')"
|
||||||
|
:disabled="exporting"
|
||||||
|
@click="exportXlsx"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<!-- Drawer de filtres : etat BROUILLON, applique uniquement au clic sur
|
||||||
|
« Appliquer ». Meme pattern que l'audit-log. Etat 100 % local, jamais
|
||||||
|
dans l'URL (regle ABSOLUE n°6). -->
|
||||||
|
<MalioDrawer
|
||||||
|
v-model="filterDrawerOpen"
|
||||||
|
drawer-class="max-w-[450px]"
|
||||||
|
body-class="p-0"
|
||||||
|
footer-class="justify-between border-t border-black p-6"
|
||||||
|
>
|
||||||
|
<template #header>
|
||||||
|
<h2 class="text-[24px] font-bold uppercase">{{ t('commercial.clients.filters.title') }}</h2>
|
||||||
|
</template>
|
||||||
|
|
||||||
|
<MalioAccordion>
|
||||||
|
<!-- Recherche : nom societe + contact + email (param `search`). -->
|
||||||
|
<MalioAccordionItem :title="t('commercial.clients.filters.search')" value="search">
|
||||||
|
<MalioInputText
|
||||||
|
v-model="draftSearch"
|
||||||
|
icon-name="mdi:magnify"
|
||||||
|
/>
|
||||||
|
</MalioAccordionItem>
|
||||||
|
|
||||||
|
<!-- Categories : cases a cocher (multi). Valeur = code stable. -->
|
||||||
|
<MalioAccordionItem :title="t('commercial.clients.filters.categories')" value="categories">
|
||||||
|
<div class="flex flex-col">
|
||||||
|
<MalioCheckbox
|
||||||
|
v-for="opt in categoryOptions"
|
||||||
|
:id="`filter-category-${opt.value}`"
|
||||||
|
:key="opt.value"
|
||||||
|
:label="opt.label"
|
||||||
|
:model-value="draftCategoryCodes.includes(opt.value)"
|
||||||
|
@update:model-value="(val: boolean) => toggleCategory(opt.value, val)"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</MalioAccordionItem>
|
||||||
|
|
||||||
|
<!-- Sites : cases a cocher (multi). Valeur = id du site. -->
|
||||||
|
<MalioAccordionItem :title="t('commercial.clients.filters.sites')" value="sites">
|
||||||
|
<div class="flex flex-col">
|
||||||
|
<MalioCheckbox
|
||||||
|
v-for="opt in siteOptions"
|
||||||
|
:id="`filter-site-${opt.value}`"
|
||||||
|
:key="opt.value"
|
||||||
|
:label="opt.label"
|
||||||
|
:model-value="draftSiteIds.includes(opt.value)"
|
||||||
|
@update:model-value="(val: boolean) => toggleSite(opt.value, val)"
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
</MalioAccordionItem>
|
||||||
|
|
||||||
|
<!-- Statut : bool unique. Coche = archives uniquement, sinon actifs. -->
|
||||||
|
<MalioAccordionItem :title="t('commercial.clients.filters.status')" value="status">
|
||||||
|
<MalioCheckbox
|
||||||
|
id="filter-archived-only"
|
||||||
|
:label="t('commercial.clients.filters.archivedOnly')"
|
||||||
|
:model-value="draftArchivedOnly"
|
||||||
|
@update:model-value="(val: boolean) => draftArchivedOnly = val"
|
||||||
|
/>
|
||||||
|
</MalioAccordionItem>
|
||||||
|
</MalioAccordion>
|
||||||
|
|
||||||
|
<template #footer>
|
||||||
|
<MalioButton
|
||||||
|
variant="tertiary"
|
||||||
|
:label="t('commercial.clients.filters.reset')"
|
||||||
|
button-class="w-m-btn-action"
|
||||||
|
@click="resetFilters"
|
||||||
|
/>
|
||||||
|
<MalioButton
|
||||||
|
variant="primary"
|
||||||
|
:label="t('commercial.clients.filters.apply')"
|
||||||
|
button-class="w-[170px]"
|
||||||
|
@click="applyFilters"
|
||||||
|
/>
|
||||||
|
</template>
|
||||||
|
</MalioDrawer>
|
||||||
|
</div>
|
||||||
|
</template>
|
||||||
|
|
||||||
|
<script setup lang="ts">
|
||||||
|
import { computed, onMounted, ref } from 'vue'
|
||||||
|
import type { Client, ClientSite } from '~/modules/commercial/composables/useClientsRepository'
|
||||||
|
|
||||||
|
interface FilterOption {
|
||||||
|
value: string
|
||||||
|
label: string
|
||||||
|
}
|
||||||
|
|
||||||
|
const { t } = useI18n()
|
||||||
|
const api = useApi()
|
||||||
|
const router = useRouter()
|
||||||
|
const toast = useToast()
|
||||||
|
const { can } = usePermissions()
|
||||||
|
|
||||||
|
useHead({ title: t('commercial.clients.title') })
|
||||||
|
|
||||||
|
// Bouton « Ajouter » reserve a `manage` (POST /clients garde manage seul →
|
||||||
|
// Compta / Usine ne creent pas). « Exporter » et « Filtres » suivent `view`.
|
||||||
|
const canManage = computed(() => can('commercial.clients.manage'))
|
||||||
|
const canView = computed(() => can('commercial.clients.view'))
|
||||||
|
|
||||||
|
const {
|
||||||
|
items: clients,
|
||||||
|
totalItems,
|
||||||
|
currentPage,
|
||||||
|
itemsPerPage,
|
||||||
|
itemsPerPageOptions,
|
||||||
|
fetch: loadClients,
|
||||||
|
goToPage,
|
||||||
|
setItemsPerPage,
|
||||||
|
setFilters,
|
||||||
|
} = useClientsRepository()
|
||||||
|
|
||||||
|
// Mappe les clients en objets « plats » pour MalioDataTable (items typees
|
||||||
|
// Record<string, unknown>[]) : un objet litteral porte une signature d'index
|
||||||
|
// implicite, contrairement a l'interface Client. Meme pattern que sites.vue.
|
||||||
|
const rows = computed(() => clients.value.map(client => ({
|
||||||
|
id: client.id,
|
||||||
|
companyName: client.companyName,
|
||||||
|
categories: client.categories,
|
||||||
|
sites: client.sites,
|
||||||
|
updatedAt: client.updatedAt,
|
||||||
|
})))
|
||||||
|
|
||||||
|
const columns = [
|
||||||
|
{ key: 'companyName', label: t('commercial.clients.column.companyName') },
|
||||||
|
{ key: 'categories', label: t('commercial.clients.column.categories') },
|
||||||
|
{ key: 'sites', label: t('commercial.clients.column.sites') },
|
||||||
|
{ key: 'lastActivity', label: t('commercial.clients.column.lastActivity') },
|
||||||
|
]
|
||||||
|
|
||||||
|
/** Codes des categories du client, separes par une virgule (ERP-78). */
|
||||||
|
function formatCategories(item: Record<string, unknown>): string {
|
||||||
|
const categories = (item.categories as Client['categories']) ?? []
|
||||||
|
return categories.map(c => c.code).join(', ')
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Derniere activite : faute de suivi d'activite metier au M1, on affiche la
|
||||||
|
* date de derniere modification de la fiche (updatedAt, expose en liste via
|
||||||
|
* default:read). Format court francais jj/mm/aaaa.
|
||||||
|
*/
|
||||||
|
function formatLastActivity(item: Record<string, unknown>): string {
|
||||||
|
const value = item.updatedAt as string | null | undefined
|
||||||
|
if (!value) {
|
||||||
|
return ''
|
||||||
|
}
|
||||||
|
|
||||||
|
// Garde-fou date invalide : un updatedAt mal forme donnerait « Invalid Date ».
|
||||||
|
const date = new Date(value)
|
||||||
|
if (Number.isNaN(date.getTime())) {
|
||||||
|
return ''
|
||||||
|
}
|
||||||
|
|
||||||
|
return date.toLocaleDateString('fr-FR')
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Clic sur une ligne → ecran Consultation (route a plat /clients/{id}). */
|
||||||
|
function onRowClick(item: Record<string, unknown>): void {
|
||||||
|
router.push(`/clients/${item.id}`)
|
||||||
|
}
|
||||||
|
|
||||||
|
function goToCreate(): void {
|
||||||
|
router.push('/clients/new')
|
||||||
|
}
|
||||||
|
|
||||||
|
// ── Filtres (drawer) ────────────────────────────────────────────────────────
|
||||||
|
// Deux niveaux d'etat (pattern audit-log) :
|
||||||
|
// - APPLIED : pilote la liste/l'export + le compteur du bouton. Modifie
|
||||||
|
// uniquement au clic « Appliquer » / « Réinitialiser ».
|
||||||
|
// - DRAFT : edite librement dans le drawer ; recopie vers applied a la validation.
|
||||||
|
const filterDrawerOpen = ref(false)
|
||||||
|
|
||||||
|
const draftSearch = ref('')
|
||||||
|
const draftCategoryCodes = ref<string[]>([])
|
||||||
|
const draftSiteIds = ref<string[]>([])
|
||||||
|
const draftArchivedOnly = ref(false)
|
||||||
|
|
||||||
|
const appliedSearch = ref('')
|
||||||
|
const appliedCategoryCodes = ref<string[]>([])
|
||||||
|
const appliedSiteIds = ref<string[]>([])
|
||||||
|
const appliedArchivedOnly = ref(false)
|
||||||
|
|
||||||
|
// Options des selects multi, chargees une fois (referentiels courts).
|
||||||
|
const categoryOptions = ref<FilterOption[]>([])
|
||||||
|
const siteOptions = ref<FilterOption[]>([])
|
||||||
|
|
||||||
|
const activeFilterCount = computed(() => {
|
||||||
|
let count = 0
|
||||||
|
if (appliedSearch.value.trim() !== '') count++
|
||||||
|
if (appliedCategoryCodes.value.length > 0) count++
|
||||||
|
if (appliedSiteIds.value.length > 0) count++
|
||||||
|
if (appliedArchivedOnly.value) count++
|
||||||
|
return count
|
||||||
|
})
|
||||||
|
|
||||||
|
const filterButtonLabel = computed(() => {
|
||||||
|
const base = t('commercial.clients.filters.title')
|
||||||
|
return activeFilterCount.value > 0 ? `${base} (${activeFilterCount.value})` : base
|
||||||
|
})
|
||||||
|
|
||||||
|
// Recopie l'etat applique vers le brouillon puis ouvre le drawer : la
|
||||||
|
// reouverture reflete les filtres actifs.
|
||||||
|
function openFilters(): void {
|
||||||
|
draftSearch.value = appliedSearch.value
|
||||||
|
draftCategoryCodes.value = [...appliedCategoryCodes.value]
|
||||||
|
draftSiteIds.value = [...appliedSiteIds.value]
|
||||||
|
draftArchivedOnly.value = appliedArchivedOnly.value
|
||||||
|
filterDrawerOpen.value = true
|
||||||
|
}
|
||||||
|
|
||||||
|
function toggleCategory(code: string, selected: boolean): void {
|
||||||
|
draftCategoryCodes.value = selected
|
||||||
|
? [...draftCategoryCodes.value, code]
|
||||||
|
: draftCategoryCodes.value.filter(c => c !== code)
|
||||||
|
}
|
||||||
|
|
||||||
|
function toggleSite(id: string, selected: boolean): void {
|
||||||
|
draftSiteIds.value = selected
|
||||||
|
? [...draftSiteIds.value, id]
|
||||||
|
: draftSiteIds.value.filter(s => s !== id)
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Construit le payload de filtres serveur a partir de l'etat applique. Cles
|
||||||
|
* `categoryCode[]` / `siteId[]` pour que PHP les parse en tableaux (OR cote back).
|
||||||
|
* Les filtres vides sont omis pour une query propre.
|
||||||
|
*/
|
||||||
|
function buildFilterPayload(): Record<string, string | string[] | boolean> {
|
||||||
|
const payload: Record<string, string | string[] | boolean> = {}
|
||||||
|
if (appliedSearch.value.trim() !== '') payload.search = appliedSearch.value.trim()
|
||||||
|
if (appliedCategoryCodes.value.length > 0) payload['categoryCode[]'] = [...appliedCategoryCodes.value]
|
||||||
|
if (appliedSiteIds.value.length > 0) payload['siteId[]'] = [...appliedSiteIds.value]
|
||||||
|
if (appliedArchivedOnly.value) payload.archivedOnly = true
|
||||||
|
return payload
|
||||||
|
}
|
||||||
|
|
||||||
|
// « Appliquer » : recopie brouillon → applied, pousse les filtres (retombe en
|
||||||
|
// page 1 via usePaginatedList) et ferme le drawer.
|
||||||
|
function applyFilters(): void {
|
||||||
|
appliedSearch.value = draftSearch.value.trim()
|
||||||
|
appliedCategoryCodes.value = [...draftCategoryCodes.value]
|
||||||
|
appliedSiteIds.value = [...draftSiteIds.value]
|
||||||
|
appliedArchivedOnly.value = draftArchivedOnly.value
|
||||||
|
|
||||||
|
setFilters(buildFilterPayload(), { replace: true })
|
||||||
|
filterDrawerOpen.value = false
|
||||||
|
}
|
||||||
|
|
||||||
|
// « Réinitialiser » : vide brouillon ET applied, recharge la liste complete.
|
||||||
|
// Le drawer reste ouvert pour montrer le formulaire vide.
|
||||||
|
function resetFilters(): void {
|
||||||
|
draftSearch.value = ''
|
||||||
|
draftCategoryCodes.value = []
|
||||||
|
draftSiteIds.value = []
|
||||||
|
draftArchivedOnly.value = false
|
||||||
|
|
||||||
|
appliedSearch.value = ''
|
||||||
|
appliedCategoryCodes.value = []
|
||||||
|
appliedSiteIds.value = []
|
||||||
|
appliedArchivedOnly.value = false
|
||||||
|
|
||||||
|
setFilters({}, { replace: true })
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Charge les referentiels du drawer (categories + sites) via ?pagination=false. */
|
||||||
|
async function loadFilterOptions(): Promise<void> {
|
||||||
|
const [cats, sites] = await Promise.all([
|
||||||
|
api.get<{ member?: Array<{ code: string, name: string }> }>(
|
||||||
|
'/categories',
|
||||||
|
{ pagination: 'false' },
|
||||||
|
{ headers: { Accept: 'application/ld+json' }, toast: false },
|
||||||
|
),
|
||||||
|
api.get<{ member?: Array<{ id: number, name: string }> }>(
|
||||||
|
'/sites',
|
||||||
|
{ pagination: 'false' },
|
||||||
|
{ headers: { Accept: 'application/ld+json' }, toast: false },
|
||||||
|
),
|
||||||
|
])
|
||||||
|
|
||||||
|
categoryOptions.value = (cats.member ?? []).map(c => ({ value: c.code, label: c.name }))
|
||||||
|
siteOptions.value = (sites.member ?? []).map(s => ({ value: String(s.id), label: s.name }))
|
||||||
|
}
|
||||||
|
|
||||||
|
// ── Export XLSX ─────────────────────────────────────────────────────────────
|
||||||
|
// Memes filtres que la vue. La colonne SIREN n'est dans le fichier que si
|
||||||
|
// l'utilisateur a accounting.view (gere cote back).
|
||||||
|
const exporting = ref(false)
|
||||||
|
|
||||||
|
async function exportXlsx(): Promise<void> {
|
||||||
|
if (exporting.value) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
exporting.value = true
|
||||||
|
try {
|
||||||
|
// useApi type ses options en JSON ; l'export renvoie un binaire, donc on
|
||||||
|
// force responseType:'blob' (transmis tel quel a ofetch au runtime). Cast
|
||||||
|
// contenu faute d'overload blob sur le client partage — a generaliser via
|
||||||
|
// un ticket dedie si d'autres exports binaires arrivent.
|
||||||
|
const blob = await api.get<Blob>('/clients/export.xlsx', buildFilterPayload(), {
|
||||||
|
responseType: 'blob',
|
||||||
|
toast: false,
|
||||||
|
} as unknown as Parameters<typeof api.get>[2])
|
||||||
|
|
||||||
|
triggerDownload(blob, 'repertoire-clients.xlsx')
|
||||||
|
}
|
||||||
|
catch {
|
||||||
|
toast.error({
|
||||||
|
title: t('commercial.clients.toast.error'),
|
||||||
|
message: t('commercial.clients.toast.exportError'),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
finally {
|
||||||
|
exporting.value = false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Declenche le telechargement d'un blob via un lien temporaire. */
|
||||||
|
function triggerDownload(blob: Blob, filename: string): void {
|
||||||
|
const url = URL.createObjectURL(blob)
|
||||||
|
const link = document.createElement('a')
|
||||||
|
link.href = url
|
||||||
|
link.download = filename
|
||||||
|
document.body.appendChild(link)
|
||||||
|
link.click()
|
||||||
|
link.remove()
|
||||||
|
URL.revokeObjectURL(url)
|
||||||
|
}
|
||||||
|
|
||||||
|
onMounted(() => {
|
||||||
|
loadClients()
|
||||||
|
// Echec du chargement des referentiels non bloquant : la liste s'affiche,
|
||||||
|
// l'utilisateur perd juste les options de filtre.
|
||||||
|
loadFilterOptions().catch(() => {
|
||||||
|
categoryOptions.value = []
|
||||||
|
siteOptions.value = []
|
||||||
|
})
|
||||||
|
})
|
||||||
|
</script>
|
||||||
@@ -0,0 +1,23 @@
|
|||||||
|
import { describe, it, expect } from 'vitest'
|
||||||
|
import { formatPhoneFR } from '../phone'
|
||||||
|
|
||||||
|
describe('formatPhoneFR', () => {
|
||||||
|
it('formate un numero 10 chiffres en XX XX XX XX XX', () => {
|
||||||
|
expect(formatPhoneFR('0612345678')).toBe('06 12 34 56 78')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('tolere une saisie deja pointee ou espacee', () => {
|
||||||
|
expect(formatPhoneFR('06.12.34.56.78')).toBe('06 12 34 56 78')
|
||||||
|
expect(formatPhoneFR('06 12 34 56 78')).toBe('06 12 34 56 78')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('retourne une chaine vide pour une valeur vide ou nulle', () => {
|
||||||
|
expect(formatPhoneFR('')).toBe('')
|
||||||
|
expect(formatPhoneFR(null)).toBe('')
|
||||||
|
expect(formatPhoneFR(undefined)).toBe('')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('groupe par 2 meme un nombre impair de chiffres (dernier groupe seul)', () => {
|
||||||
|
expect(formatPhoneFR('123')).toBe('12 3')
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -0,0 +1,23 @@
|
|||||||
|
/**
|
||||||
|
* Formatage d'un numero de telephone francais en groupes de 2 chiffres
|
||||||
|
* (`XX XX XX XX XX`).
|
||||||
|
*
|
||||||
|
* Helper PARTAGE volontaire : les telephones sont presents un peu partout dans
|
||||||
|
* l'app (fiches clients, contacts, fournisseurs, prestataires...). Introduit ici
|
||||||
|
* comme util transverse stable plutot que duplique a chaque ecran. La signature
|
||||||
|
* `formatPhoneFR(value): string` est coordonnee avec ERP-66, qui pourra enrichir
|
||||||
|
* l'implementation (validation, indicatif international) sans casser les appelants.
|
||||||
|
*
|
||||||
|
* - Ne garde que les chiffres puis groupe par 2 (tolere une saisie deja espacee
|
||||||
|
* ou pointee, ex: `06.12.34.56.78` ou `0612345678`).
|
||||||
|
* - Retourne une chaine vide si la valeur est vide/nulle (cellule vide propre).
|
||||||
|
*/
|
||||||
|
export function formatPhoneFR(value: string | null | undefined): string {
|
||||||
|
const digits = (value ?? '').replace(/\D/g, '')
|
||||||
|
if (digits.length === 0) {
|
||||||
|
return ''
|
||||||
|
}
|
||||||
|
|
||||||
|
// Groupe par paquets de 2 ; un dernier groupe impair reste tel quel.
|
||||||
|
return digits.match(/.{1,2}/g)?.join(' ') ?? digits
|
||||||
|
}
|
||||||
@@ -15,6 +15,7 @@ use App\Module\Commercial\Infrastructure\Doctrine\DoctrineClientRepository;
|
|||||||
use App\Shared\Domain\Attribute\Auditable;
|
use App\Shared\Domain\Attribute\Auditable;
|
||||||
use App\Shared\Domain\Contract\BlamableInterface;
|
use App\Shared\Domain\Contract\BlamableInterface;
|
||||||
use App\Shared\Domain\Contract\CategoryInterface;
|
use App\Shared\Domain\Contract\CategoryInterface;
|
||||||
|
use App\Shared\Domain\Contract\SiteInterface;
|
||||||
use App\Shared\Domain\Contract\TimestampableInterface;
|
use App\Shared\Domain\Contract\TimestampableInterface;
|
||||||
use App\Shared\Domain\Trait\TimestampableBlamableTrait;
|
use App\Shared\Domain\Trait\TimestampableBlamableTrait;
|
||||||
use DateTimeImmutable;
|
use DateTimeImmutable;
|
||||||
@@ -58,27 +59,39 @@ use Symfony\Component\Validator\Constraints as Assert;
|
|||||||
operations: [
|
operations: [
|
||||||
new GetCollection(
|
new GetCollection(
|
||||||
security: "is_granted('commercial.clients.view')",
|
security: "is_granted('commercial.clients.view')",
|
||||||
normalizationContext: ['groups' => ['client:read', 'default:read']],
|
// La liste embarque les categories (avec leur code, groupe
|
||||||
|
// category:read) et les sites agreges des adresses (groupe
|
||||||
|
// site:read) pour alimenter les colonnes « Catégories » et
|
||||||
|
// « Site(s) » du Repertoire (ERP-62). Cf. getSites() plus bas.
|
||||||
|
normalizationContext: ['groups' => ['client:read', 'default:read', 'category:read', 'site:read']],
|
||||||
provider: ClientProvider::class,
|
provider: ClientProvider::class,
|
||||||
),
|
),
|
||||||
new Get(
|
new Get(
|
||||||
security: "is_granted('commercial.clients.view')",
|
security: "is_granted('commercial.clients.view')",
|
||||||
// Detail : client + sous-collections embarquees. Le groupe
|
// Detail : client + sous-collections embarquees.
|
||||||
// client:read:accounting est ajoute par le context builder selon la
|
// - client:read:accounting est ajoute par le context builder selon la
|
||||||
// permission, donc absent ici volontairement.
|
// permission (gate les scalaires comptables ET les RIB embarques),
|
||||||
|
// donc absent ici volontairement.
|
||||||
|
// - client_rib:read N'EST PLUS dans le contexte : le contenu des RIB
|
||||||
|
// embarques est desormais porte par client:read:accounting (gate),
|
||||||
|
// ce qui retire la fuite IBAN/BIC vers les users sans accounting.view.
|
||||||
|
// - category:read et site:read sont indispensables pour embarquer le
|
||||||
|
// code/libelle des categories et des sites (sinon stub IRI nu) :
|
||||||
|
// Category.code/name vivent sous category:read, Site.name sous site:read.
|
||||||
normalizationContext: ['groups' => [
|
normalizationContext: ['groups' => [
|
||||||
'client:read',
|
'client:read',
|
||||||
'client:item:read',
|
'client:item:read',
|
||||||
'client_contact:read',
|
'client_contact:read',
|
||||||
'client_address:read',
|
'client_address:read',
|
||||||
'client_rib:read',
|
'category:read',
|
||||||
|
'site:read',
|
||||||
'default:read',
|
'default:read',
|
||||||
]],
|
]],
|
||||||
provider: ClientProvider::class,
|
provider: ClientProvider::class,
|
||||||
),
|
),
|
||||||
new Post(
|
new Post(
|
||||||
security: "is_granted('commercial.clients.manage')",
|
security: "is_granted('commercial.clients.manage')",
|
||||||
normalizationContext: ['groups' => ['client:read', 'default:read']],
|
normalizationContext: ['groups' => ['client:read', 'default:read', 'category:read', 'site:read']],
|
||||||
denormalizationContext: ['groups' => ['client:write:main']],
|
denormalizationContext: ['groups' => ['client:write:main']],
|
||||||
processor: ClientProcessor::class,
|
processor: ClientProcessor::class,
|
||||||
),
|
),
|
||||||
@@ -96,7 +109,7 @@ use Symfony\Component\Validator\Constraints as Assert;
|
|||||||
// autoriser/refuser onglet par onglet (RG-1.22 / RG-1.28) : les
|
// autoriser/refuser onglet par onglet (RG-1.22 / RG-1.28) : les
|
||||||
// champs accounting exigent accounting.manage, isArchived exige
|
// champs accounting exigent accounting.manage, isArchived exige
|
||||||
// archive, le reste (main/information) exige manage.
|
// archive, le reste (main/information) exige manage.
|
||||||
normalizationContext: ['groups' => ['client:read', 'default:read']],
|
normalizationContext: ['groups' => ['client:read', 'default:read', 'category:read', 'site:read']],
|
||||||
denormalizationContext: ['groups' => [
|
denormalizationContext: ['groups' => [
|
||||||
'client:write:main',
|
'client:write:main',
|
||||||
'client:write:information',
|
'client:write:information',
|
||||||
@@ -651,8 +664,38 @@ class Client implements TimestampableInterface, BlamableInterface
|
|||||||
return $this;
|
return $this;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Sites distincts rattaches a au moins une adresse du client (RG-1.10).
|
||||||
|
* Le Client ne porte pas de sites en propre : ils vivent sur les adresses.
|
||||||
|
* Agrege en lecture seule pour la colonne « Site(s) » du Repertoire (badges
|
||||||
|
* colores) — expose en LISTE via le groupe client:read (les adresses
|
||||||
|
* completes restent reservees au detail, client:item:read).
|
||||||
|
*
|
||||||
|
* @return list<SiteInterface>
|
||||||
|
*/
|
||||||
|
#[Groups(['client:read'])]
|
||||||
|
public function getSites(): array
|
||||||
|
{
|
||||||
|
$sites = [];
|
||||||
|
foreach ($this->addresses as $address) {
|
||||||
|
foreach ($address->getSites() as $site) {
|
||||||
|
// Deduplication par identite d'objet : un meme site peut etre
|
||||||
|
// rattache a plusieurs adresses du client.
|
||||||
|
$sites[spl_object_id($site)] = $site;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return array_values($sites);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Embed gate sur le groupe COMPTABLE (et non client:item:read comme contacts/
|
||||||
|
// adresses) : client:read:accounting n'est ajoute au contexte que si l'user a
|
||||||
|
// accounting.view (ClientReadGroupContextBuilder). Resultat : la cle `ribs` est
|
||||||
|
// TOTALEMENT ABSENTE du detail pour un user sans accounting.view (ex. Commerciale),
|
||||||
|
// au meme titre que les scalaires comptables — corrige la fuite de RIB ou la
|
||||||
|
// Commerciale recevait IBAN/BIC en clair.
|
||||||
/** @return Collection<int, ClientRib> */
|
/** @return Collection<int, ClientRib> */
|
||||||
#[Groups(['client:item:read'])]
|
#[Groups(['client:read:accounting'])]
|
||||||
public function getRibs(): Collection
|
public function getRibs(): Collection
|
||||||
{
|
{
|
||||||
return $this->ribs;
|
return $this->ribs;
|
||||||
|
|||||||
@@ -22,6 +22,7 @@ use Doctrine\Common\Collections\ArrayCollection;
|
|||||||
use Doctrine\Common\Collections\Collection;
|
use Doctrine\Common\Collections\Collection;
|
||||||
use Doctrine\ORM\Mapping as ORM;
|
use Doctrine\ORM\Mapping as ORM;
|
||||||
use Symfony\Component\Serializer\Attribute\Groups;
|
use Symfony\Component\Serializer\Attribute\Groups;
|
||||||
|
use Symfony\Component\Serializer\Attribute\SerializedName;
|
||||||
use Symfony\Component\Validator\Constraints as Assert;
|
use Symfony\Component\Validator\Constraints as Assert;
|
||||||
use Symfony\Component\Validator\Context\ExecutionContextInterface;
|
use Symfony\Component\Validator\Context\ExecutionContextInterface;
|
||||||
|
|
||||||
@@ -104,16 +105,23 @@ class ClientAddress implements TimestampableInterface, BlamableInterface
|
|||||||
#[ORM\JoinColumn(name: 'client_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
|
#[ORM\JoinColumn(name: 'client_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
|
||||||
private ?Client $client = null;
|
private ?Client $client = null;
|
||||||
|
|
||||||
|
// Groupe d'ECRITURE uniquement sur la propriete (denormalisation PATCH/POST).
|
||||||
|
// Le groupe de LECTURE est porte par le getter isProspect()/isDelivery()/
|
||||||
|
// isBilling() avec SerializedName : sans cela, Symfony strip le prefixe "is"
|
||||||
|
// des getters booleens et exposerait les cles "prospect"/"delivery"/"billing"
|
||||||
|
// — en pratique le #[Groups] etant sur la propriete `isX` et le getter
|
||||||
|
// derivant l'attribut `x`, la cle etait totalement DROPPEE du JSON (meme bug
|
||||||
|
// que Client::isArchived). Pattern corrige : Groups + SerializedName sur le getter.
|
||||||
#[ORM\Column(name: 'is_prospect', options: ['default' => false])]
|
#[ORM\Column(name: 'is_prospect', options: ['default' => false])]
|
||||||
#[Groups(['client_address:read', 'client_address:write'])]
|
#[Groups(['client_address:write'])]
|
||||||
private bool $isProspect = false;
|
private bool $isProspect = false;
|
||||||
|
|
||||||
#[ORM\Column(name: 'is_delivery', options: ['default' => false])]
|
#[ORM\Column(name: 'is_delivery', options: ['default' => false])]
|
||||||
#[Groups(['client_address:read', 'client_address:write'])]
|
#[Groups(['client_address:write'])]
|
||||||
private bool $isDelivery = false;
|
private bool $isDelivery = false;
|
||||||
|
|
||||||
#[ORM\Column(name: 'is_billing', options: ['default' => false])]
|
#[ORM\Column(name: 'is_billing', options: ['default' => false])]
|
||||||
#[Groups(['client_address:read', 'client_address:write'])]
|
#[Groups(['client_address:write'])]
|
||||||
private bool $isBilling = false;
|
private bool $isBilling = false;
|
||||||
|
|
||||||
#[ORM\Column(length: 80, options: ['default' => 'France'])]
|
#[ORM\Column(length: 80, options: ['default' => 'France'])]
|
||||||
@@ -276,6 +284,12 @@ class ClientAddress implements TimestampableInterface, BlamableInterface
|
|||||||
return $this;
|
return $this;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Groupe de lecture + nom serialise explicite (cf. note sur la propriete) :
|
||||||
|
// sans SerializedName, Symfony exposerait la cle "prospect" (strip du prefixe
|
||||||
|
// "is" sur les getters) et, le groupe etant declare sur la propriete `isProspect`,
|
||||||
|
// droppait silencieusement la cle du JSON.
|
||||||
|
#[Groups(['client_address:read'])]
|
||||||
|
#[SerializedName('isProspect')]
|
||||||
public function isProspect(): bool
|
public function isProspect(): bool
|
||||||
{
|
{
|
||||||
return $this->isProspect;
|
return $this->isProspect;
|
||||||
@@ -288,6 +302,8 @@ class ClientAddress implements TimestampableInterface, BlamableInterface
|
|||||||
return $this;
|
return $this;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[Groups(['client_address:read'])]
|
||||||
|
#[SerializedName('isDelivery')]
|
||||||
public function isDelivery(): bool
|
public function isDelivery(): bool
|
||||||
{
|
{
|
||||||
return $this->isDelivery;
|
return $this->isDelivery;
|
||||||
@@ -300,6 +316,8 @@ class ClientAddress implements TimestampableInterface, BlamableInterface
|
|||||||
return $this;
|
return $this;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[Groups(['client_address:read'])]
|
||||||
|
#[SerializedName('isBilling')]
|
||||||
public function isBilling(): bool
|
public function isBilling(): bool
|
||||||
{
|
{
|
||||||
return $this->isBilling;
|
return $this->isBilling;
|
||||||
|
|||||||
@@ -79,10 +79,17 @@ class ClientRib implements TimestampableInterface, BlamableInterface
|
|||||||
{
|
{
|
||||||
use TimestampableBlamableTrait;
|
use TimestampableBlamableTrait;
|
||||||
|
|
||||||
|
// Double groupe de lecture :
|
||||||
|
// - `client_rib:read` : sous-ressource autonome GET /api/client_ribs/{id}
|
||||||
|
// (deja securisee par commercial.clients.accounting.view).
|
||||||
|
// - `client:read:accounting` : embed des RIB sous le detail Client, ajoute
|
||||||
|
// DYNAMIQUEMENT par ClientReadGroupContextBuilder uniquement si l'user a
|
||||||
|
// accounting.view. Ce double marquage gate les RIB embarques au meme titre
|
||||||
|
// que les scalaires comptables (RG : la Commerciale ne voit aucun RIB).
|
||||||
#[ORM\Id]
|
#[ORM\Id]
|
||||||
#[ORM\GeneratedValue]
|
#[ORM\GeneratedValue]
|
||||||
#[ORM\Column]
|
#[ORM\Column]
|
||||||
#[Groups(['client_rib:read'])]
|
#[Groups(['client_rib:read', 'client:read:accounting'])]
|
||||||
private ?int $id = null;
|
private ?int $id = null;
|
||||||
|
|
||||||
#[ORM\ManyToOne(targetEntity: Client::class, inversedBy: 'ribs')]
|
#[ORM\ManyToOne(targetEntity: Client::class, inversedBy: 'ribs')]
|
||||||
@@ -92,23 +99,23 @@ class ClientRib implements TimestampableInterface, BlamableInterface
|
|||||||
#[ORM\Column(length: 120)]
|
#[ORM\Column(length: 120)]
|
||||||
#[Assert\NotBlank]
|
#[Assert\NotBlank]
|
||||||
#[Assert\Length(max: 120, normalizer: 'trim')]
|
#[Assert\Length(max: 120, normalizer: 'trim')]
|
||||||
#[Groups(['client_rib:read', 'client_rib:write'])]
|
#[Groups(['client_rib:read', 'client:read:accounting', 'client_rib:write'])]
|
||||||
private ?string $label = null;
|
private ?string $label = null;
|
||||||
|
|
||||||
#[ORM\Column(length: 20)]
|
#[ORM\Column(length: 20)]
|
||||||
#[Assert\NotBlank]
|
#[Assert\NotBlank]
|
||||||
#[Assert\Bic]
|
#[Assert\Bic]
|
||||||
#[Groups(['client_rib:read', 'client_rib:write'])]
|
#[Groups(['client_rib:read', 'client:read:accounting', 'client_rib:write'])]
|
||||||
private ?string $bic = null;
|
private ?string $bic = null;
|
||||||
|
|
||||||
#[ORM\Column(length: 34)]
|
#[ORM\Column(length: 34)]
|
||||||
#[Assert\NotBlank]
|
#[Assert\NotBlank]
|
||||||
#[Assert\Iban]
|
#[Assert\Iban]
|
||||||
#[Groups(['client_rib:read', 'client_rib:write'])]
|
#[Groups(['client_rib:read', 'client:read:accounting', 'client_rib:write'])]
|
||||||
private ?string $iban = null;
|
private ?string $iban = null;
|
||||||
|
|
||||||
#[ORM\Column(options: ['default' => 0])]
|
#[ORM\Column(options: ['default' => 0])]
|
||||||
#[Groups(['client_rib:read', 'client_rib:write'])]
|
#[Groups(['client_rib:read', 'client:read:accounting', 'client_rib:write'])]
|
||||||
private int $position = 0;
|
private int $position = 0;
|
||||||
|
|
||||||
public function getId(): ?int
|
public function getId(): ?int
|
||||||
|
|||||||
@@ -16,21 +16,31 @@ interface ClientRepositoryInterface
|
|||||||
/**
|
/**
|
||||||
* Construit un QueryBuilder de liste pour le repertoire clients.
|
* Construit un QueryBuilder de liste pour le repertoire clients.
|
||||||
* - Exclut toujours les clients soft-deletes (deleted_at IS NOT NULL, RG-1.24).
|
* - Exclut toujours les clients soft-deletes (deleted_at IS NOT NULL, RG-1.24).
|
||||||
* - Exclut les archives sauf si $includeArchived = true (RG-1.25).
|
* - Archivage (RG-1.25) :
|
||||||
|
* - $archivedOnly = true -> uniquement les archives (is_archived = true) ;
|
||||||
|
* - sinon $includeArchived = true -> actifs + archives (echappatoire) ;
|
||||||
|
* - sinon (defaut) -> uniquement les actifs (is_archived = false).
|
||||||
|
* $archivedOnly a la priorite sur $includeArchived.
|
||||||
* - Tri par defaut : companyName ASC (RG-1.26).
|
* - Tri par defaut : companyName ASC (RG-1.26).
|
||||||
* - $search : recherche fuzzy insensible a la casse sur companyName +
|
* - $search : recherche fuzzy insensible a la casse sur companyName +
|
||||||
* lastName + email (metacaracteres LIKE echappes). Ignore si null/vide.
|
* lastName + email (metacaracteres LIKE echappes). Ignore si null/vide.
|
||||||
* - $categoryCode : restreint aux clients possedant au moins une categorie
|
* - $categoryCodes : restreint aux clients possedant au moins une categorie
|
||||||
* du code donne (ERP-78 : filtrage par code de Category, plus par type).
|
* dont le code est dans la liste (OR — ERP-78). Liste vide = pas de filtre.
|
||||||
* Ignore si null/vide.
|
* - $siteIds : restreint aux clients ayant au moins une adresse rattachee a
|
||||||
|
* l'un des sites donnes (OR — RG-1.10). Liste vide = pas de filtre.
|
||||||
*
|
*
|
||||||
* Filtrage centralise ICI (et non dans les providers/controllers) pour que
|
* Filtrage centralise ICI (et non dans les providers/controllers) pour que
|
||||||
* la liste paginee (ClientProvider) et l'export (ClientExportController)
|
* la liste paginee (ClientProvider) et l'export (ClientExportController)
|
||||||
* partagent strictement la meme logique de selection.
|
* partagent strictement la meme logique de selection.
|
||||||
|
*
|
||||||
|
* @param list<string> $categoryCodes
|
||||||
|
* @param list<int> $siteIds
|
||||||
*/
|
*/
|
||||||
public function createListQueryBuilder(
|
public function createListQueryBuilder(
|
||||||
bool $includeArchived = false,
|
bool $includeArchived = false,
|
||||||
?string $search = null,
|
?string $search = null,
|
||||||
?string $categoryCode = null,
|
array $categoryCodes = [],
|
||||||
|
array $siteIds = [],
|
||||||
|
bool $archivedOnly = false,
|
||||||
): QueryBuilder;
|
): QueryBuilder;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -64,14 +64,20 @@ final class ClientProvider implements ProviderInterface
|
|||||||
{
|
{
|
||||||
$filters = $context['filters'] ?? [];
|
$filters = $context['filters'] ?? [];
|
||||||
$includeArchived = $this->readBool($filters['includeArchived'] ?? false);
|
$includeArchived = $this->readBool($filters['includeArchived'] ?? false);
|
||||||
|
$archivedOnly = $this->readBool($filters['archivedOnly'] ?? false);
|
||||||
$search = $filters['search'] ?? null;
|
$search = $filters['search'] ?? null;
|
||||||
$categoryCode = $filters['categoryCode'] ?? null;
|
// categoryCode accepte un code unique (?categoryCode=DISTRIBUTEUR, selects
|
||||||
|
// RG-1.03) OU une liste (?categoryCode[]=A&categoryCode[]=B, drawer multi).
|
||||||
|
$categoryCodes = $this->readStringList($filters['categoryCode'] ?? []);
|
||||||
|
$siteIds = $this->readIntList($filters['siteId'] ?? []);
|
||||||
|
|
||||||
// Filtrage delegue au repository (logique partagee avec l'export XLSX).
|
// Filtrage delegue au repository (logique partagee avec l'export XLSX).
|
||||||
$qb = $this->repository->createListQueryBuilder(
|
$qb = $this->repository->createListQueryBuilder(
|
||||||
$includeArchived,
|
$includeArchived,
|
||||||
is_string($search) ? $search : null,
|
is_string($search) ? $search : null,
|
||||||
is_string($categoryCode) ? $categoryCode : null,
|
$categoryCodes,
|
||||||
|
$siteIds,
|
||||||
|
$archivedOnly,
|
||||||
);
|
);
|
||||||
|
|
||||||
// Echappatoire ?pagination=false : collection complete sans Paginator
|
// Echappatoire ?pagination=false : collection complete sans Paginator
|
||||||
@@ -127,4 +133,44 @@ final class ClientProvider implements ProviderInterface
|
|||||||
|
|
||||||
return is_string($raw) && in_array(strtolower($raw), ['true', '1'], true);
|
return is_string($raw) && in_array(strtolower($raw), ['true', '1'], true);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Normalise un filtre en liste de chaines. Tolere un code unique (string)
|
||||||
|
* ou une liste (?key[]=a&key[]=b). Trim + retrait des vides.
|
||||||
|
*
|
||||||
|
* @return list<string>
|
||||||
|
*/
|
||||||
|
private function readStringList(mixed $raw): array
|
||||||
|
{
|
||||||
|
$values = is_array($raw) ? $raw : [$raw];
|
||||||
|
|
||||||
|
$out = [];
|
||||||
|
foreach ($values as $value) {
|
||||||
|
if (is_string($value) && '' !== trim($value)) {
|
||||||
|
$out[] = trim($value);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $out;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Normalise un filtre en liste d'identifiants entiers positifs. Tolere une
|
||||||
|
* valeur unique ou une liste (?key[]=1&key[]=2).
|
||||||
|
*
|
||||||
|
* @return list<int>
|
||||||
|
*/
|
||||||
|
private function readIntList(mixed $raw): array
|
||||||
|
{
|
||||||
|
$values = is_array($raw) ? $raw : [$raw];
|
||||||
|
|
||||||
|
$out = [];
|
||||||
|
foreach ($values as $value) {
|
||||||
|
if ((is_int($value) || (is_string($value) && ctype_digit($value))) && (int) $value > 0) {
|
||||||
|
$out[] = (int) $value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $out;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -52,12 +52,19 @@ final class ClientExportController
|
|||||||
public function __invoke(Request $request): Response
|
public function __invoke(Request $request): Response
|
||||||
{
|
{
|
||||||
$includeArchived = $this->readBool($request->query->get('includeArchived'));
|
$includeArchived = $this->readBool($request->query->get('includeArchived'));
|
||||||
|
$archivedOnly = $this->readBool($request->query->get('archivedOnly'));
|
||||||
$search = $request->query->getString('search') ?: null;
|
$search = $request->query->getString('search') ?: null;
|
||||||
$categoryCode = $request->query->getString('categoryCode') ?: null;
|
|
||||||
|
// Memes filtres que la vue liste : categoryCode/siteId tolerent une valeur
|
||||||
|
// unique ou une liste (?categoryCode[]=A&siteId[]=1). On lit via all() pour
|
||||||
|
// ne pas lever d'exception sur une valeur scalaire.
|
||||||
|
$query = $request->query->all();
|
||||||
|
$categoryCodes = $this->readStringList($query['categoryCode'] ?? []);
|
||||||
|
$siteIds = $this->readIntList($query['siteId'] ?? []);
|
||||||
|
|
||||||
/** @var list<Client> $clients */
|
/** @var list<Client> $clients */
|
||||||
$clients = $this->repository
|
$clients = $this->repository
|
||||||
->createListQueryBuilder($includeArchived, $search, $categoryCode)
|
->createListQueryBuilder($includeArchived, $search, $categoryCodes, $siteIds, $archivedOnly)
|
||||||
->getQuery()
|
->getQuery()
|
||||||
->getResult()
|
->getResult()
|
||||||
;
|
;
|
||||||
@@ -198,4 +205,44 @@ final class ClientExportController
|
|||||||
{
|
{
|
||||||
return is_string($raw) && in_array(strtolower($raw), ['true', '1'], true);
|
return is_string($raw) && in_array(strtolower($raw), ['true', '1'], true);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Normalise un filtre en liste de chaines (valeur unique ou liste).
|
||||||
|
* Aligne sur ClientProvider pour un comportement identique a la liste.
|
||||||
|
*
|
||||||
|
* @return list<string>
|
||||||
|
*/
|
||||||
|
private function readStringList(mixed $raw): array
|
||||||
|
{
|
||||||
|
$values = is_array($raw) ? $raw : [$raw];
|
||||||
|
|
||||||
|
$out = [];
|
||||||
|
foreach ($values as $value) {
|
||||||
|
if (is_string($value) && '' !== trim($value)) {
|
||||||
|
$out[] = trim($value);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $out;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Normalise un filtre en liste d'identifiants entiers positifs (valeur unique
|
||||||
|
* ou liste). Aligne sur ClientProvider.
|
||||||
|
*
|
||||||
|
* @return list<int>
|
||||||
|
*/
|
||||||
|
private function readIntList(mixed $raw): array
|
||||||
|
{
|
||||||
|
$values = is_array($raw) ? $raw : [$raw];
|
||||||
|
|
||||||
|
$out = [];
|
||||||
|
foreach ($values as $value) {
|
||||||
|
if ((is_int($value) || (is_string($value) && ctype_digit($value))) && (int) $value > 0) {
|
||||||
|
$out[] = (int) $value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $out;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -34,19 +34,34 @@ class DoctrineClientRepository extends ServiceEntityRepository implements Client
|
|||||||
public function createListQueryBuilder(
|
public function createListQueryBuilder(
|
||||||
bool $includeArchived = false,
|
bool $includeArchived = false,
|
||||||
?string $search = null,
|
?string $search = null,
|
||||||
?string $categoryCode = null,
|
array $categoryCodes = [],
|
||||||
|
array $siteIds = [],
|
||||||
|
bool $archivedOnly = false,
|
||||||
): QueryBuilder {
|
): QueryBuilder {
|
||||||
$qb = $this->createQueryBuilder('c')
|
$qb = $this->createQueryBuilder('c')
|
||||||
|
// Jointures + addSelect pour hydrater en une seule requete les
|
||||||
|
// collections affichees par le Repertoire (colonnes Catégories /
|
||||||
|
// Site(s)) : sans cela, la serialisation declenche un N+1 (une
|
||||||
|
// requete par client, puis par adresse). Le Paginator ORM
|
||||||
|
// (fetchJoinCollection: true, cf. ClientProvider) gere le COUNT
|
||||||
|
// malgre ces jointures to-many.
|
||||||
|
->leftJoin('c.categories', 'cat')->addSelect('cat')
|
||||||
|
->leftJoin('c.addresses', 'addr')->addSelect('addr')
|
||||||
|
->leftJoin('addr.sites', 'site')->addSelect('site')
|
||||||
->andWhere('c.deletedAt IS NULL')
|
->andWhere('c.deletedAt IS NULL')
|
||||||
->orderBy('c.companyName', 'ASC')
|
->orderBy('c.companyName', 'ASC')
|
||||||
;
|
;
|
||||||
|
|
||||||
if (!$includeArchived) {
|
// Perimetre d'archivage : archivedOnly prioritaire sur includeArchived.
|
||||||
|
if ($archivedOnly) {
|
||||||
|
$qb->andWhere('c.isArchived = true');
|
||||||
|
} elseif (!$includeArchived) {
|
||||||
$qb->andWhere('c.isArchived = false');
|
$qb->andWhere('c.isArchived = false');
|
||||||
}
|
}
|
||||||
|
|
||||||
$this->applySearch($qb, $search);
|
$this->applySearch($qb, $search);
|
||||||
$this->applyCategoryCode($qb, $categoryCode);
|
$this->applyCategoryCodes($qb, $categoryCodes);
|
||||||
|
$this->applySiteIds($qb, $siteIds);
|
||||||
|
|
||||||
return $qb;
|
return $qb;
|
||||||
}
|
}
|
||||||
@@ -73,15 +88,18 @@ class DoctrineClientRepository extends ServiceEntityRepository implements Client
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Restreint aux clients possedant au moins une categorie du code donne
|
* Restreint aux clients possedant au moins une categorie dont le code figure
|
||||||
* (ERP-78 : filtrage par code de Category, plus par type). Alimente notamment
|
* dans la liste (OR — ERP-78). Alimente le filtre « Catégories » du drawer
|
||||||
* les selects « distributeur » (categoryCode=DISTRIBUTEUR) et « courtier »
|
* (multi) ainsi que les selects « distributeur »/« courtier » (un seul code,
|
||||||
* (COURTIER) cote front (RG-1.03). Sous-requete IN (plutot qu'un JOIN sur la
|
* RG-1.03). Sous-requete IN (plutot qu'un JOIN sur la collection M2M) pour ne
|
||||||
* collection M2M) pour ne pas perturber le DISTINCT / ORDER BY principal.
|
* pas perturber le DISTINCT / ORDER BY principal.
|
||||||
|
*
|
||||||
|
* @param list<string> $categoryCodes
|
||||||
*/
|
*/
|
||||||
private function applyCategoryCode(QueryBuilder $qb, ?string $categoryCode): void
|
private function applyCategoryCodes(QueryBuilder $qb, array $categoryCodes): void
|
||||||
{
|
{
|
||||||
if (null === $categoryCode || '' === trim($categoryCode)) {
|
$codes = $this->normalizeStringList($categoryCodes);
|
||||||
|
if ([] === $codes) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -89,11 +107,84 @@ class DoctrineClientRepository extends ServiceEntityRepository implements Client
|
|||||||
->select('c2.id')
|
->select('c2.id')
|
||||||
->from(Client::class, 'c2')
|
->from(Client::class, 'c2')
|
||||||
->join('c2.categories', 'cat2')
|
->join('c2.categories', 'cat2')
|
||||||
->where('cat2.code = :categoryCode')
|
->where('cat2.code IN (:categoryCodes)')
|
||||||
;
|
;
|
||||||
|
|
||||||
$qb->andWhere($qb->expr()->in('c.id', $sub->getDQL()))
|
$qb->andWhere($qb->expr()->in('c.id', $sub->getDQL()))
|
||||||
->setParameter('categoryCode', trim($categoryCode))
|
->setParameter('categoryCodes', $codes)
|
||||||
;
|
;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Restreint aux clients ayant au moins une adresse rattachee a l'un des
|
||||||
|
* sites donnes (OR — RG-1.10 : les sites vivent sur les adresses, pas sur le
|
||||||
|
* client). Sous-requete IN pour ne pas perturber le tri/pagination principal.
|
||||||
|
*
|
||||||
|
* @param list<int> $siteIds
|
||||||
|
*/
|
||||||
|
private function applySiteIds(QueryBuilder $qb, array $siteIds): void
|
||||||
|
{
|
||||||
|
$ids = $this->normalizeIntList($siteIds);
|
||||||
|
if ([] === $ids) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
$sub = $this->getEntityManager()->createQueryBuilder()
|
||||||
|
->select('c3.id')
|
||||||
|
->from(Client::class, 'c3')
|
||||||
|
->join('c3.addresses', 'addr3')
|
||||||
|
->join('addr3.sites', 'site3')
|
||||||
|
->where('site3.id IN (:siteIds)')
|
||||||
|
;
|
||||||
|
|
||||||
|
$qb->andWhere($qb->expr()->in('c.id', $sub->getDQL()))
|
||||||
|
->setParameter('siteIds', $ids)
|
||||||
|
;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Nettoie une liste de chaines : trim, retrait des vides, reindexation.
|
||||||
|
* Defensive : tolere des elements scalaires non-string (cast) et ignore le
|
||||||
|
* reste sans lever de TypeError, le contrat etant justement de normaliser une
|
||||||
|
* entree potentiellement brute (query params).
|
||||||
|
*
|
||||||
|
* @param array<mixed> $values
|
||||||
|
*
|
||||||
|
* @return list<string>
|
||||||
|
*/
|
||||||
|
private function normalizeStringList(array $values): array
|
||||||
|
{
|
||||||
|
$out = [];
|
||||||
|
foreach ($values as $value) {
|
||||||
|
if (is_string($value) || is_int($value) || is_float($value)) {
|
||||||
|
$trimmed = trim((string) $value);
|
||||||
|
if ('' !== $trimmed) {
|
||||||
|
$out[] = $trimmed;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $out;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Nettoie une liste d'identifiants : cast int, retrait des <= 0, reindexation.
|
||||||
|
* Defensive (cf. normalizeStringList) : accepte des entiers ou des chaines
|
||||||
|
* numeriques ('1', '2') sans TypeError, ignore le reste.
|
||||||
|
*
|
||||||
|
* @param array<mixed> $values
|
||||||
|
*
|
||||||
|
* @return list<int>
|
||||||
|
*/
|
||||||
|
private function normalizeIntList(array $values): array
|
||||||
|
{
|
||||||
|
$out = [];
|
||||||
|
foreach ($values as $value) {
|
||||||
|
if (is_numeric($value) && (int) $value > 0) {
|
||||||
|
$out[] = (int) $value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $out;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,6 +4,11 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Tests\Module\Commercial\Api;
|
namespace App\Tests\Module\Commercial\Api;
|
||||||
|
|
||||||
|
use ApiPlatform\Symfony\Bundle\Test\Client;
|
||||||
|
use App\Module\Commercial\Domain\Entity\Client as ClientEntity;
|
||||||
|
use App\Module\Commercial\Domain\Entity\ClientAddress;
|
||||||
|
use App\Module\Sites\Domain\Entity\Site;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Tests fonctionnels de l'API /api/clients (M1) — branche ERP-55.
|
* Tests fonctionnels de l'API /api/clients (M1) — branche ERP-55.
|
||||||
*
|
*
|
||||||
@@ -325,4 +330,146 @@ final class ClientApiTest extends AbstractCommercialApiTestCase
|
|||||||
self::assertArrayHasKey('addresses', $data);
|
self::assertArrayHasKey('addresses', $data);
|
||||||
self::assertArrayHasKey('ribs', $data);
|
self::assertArrayHasKey('ribs', $data);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* ERP-62 : la LISTE doit alimenter les colonnes « Catégories » (codes) et
|
||||||
|
* « Site(s) » (badges name + color) du Repertoire. On verifie donc que la
|
||||||
|
* collection embarque le `code` de chaque categorie et les sites agreges des
|
||||||
|
* adresses (accessoire Client::getSites()).
|
||||||
|
*/
|
||||||
|
public function testListEmbedsCategoryCodesAndAggregatedSites(): void
|
||||||
|
{
|
||||||
|
$client = $this->createAdminClient();
|
||||||
|
|
||||||
|
// Client seede + une adresse rattachee a un site (fixtures Sites).
|
||||||
|
$seed = $this->seedClient('Embed List Co', false, 'DISTRIBUTEUR');
|
||||||
|
$em = $this->getEm();
|
||||||
|
$site = $em->getRepository(Site::class)->findOneBy([]);
|
||||||
|
self::assertNotNull($site, 'Aucun site seede : impossible de tester la colonne Site(s).');
|
||||||
|
|
||||||
|
$address = new ClientAddress();
|
||||||
|
$address->setClient($seed);
|
||||||
|
$address->setPostalCode('86100');
|
||||||
|
$address->setCity('Châtellerault');
|
||||||
|
$address->setStreet('1 rue du Test');
|
||||||
|
$address->addSite($site);
|
||||||
|
$em->persist($address);
|
||||||
|
$em->flush();
|
||||||
|
|
||||||
|
$member = $client->request('GET', '/api/clients?pagination=false', [
|
||||||
|
'headers' => ['Accept' => self::LD],
|
||||||
|
])->toArray()['member'];
|
||||||
|
|
||||||
|
$row = null;
|
||||||
|
foreach ($member as $candidate) {
|
||||||
|
if ('EMBED LIST CO' === $candidate['companyName']) {
|
||||||
|
$row = $candidate;
|
||||||
|
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
self::assertNotNull($row, 'Le client seede doit figurer dans la liste.');
|
||||||
|
|
||||||
|
// Colonne « Catégories » : chaque categorie embarquee porte son code.
|
||||||
|
self::assertNotEmpty($row['categories']);
|
||||||
|
self::assertArrayHasKey('code', $row['categories'][0]);
|
||||||
|
self::assertSame('DISTRIBUTEUR', $row['categories'][0]['code']);
|
||||||
|
|
||||||
|
// Colonne « Site(s) » : sites agreges des adresses, avec name + color.
|
||||||
|
self::assertArrayHasKey('sites', $row);
|
||||||
|
self::assertNotEmpty($row['sites']);
|
||||||
|
self::assertArrayHasKey('name', $row['sites'][0]);
|
||||||
|
self::assertArrayHasKey('color', $row['sites'][0]);
|
||||||
|
self::assertSame($site->getName(), $row['sites'][0]['name']);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* ERP-62 (drawer) : filtre Catégories multi (?categoryCode[]=A&categoryCode[]=B)
|
||||||
|
* — union des clients possedant l'un OU l'autre code.
|
||||||
|
*/
|
||||||
|
public function testListFilterByMultipleCategoryCodes(): void
|
||||||
|
{
|
||||||
|
$client = $this->createAdminClient();
|
||||||
|
$this->seedClient('Filtre Distrib Co', false, 'DISTRIBUTEUR');
|
||||||
|
$this->seedClient('Filtre Courtier Co', false, 'COURTIER');
|
||||||
|
$this->seedClient('Filtre Secteur Co', false, 'SECTEUR');
|
||||||
|
|
||||||
|
$names = $this->companyNames($client, '/api/clients?pagination=false&categoryCode[]=DISTRIBUTEUR&categoryCode[]=COURTIER');
|
||||||
|
|
||||||
|
self::assertContains('FILTRE DISTRIB CO', $names);
|
||||||
|
self::assertContains('FILTRE COURTIER CO', $names);
|
||||||
|
self::assertNotContains('FILTRE SECTEUR CO', $names);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* ERP-62 (drawer) : filtre Sites (?siteId[]=X) — clients ayant >= 1 adresse
|
||||||
|
* rattachee au site donne.
|
||||||
|
*/
|
||||||
|
public function testListFilterBySite(): void
|
||||||
|
{
|
||||||
|
$client = $this->createAdminClient();
|
||||||
|
$em = $this->getEm();
|
||||||
|
|
||||||
|
$sites = $em->getRepository(Site::class)->findBy([], null, 2);
|
||||||
|
self::assertCount(2, $sites, 'Deux sites seedes requis pour ce test.');
|
||||||
|
[$siteA, $siteB] = $sites;
|
||||||
|
|
||||||
|
$onSiteA = $this->seedClient('Client Sur Site A');
|
||||||
|
$this->attachAddressWithSite($onSiteA, $siteA);
|
||||||
|
|
||||||
|
$onSiteB = $this->seedClient('Client Sur Site B');
|
||||||
|
$this->attachAddressWithSite($onSiteB, $siteB);
|
||||||
|
|
||||||
|
$names = $this->companyNames($client, '/api/clients?pagination=false&siteId[]='.$siteA->getId());
|
||||||
|
|
||||||
|
self::assertContains('CLIENT SUR SITE A', $names);
|
||||||
|
self::assertNotContains('CLIENT SUR SITE B', $names);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* ERP-62 (drawer) : statut « Archivés » (?archivedOnly=true) — uniquement les
|
||||||
|
* archives, contrairement a includeArchived qui ajoute les archives aux actifs.
|
||||||
|
*/
|
||||||
|
public function testListArchivedOnlyReturnsOnlyArchived(): void
|
||||||
|
{
|
||||||
|
$client = $this->createAdminClient();
|
||||||
|
$this->seedClient('Actif Visible Co');
|
||||||
|
$this->seedClient('Archive Visible Co', true);
|
||||||
|
|
||||||
|
$names = $this->companyNames($client, '/api/clients?pagination=false&archivedOnly=true');
|
||||||
|
|
||||||
|
self::assertContains('ARCHIVE VISIBLE CO', $names);
|
||||||
|
self::assertNotContains('ACTIF VISIBLE CO', $names);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Rattache une adresse minimale portant un site au client (les sites vivent
|
||||||
|
* sur les adresses, RG-1.10).
|
||||||
|
*/
|
||||||
|
private function attachAddressWithSite(ClientEntity $client, Site $site): void
|
||||||
|
{
|
||||||
|
$em = $this->getEm();
|
||||||
|
$address = new ClientAddress();
|
||||||
|
$address->setClient($client);
|
||||||
|
$address->setPostalCode('86100');
|
||||||
|
$address->setCity('Châtellerault');
|
||||||
|
$address->setStreet('1 rue du Test');
|
||||||
|
$address->addSite($site);
|
||||||
|
$em->persist($address);
|
||||||
|
$em->flush();
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Helper : recupere les companyName d'une collection /api/clients.
|
||||||
|
*
|
||||||
|
* @return list<string>
|
||||||
|
*/
|
||||||
|
private function companyNames(Client $client, string $url): array
|
||||||
|
{
|
||||||
|
$members = $client->request('GET', $url, [
|
||||||
|
'headers' => ['Accept' => self::LD],
|
||||||
|
])->toArray()['member'];
|
||||||
|
|
||||||
|
return array_map(static fn (array $c): string => $c['companyName'], $members);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,281 @@
|
|||||||
|
<?php
|
||||||
|
|
||||||
|
declare(strict_types=1);
|
||||||
|
|
||||||
|
namespace App\Tests\Module\Commercial\Api;
|
||||||
|
|
||||||
|
use App\Module\Commercial\Domain\Entity\Client as ClientEntity;
|
||||||
|
use App\Module\Commercial\Domain\Entity\ClientAddress;
|
||||||
|
use App\Module\Commercial\Domain\Entity\ClientContact;
|
||||||
|
use App\Module\Commercial\Domain\Entity\ClientRib;
|
||||||
|
use App\Module\Sites\Domain\Entity\Site;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Tests anti-regression du CONTRAT DE SERIALISATION du repertoire clients (M1).
|
||||||
|
*
|
||||||
|
* Captures reelles du 02/06/2026 (cf. docs/specs/M2-suppliers/spec-back.md
|
||||||
|
* § 4.0.ter) ayant revele 4 bugs silencieux du contrat (aucune erreur levee) :
|
||||||
|
* - #81 : booleens d'adresse (isProspect/isDelivery/isBilling) absents du JSON
|
||||||
|
* (Groups sur la propriete `isX`, getter `isX()` derivant l'attribut `x`).
|
||||||
|
* - #80 : fuite RIB (IBAN/BIC) vers un user sans accounting.view.
|
||||||
|
* - #82 : code/libelle de Category et Site non embarques (stub IRI nu).
|
||||||
|
* - enveloppe AP4 : member/totalItems/view sans prefixe `hydra:`, archives exclus.
|
||||||
|
*
|
||||||
|
* REGLE D'OR : ces tests assertent sur le CORPS JSON reel, jamais sur les
|
||||||
|
* annotations. Toute regression de groupe de serialisation casse ici.
|
||||||
|
*
|
||||||
|
* Limite connue (dependance module Sites) : l'entite Site ne porte PAS de champ
|
||||||
|
* `code` (ni SiteInterface) — son libelle est `name`. Les « codes 86/17/82 » de
|
||||||
|
* la spec M2 correspondent en realite au prefixe du code postal des 3 sites
|
||||||
|
* fixtures (86100/17400/82400). On asserte donc le libelle `name` du site
|
||||||
|
* embarque ; l'ajout d'un `Site.code` reste un ticket cote module Sites.
|
||||||
|
*
|
||||||
|
* @internal
|
||||||
|
*/
|
||||||
|
final class ClientSerializationContractTest extends AbstractCommercialApiTestCase
|
||||||
|
{
|
||||||
|
private const string LD = 'application/ld+json';
|
||||||
|
private const string VALID_IBAN = 'FR1420041010050500013M02606';
|
||||||
|
private const string VALID_BIC = 'BNPAFRPPXXX';
|
||||||
|
|
||||||
|
// === #81 — Booleens d'adresse presents dans le JSON ===
|
||||||
|
|
||||||
|
public function testAddressBooleansArePresentInDetail(): void
|
||||||
|
{
|
||||||
|
$this->skipIfSitesModuleDisabled();
|
||||||
|
|
||||||
|
$seed = $this->seedCompleteClient('Bool Addr Co');
|
||||||
|
$id = $seed->getId();
|
||||||
|
|
||||||
|
$http = $this->createAdminClient();
|
||||||
|
$data = $http->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
self::assertArrayHasKey('addresses', $data);
|
||||||
|
self::assertNotEmpty($data['addresses']);
|
||||||
|
$address = $data['addresses'][0];
|
||||||
|
|
||||||
|
// Le bug droppait TOTALEMENT ces cles. Apres correctif (Groups +
|
||||||
|
// SerializedName sur le getter), elles sont presentes ET typees bool.
|
||||||
|
self::assertArrayHasKey('isProspect', $address);
|
||||||
|
self::assertArrayHasKey('isDelivery', $address);
|
||||||
|
self::assertArrayHasKey('isBilling', $address);
|
||||||
|
|
||||||
|
// L'adresse seedee est livraison + facturation (prospect exclusif, RG-1.06).
|
||||||
|
// Prouve qu'un booleen `true` est bien serialise (le bug masquait meme les true).
|
||||||
|
self::assertFalse($address['isProspect']);
|
||||||
|
self::assertTrue($address['isDelivery']);
|
||||||
|
self::assertTrue($address['isBilling']);
|
||||||
|
}
|
||||||
|
|
||||||
|
// === #80 — Gating des RIB par accounting.view ===
|
||||||
|
|
||||||
|
public function testRibsPresentForAdminWithAccountingView(): void
|
||||||
|
{
|
||||||
|
$this->skipIfSitesModuleDisabled();
|
||||||
|
|
||||||
|
$seed = $this->seedCompleteClient('Rib Admin Co');
|
||||||
|
$id = $seed->getId();
|
||||||
|
|
||||||
|
$http = $this->createAdminClient();
|
||||||
|
$data = $http->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
// Admin bypass RBAC -> accounting.view -> RIB embarques (label/bic/iban).
|
||||||
|
self::assertArrayHasKey('ribs', $data);
|
||||||
|
self::assertNotEmpty($data['ribs']);
|
||||||
|
self::assertSame('Compte principal', $data['ribs'][0]['label']);
|
||||||
|
self::assertSame(self::VALID_IBAN, $data['ribs'][0]['iban']);
|
||||||
|
self::assertSame(self::VALID_BIC, $data['ribs'][0]['bic']);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testRibsAbsentForUserWithoutAccountingView(): void
|
||||||
|
{
|
||||||
|
$this->skipIfSitesModuleDisabled();
|
||||||
|
|
||||||
|
$seed = $this->seedCompleteClient('Rib Commerciale Co');
|
||||||
|
$id = $seed->getId();
|
||||||
|
|
||||||
|
// Commerciale : commercial.clients.view SANS accounting.view.
|
||||||
|
$creds = $this->createUserWithPermission('commercial.clients.view');
|
||||||
|
$http = $this->authenticatedClient($creds['username'], $creds['password']);
|
||||||
|
|
||||||
|
$data = $http->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
// La cle `ribs` est ABSENTE (pas null) : le groupe client:read:accounting
|
||||||
|
// n'est pas ajoute au contexte -> getRibs() jamais serialise. Fin de la
|
||||||
|
// fuite IBAN/BIC.
|
||||||
|
self::assertArrayNotHasKey('ribs', $data);
|
||||||
|
}
|
||||||
|
|
||||||
|
// === #80.bis — Gating par OMISSION des scalaires comptables ===
|
||||||
|
|
||||||
|
public function testAccountingScalarsGatedByOmission(): void
|
||||||
|
{
|
||||||
|
$this->skipIfSitesModuleDisabled();
|
||||||
|
|
||||||
|
$seed = $this->seedCompleteClient('Compta Gating Co');
|
||||||
|
$id = $seed->getId();
|
||||||
|
|
||||||
|
// Admin : scalaires comptables presents.
|
||||||
|
$admin = $this->createAdminClient();
|
||||||
|
$adminData = $admin->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
self::assertArrayHasKey('siren', $adminData);
|
||||||
|
self::assertSame('123456789', $adminData['siren']);
|
||||||
|
self::assertArrayHasKey('accountNumber', $adminData);
|
||||||
|
|
||||||
|
// Commerciale : scalaires comptables ABSENTS (omission, pas null).
|
||||||
|
$creds = $this->createUserWithPermission('commercial.clients.view');
|
||||||
|
$http = $this->authenticatedClient($creds['username'], $creds['password']);
|
||||||
|
$data = $http->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
self::assertArrayNotHasKey('siren', $data);
|
||||||
|
self::assertArrayNotHasKey('accountNumber', $data);
|
||||||
|
self::assertArrayNotHasKey('nTva', $data);
|
||||||
|
self::assertArrayNotHasKey('ribs', $data);
|
||||||
|
}
|
||||||
|
|
||||||
|
// === #82 — Embed code/libelle des Category et Site ===
|
||||||
|
|
||||||
|
public function testCategoriesEmbedCodeAndLabel(): void
|
||||||
|
{
|
||||||
|
$this->skipIfSitesModuleDisabled();
|
||||||
|
|
||||||
|
$seed = $this->seedCompleteClient('Embed Cat Co');
|
||||||
|
$id = $seed->getId();
|
||||||
|
|
||||||
|
$http = $this->createAdminClient();
|
||||||
|
$data = $http->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
self::assertNotEmpty($data['categories']);
|
||||||
|
$category = $data['categories'][0];
|
||||||
|
// Avant correctif : seuls @id/@type/createdAt/updatedAt (category:read
|
||||||
|
// absent du contexte). Apres : code + name (libelle) embarques.
|
||||||
|
self::assertArrayHasKey('code', $category);
|
||||||
|
self::assertArrayHasKey('name', $category);
|
||||||
|
self::assertNotSame('', $category['code']);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testAddressSitesEmbedLabel(): void
|
||||||
|
{
|
||||||
|
$this->skipIfSitesModuleDisabled();
|
||||||
|
|
||||||
|
$seed = $this->seedCompleteClient('Embed Site Co');
|
||||||
|
$id = $seed->getId();
|
||||||
|
|
||||||
|
$http = $this->createAdminClient();
|
||||||
|
$data = $http->request('GET', '/api/clients/'.$id, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
$address = $data['addresses'][0];
|
||||||
|
self::assertArrayHasKey('sites', $address);
|
||||||
|
self::assertNotEmpty($address['sites']);
|
||||||
|
// Site embarque : libelle `name` present (avant : stub @id/@type nu).
|
||||||
|
// NB : Site n'a pas de champ `code` (cf. note de classe) -> on asserte name.
|
||||||
|
self::assertArrayHasKey('name', $address['sites'][0]);
|
||||||
|
self::assertNotSame('', $address['sites'][0]['name']);
|
||||||
|
|
||||||
|
// L'adresse seedee est multi-sites : preuve que l'embed parcourt la collection.
|
||||||
|
self::assertGreaterThanOrEqual(2, count($address['sites']));
|
||||||
|
|
||||||
|
// Categories d'adresse : code embarque (category:read dans le contexte).
|
||||||
|
self::assertArrayHasKey('categories', $address);
|
||||||
|
self::assertNotEmpty($address['categories']);
|
||||||
|
self::assertArrayHasKey('code', $address['categories'][0]);
|
||||||
|
}
|
||||||
|
|
||||||
|
// === Enveloppe AP4 (sans prefixe hydra:) + exclusion des archives ===
|
||||||
|
|
||||||
|
public function testCollectionEnvelopeShapeAndArchivedExcluded(): void
|
||||||
|
{
|
||||||
|
$http = $this->createAdminClient();
|
||||||
|
$prefix = 'EnvCheck'.substr(bin2hex(random_bytes(3)), 0, 6);
|
||||||
|
|
||||||
|
$this->seedClient($prefix.' Active');
|
||||||
|
$this->seedClient($prefix.' Archived', true);
|
||||||
|
|
||||||
|
// Liste par defaut filtree sur le prefixe : enveloppe member/totalItems
|
||||||
|
// sans prefixe hydra:, archive EXCLU du totalItems (RG-1.24).
|
||||||
|
$default = $http->request('GET', '/api/clients?search='.$prefix, ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
|
||||||
|
self::assertArrayHasKey('member', $default);
|
||||||
|
self::assertArrayHasKey('totalItems', $default);
|
||||||
|
self::assertArrayNotHasKey('hydra:member', $default);
|
||||||
|
self::assertArrayNotHasKey('hydra:totalItems', $default);
|
||||||
|
self::assertSame(1, $default['totalItems'], 'Archive exclu du totalItems par defaut.');
|
||||||
|
|
||||||
|
// includeArchived : l'archive reintegre le total.
|
||||||
|
$all = $http->request('GET', '/api/clients?search='.$prefix.'&includeArchived=true', ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
self::assertSame(2, $all['totalItems']);
|
||||||
|
|
||||||
|
// `view` (PartialCollectionView) sans prefixe hydra: : force le multi-page
|
||||||
|
// via itemsPerPage=1 sur les 2 resultats archives inclus.
|
||||||
|
$paged = $http->request('GET', '/api/clients?search='.$prefix.'&includeArchived=true&itemsPerPage=1', ['headers' => ['Accept' => self::LD]])->toArray();
|
||||||
|
self::assertArrayHasKey('view', $paged);
|
||||||
|
self::assertArrayNotHasKey('hydra:view', $paged);
|
||||||
|
}
|
||||||
|
|
||||||
|
// === Helper ===
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Seede un client COMPLET (sans passer par l'API, validations applicatives
|
||||||
|
* non rejouees mais CHECK BDD respectes) : bloc comptable non nul, >= 1 RIB,
|
||||||
|
* >= 1 adresse multi-sites avec categories, >= 1 contact, >= 1 categorie.
|
||||||
|
*
|
||||||
|
* L'adresse est livraison + facturation (prospect exclusif, RG-1.06 ; email
|
||||||
|
* de facturation present, RG-1.11) afin de poser des booleens `true`
|
||||||
|
* serialisables tout en respectant les CHECK Postgres.
|
||||||
|
*/
|
||||||
|
private function seedCompleteClient(string $companyName): ClientEntity
|
||||||
|
{
|
||||||
|
$em = $this->getEm();
|
||||||
|
|
||||||
|
// Nom unique parmi les actifs (index partiel uq_client_company_name_active).
|
||||||
|
$suffix = substr(bin2hex(random_bytes(3)), 0, 6);
|
||||||
|
|
||||||
|
$client = new ClientEntity();
|
||||||
|
$client->setCompanyName(mb_strtoupper($companyName.' '.$suffix, 'UTF-8'));
|
||||||
|
$client->setLastName('Complet');
|
||||||
|
$client->setPhonePrimary('0102030405');
|
||||||
|
$client->setEmail('complet'.$suffix.'@seed.test');
|
||||||
|
$client->addCategory($this->createCategory('SECTEUR'));
|
||||||
|
// Bloc comptable non nul (gating par omission cote Commerciale).
|
||||||
|
$client->setSiren('123456789');
|
||||||
|
$client->setAccountNumber('C0001');
|
||||||
|
$client->setNTva('FR00123456789');
|
||||||
|
$em->persist($client);
|
||||||
|
|
||||||
|
// >= 2 sites fixtures pour une adresse multi-sites (RG-1.10).
|
||||||
|
$sites = $em->getRepository(Site::class)->findBy([], null, 2);
|
||||||
|
self::assertGreaterThanOrEqual(2, count($sites), 'Au moins 2 sites fixtures requis (SitesFixtures).');
|
||||||
|
|
||||||
|
$address = new ClientAddress();
|
||||||
|
$address->setClient($client);
|
||||||
|
$address->setIsProspect(false);
|
||||||
|
$address->setIsDelivery(true);
|
||||||
|
$address->setIsBilling(true);
|
||||||
|
$address->setBillingEmail('billing'.$suffix.'@seed.test');
|
||||||
|
$address->setPostalCode('86000');
|
||||||
|
$address->setCity('Poitiers');
|
||||||
|
$address->setStreet('12 rue des Acacias');
|
||||||
|
foreach ($sites as $site) {
|
||||||
|
$address->addSite($site);
|
||||||
|
}
|
||||||
|
$address->addCategory($this->createCategory('SECTEUR'));
|
||||||
|
$em->persist($address);
|
||||||
|
|
||||||
|
$rib = new ClientRib();
|
||||||
|
$rib->setClient($client);
|
||||||
|
$rib->setLabel('Compte principal');
|
||||||
|
$rib->setBic(self::VALID_BIC);
|
||||||
|
$rib->setIban(self::VALID_IBAN);
|
||||||
|
$em->persist($rib);
|
||||||
|
|
||||||
|
$contact = new ClientContact();
|
||||||
|
$contact->setClient($client);
|
||||||
|
$contact->setFirstName('Marie');
|
||||||
|
$contact->setLastName('Martin');
|
||||||
|
$em->persist($contact);
|
||||||
|
|
||||||
|
$em->flush();
|
||||||
|
|
||||||
|
return $client;
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user