Matthieu
c528067c79
Auto Tag Develop / tag (push) Successful in 11s
Certains clients MCP sérialisent tous les arguments JSON-RPC en string (ex: "22" au lieu de 22). Le SDK valide les arguments contre le schéma JSON AVANT de les caster (CallToolHandler), donc un schéma integer strict rejetait "22" en 422 alors que ReferenceHandler::castArgumentType sait le coercer ensuite. CoercingSchemaGenerator enveloppe le SchemaGenerator du SDK et ajoute "string" aux types scalaires integer/number/boolean (et aux items de tableaux), de sorte que opis accepte la valeur stringifiée ; le type PHP réel du paramètre pilote toujours la coercition. Branché sur le builder MCP via McpSchemaGeneratorPass (enregistrée dans Kernel::build). Corrige le rejet 422 sur groupId/effortId/priorityId/statusId/etc. lors de l'appel des tools depuis Claude.
76 lines
2.6 KiB
PHP
76 lines
2.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Unit\Mcp;
|
|
|
|
use App\Mcp\Schema\CoercingSchemaGenerator;
|
|
use App\Mcp\Tool\Task\CreateTaskTool;
|
|
use App\Mcp\Tool\Task\ListTasksTool;
|
|
use PHPUnit\Framework\TestCase;
|
|
use ReflectionMethod;
|
|
|
|
/**
|
|
* @internal
|
|
*/
|
|
class CoercingSchemaGeneratorTest extends TestCase
|
|
{
|
|
private CoercingSchemaGenerator $generator;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
$this->generator = new CoercingSchemaGenerator();
|
|
}
|
|
|
|
public function testNullableIntegerScalarAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(ListTasksTool::class, '__invoke'));
|
|
|
|
// ?int $projectId -> ["null","integer"] relaxed with "string".
|
|
self::assertSame(['null', 'integer', 'string'], $schema['properties']['projectId']['type']);
|
|
}
|
|
|
|
public function testRequiredIntegerScalarAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(ListTasksTool::class, '__invoke'));
|
|
|
|
// int $limit = 100 -> "integer" relaxed to ["integer","string"].
|
|
self::assertSame(['integer', 'string'], $schema['properties']['limit']['type']);
|
|
}
|
|
|
|
public function testBooleanScalarAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// ?bool $syncToCalendar -> ["boolean","null"] relaxed with "string".
|
|
$type = $schema['properties']['syncToCalendar']['type'];
|
|
self::assertContains('boolean', $type);
|
|
self::assertContains('string', $type);
|
|
self::assertContains('null', $type);
|
|
}
|
|
|
|
public function testArrayItemTypeAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// int[] $tagIds -> items {type: integer} relaxed to {type: [integer, string]}.
|
|
self::assertSame(['integer', 'string'], $schema['properties']['tagIds']['items']['type']);
|
|
}
|
|
|
|
public function testStringScalarIsLeftUntouched(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// string $title stays a plain string (no spurious relaxation).
|
|
self::assertSame('string', $schema['properties']['title']['type']);
|
|
}
|
|
|
|
public function testArrayContainerTypeIsNotRelaxed(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// The array container itself must not gain "string".
|
|
self::assertSame(['array', 'null'], $schema['properties']['tagIds']['type']);
|
|
}
|
|
}
|