8313c759c6
Auto Tag Develop / tag (push) Successful in 9s
## Migration modular monolith DDD — Lesstime (0.1 → 3.3) Cette MR regroupe l'intégralité de la refonte en monolithe modulaire (strangler progressif, additif). Elle remplace les MR stackées de Phase 1 (#12–#16), désormais incluses ici. **Ne pas merger avant validation fonctionnelle** : branche destinée à être testée telle quelle. ### Périmètre — 9 modules sous `src/Module/` | Phase | Module | Contenu | |------|--------|---------| | 0.1 | (socle) | infrastructure modulaire, `ModuleInterface`, mapping Doctrine par module | | 0.2 | (socle front) | auto-détection des layers Nuxt sous `frontend/modules/*` | | 1.1 | **Core** | Identité (User/Auth), Notifications, Notifier | | 1.2 | Core | RBAC fin (permissions `module.resource.action`, sidebar gated) | | 1.3 | Core | Audit log (`#[Auditable]`, listener, provider DBAL) | | 2.1 | **TimeTracking** | TimeEntry + MCP + export | | 2.2 | **ProjectManagement** | cœur métier Projets/Tâches + 38 MCP tools | | 2.3 | **Absence** | demandes, soldes, policies, justificatifs | | 2.4 | **Directory** | Clients (migrés) + **Prospects** (nouveau, conversion → Client) | | 2.5 | **Mail** | intégration IMAP OVH + liens tâches | | 2.6 | **Integration** | Gitea / BookStack / Zimbra / Share | | 3.1 | **Reporting** | rapports transverses (DBAL read-only, 0 import inter-module) | | 3.2 | **ClientPortal** | portail client (ROLE_CLIENT cloisonné, tickets, notifications) | | 3.3 | (finition) | nettoyage legacy — `src/Entity` vide, app 100% modulaire | ### Architecture - Découplage inter-modules par **contrats** (`UserInterface`, `ProjectInterface`, `TaskInterface`, `TaskTagInterface`, `ClientInterface`, `ClientTicketInterface`, `LeaveProfileInterface`) + `resolve_target_entities` 100% modulaire (aucune cible legacy). - Repositories : interface `Domain/Repository` + implémentation `Infrastructure/Doctrine`, bindées. - Reporting en DBAL read-only pur (aucun import d'entité d'un autre module). - Chaque migration de module : déplacement à comportement préservé (API publique et noms d'outils MCP inchangés), migrations **additives** uniquement (zéro destructif). ### Sécurité - ROLE_CLIENT cloisonné : un utilisateur client n'accède qu'à `/portal` et à ses propres tickets (filtrés par `allowedProjects`), interdit sur toute l'API interne. - Correctif : interdiction pour un client de créer un lien vers le partage SMB (upload uniquement). ### QA non-régression (branche reconstruite from scratch) - Migrations from scratch + fixtures : OK. - Compilation dev + prod : OK. - **180 tests PHPUnit verts**, php-cs-fixer clean, ~96 routes, **66 outils MCP** tous sous `App\Module\*`. - Smoke test runtime multi-rôles (admin / ROLE_USER / ROLE_CLIENT) : 44 vérifications HTTP, **0 écart**, cloisonnement client étanche. - Build Nuxt OK, 9 layers, 0 import legacy résiduel. ### Points à arbitrer (hors périmètre de cette migration) - Durcissement MCP/IDOR pré-existant (`userId` explicite sans scoping sur certains tools TimeTracking/Absence/TaskDocument) — ticket dédié recommandé. - Validation fonctionnelle de **Prospect** et **ClientPortal** (conçus depuis les specs disque). - **Harmonisation visuelle Malio finale** (3.3) — finition esthétique inter-modules laissée au PO. --- ## ⚠️ Déploiement / migration des données — à ne pas oublier ### 1. Resynchroniser les séquences PostgreSQL après tout import/restore de dump Si la prod (ou tout environnement) est **montée depuis un dump** (`pg_restore` / `COPY`), les lignes sont chargées avec leurs `id` explicites **sans avancer les séquences** → au premier `INSERT` : `duplicate key value violates unique constraint "..._pkey"` (constaté en local sur `notification`, `task`, `time_entry`…). À lancer **juste après chaque restore/import** : ```sql DO $$ DECLARE r RECORD; maxid BIGINT; seq TEXT; BEGIN FOR r IN SELECT table_name, column_name FROM information_schema.columns WHERE table_schema='public' LOOP seq := pg_get_serial_sequence(quote_ident(r.table_name), r.column_name); IF seq IS NOT NULL THEN EXECUTE format('SELECT COALESCE(MAX(%I),0) FROM %I', r.column_name, r.table_name) INTO maxid; PERFORM setval(seq, GREATEST(maxid,1), maxid > 0); END IF; END LOOP; END $$; ``` > Ne concerne **pas** une prod qui tourne déjà (séquences avancées organiquement) — uniquement le cas restore/import. Idempotent, sans risque. ### 2. Fix dénormalisation des collections typées-contrat (code, inclus dans la branche) Les relations **to-many** typées par une interface `Shared\Domain\Contract\*` (`TimeEntry::tags` → `TaskTagInterface`, `Task::collaborators` → `UserInterface`) étaient **indénormalisables par API Platform** (mono-valué OK via IRI, collection KO) → **tout POST/PATCH portant une telle collection renvoyait 400/500**. Corrigé par un dénormaliseur générique `ContractRelationDenormalizer` (réutilise `resolve_target_entities`, zéro couplage par-entité) + test fonctionnel de non-régression. --------- Co-authored-by: Matthieu <contact@malio.fr> Reviewed-on: #17
218 lines
7.0 KiB
TypeScript
218 lines
7.0 KiB
TypeScript
import type { FetchOptions } from 'ofetch'
|
|
import { $fetch, FetchError } from 'ofetch'
|
|
import { useAuthStore } from '~/shared/stores/auth'
|
|
|
|
export type AnyObject = Record<string, unknown>
|
|
|
|
export type BlobResponse = {
|
|
data: Blob
|
|
headers: Headers
|
|
}
|
|
|
|
export type ApiClient = {
|
|
get<T>(url: string, query?: AnyObject, options?: ApiFetchOptions<'json'>): Promise<T>
|
|
getBlob(url: string, query?: AnyObject, options?: ApiFetchOptions<'blob'>): Promise<BlobResponse>
|
|
post<T>(url: string, body?: AnyObject, options?: ApiFetchOptions<'json'>): Promise<T>
|
|
put<T>(url: string, body?: AnyObject, options?: ApiFetchOptions<'json'>): Promise<T>
|
|
patch<T>(url: string, body?: AnyObject, options?: ApiFetchOptions<'json'>): Promise<T>
|
|
delete<T>(url: string, query?: AnyObject, options?: ApiFetchOptions<'json'>): Promise<T>
|
|
}
|
|
|
|
export type ApiFetchOptions<ResponseType extends 'json' | 'blob'> =
|
|
FetchOptions<ResponseType> & {
|
|
toast?: boolean
|
|
toastOn401?: boolean
|
|
toastTitle?: string
|
|
toastErrorMessage?: string
|
|
toastSuccessMessage?: string
|
|
toastErrorKey?: string
|
|
toastSuccessKey?: string
|
|
}
|
|
|
|
let isHandlingUnauthorized = false
|
|
|
|
export function useApi(): ApiClient {
|
|
const config = useRuntimeConfig()
|
|
const baseURL = config.public.apiBase || '/api'
|
|
const toast = useToast()
|
|
const auth = useAuthStore()
|
|
const nuxtApp = useNuxtApp()
|
|
const i18n = nuxtApp.$i18n as
|
|
| {
|
|
t: (key: string) => string
|
|
te?: (key: string) => boolean
|
|
}
|
|
| undefined
|
|
const t = (key: string) => (i18n?.t ? String(i18n.t(key)) : key)
|
|
const te = (key: string) => (i18n?.te ? i18n.te(key) : false)
|
|
|
|
function extractErrorMessage(error: unknown, responseData?: unknown): string {
|
|
const data = responseData ?? (error as FetchError)?.data
|
|
|
|
if (typeof data === 'string') {
|
|
return data
|
|
}
|
|
|
|
if (data && typeof data === 'object') {
|
|
const record = data as Record<string, unknown>
|
|
return (
|
|
(record['hydra:description'] as string) ||
|
|
(record.detail as string) ||
|
|
(record.message as string) ||
|
|
(record.error as string) ||
|
|
(record.title as string) ||
|
|
(record['hydra:title'] as string) ||
|
|
''
|
|
)
|
|
}
|
|
|
|
return (error as FetchError)?.message ?? 'Erreur inconnue.'
|
|
}
|
|
|
|
const methodErrorKeys: Record<string, string> = {
|
|
GET: 'errors.http.get',
|
|
POST: 'errors.http.post',
|
|
PUT: 'errors.http.put',
|
|
PATCH: 'errors.http.patch',
|
|
DELETE: 'errors.http.delete'
|
|
}
|
|
|
|
const client = $fetch.create({
|
|
baseURL,
|
|
retry: 0,
|
|
credentials: 'include',
|
|
onResponse({ options, response }) {
|
|
const apiOptions = options as ApiFetchOptions<'json'>
|
|
if (apiOptions?.toast === false) {
|
|
return
|
|
}
|
|
|
|
if (response?.status && response.status >= 400) {
|
|
return
|
|
}
|
|
|
|
const successKey = apiOptions?.toastSuccessKey
|
|
const successMessage =
|
|
apiOptions?.toastSuccessMessage ||
|
|
(successKey ? (te(successKey) ? t(successKey) : successKey) : '')
|
|
|
|
if (successMessage) {
|
|
toast.success({
|
|
title: 'Succès',
|
|
message: successMessage
|
|
})
|
|
}
|
|
},
|
|
async onResponseError({ response, error, options }) {
|
|
const apiOptions = options as ApiFetchOptions<'json'>
|
|
if (response?.status === 401) {
|
|
const requestUrl = typeof options?.url === 'string' ? options.url : ''
|
|
const isLoginCheck = requestUrl.includes('/login_check')
|
|
const isLogout = requestUrl.includes('/logout')
|
|
const shouldToast401 = apiOptions?.toastOn401 === true && apiOptions?.toast !== false
|
|
|
|
if (shouldToast401) {
|
|
const errorKey = apiOptions?.toastErrorKey
|
|
const errorMessage =
|
|
errorKey ? (te(errorKey) ? t(errorKey) : errorKey) : ''
|
|
const extractedMessage = extractErrorMessage(error, response?._data)
|
|
const message =
|
|
apiOptions?.toastErrorMessage ||
|
|
errorMessage ||
|
|
extractedMessage ||
|
|
'Une erreur est survenue.'
|
|
|
|
toast.error({
|
|
title: apiOptions?.toastTitle ?? 'Erreur',
|
|
message
|
|
})
|
|
}
|
|
|
|
if (!isLoginCheck && !isLogout) {
|
|
if (!isHandlingUnauthorized) {
|
|
isHandlingUnauthorized = true
|
|
auth.clearSession()
|
|
const route = useRoute()
|
|
if (route.path !== '/login') {
|
|
await navigateTo('/login')
|
|
}
|
|
isHandlingUnauthorized = false
|
|
}
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
if (apiOptions?.toast === false) {
|
|
return
|
|
}
|
|
|
|
const method =
|
|
typeof options?.method === 'string' ? options.method.toUpperCase() : 'GET'
|
|
const defaultKey = methodErrorKeys[method]
|
|
const defaultMessage =
|
|
defaultKey && te(defaultKey) ? t(defaultKey) : ''
|
|
const errorKey = apiOptions?.toastErrorKey
|
|
const errorMessage =
|
|
errorKey ? (te(errorKey) ? t(errorKey) : errorKey) : ''
|
|
const extractedMessage = extractErrorMessage(error, response?._data)
|
|
const message =
|
|
apiOptions?.toastErrorMessage ||
|
|
errorMessage ||
|
|
defaultMessage ||
|
|
extractedMessage ||
|
|
'Une erreur est survenue.'
|
|
|
|
toast.error({
|
|
title: apiOptions?.toastTitle ?? 'Erreur',
|
|
message
|
|
})
|
|
}
|
|
})
|
|
|
|
function request<T>(
|
|
method: 'GET' | 'POST' | 'PUT' | 'PATCH' | 'DELETE',
|
|
url: string,
|
|
options: ApiFetchOptions<'json'> = {}
|
|
) {
|
|
const needsJsonBody = method === 'POST' || method === 'PUT'
|
|
const needsMergePatch = method === 'PATCH'
|
|
const isFormData = typeof FormData !== 'undefined' && options.body instanceof FormData
|
|
|
|
const headers = new Headers(options.headers as HeadersInit | undefined)
|
|
|
|
if (!isFormData) {
|
|
if (needsMergePatch && !headers.has('Content-Type')) {
|
|
headers.set('Content-Type', 'application/merge-patch+json')
|
|
} else if (needsJsonBody && !headers.has('Content-Type')) {
|
|
headers.set('Content-Type', 'application/json')
|
|
}
|
|
}
|
|
|
|
return client<T>(url, { ...options, method, headers })
|
|
}
|
|
|
|
return {
|
|
get<T>(url: string, query: AnyObject = {}, options: ApiFetchOptions<'json'> = {}) {
|
|
return request<T>('GET', url, { ...options, query })
|
|
},
|
|
getBlob(url: string, query: AnyObject = {}, options: ApiFetchOptions<'blob'> = {}) {
|
|
return client
|
|
.raw(url, { ...options, method: 'GET', query, responseType: 'blob' })
|
|
.then((res) => ({ data: res._data as Blob, headers: res.headers }))
|
|
},
|
|
post<T>(url: string, body: AnyObject = {}, options: ApiFetchOptions<'json'> = {}) {
|
|
return request<T>('POST', url, { ...options, body })
|
|
},
|
|
put<T>(url: string, body: AnyObject = {}, options: ApiFetchOptions<'json'> = {}) {
|
|
return request<T>('PUT', url, { ...options, body })
|
|
},
|
|
patch<T>(url: string, body: AnyObject = {}, options: ApiFetchOptions<'json'> = {}) {
|
|
return request<T>('PATCH', url, { ...options, body })
|
|
},
|
|
delete<T>(url: string, query: AnyObject = {}, options: ApiFetchOptions<'json'> = {}) {
|
|
return request<T>('DELETE', url, { ...options, query })
|
|
}
|
|
}
|
|
}
|