dc33cf4135
Polish across the form input components, plus two new features and a few
standalone fixes.
Fixes
-----
* Reserve hint/error/success paragraph space (min-h-[1rem]) in 15
components so a single error message no longer shifts neighboring grid
cells: InputText, Email, Password, Phone, Amount, Number, Upload,
Autocomplete, RichText, TextArea, Select, SelectCheckbox, Time,
TimePicker, CalendarField, Checkbox.
* InputPhone: the '+' add button now follows the icon-state cascade
(muted / primary on focus / black when filled / danger / success) like
the other field icons instead of being permanently primary.
* Select and SelectCheckbox: chevron color follows the field state
(muted by default, primary when open, black when an option is
selected, danger / success on error / success) instead of always being
text-current.
* InputTextArea: single-root component (was multi-root). The message
wrapper used to occupy its own grid cell, breaking row-span layouts.
Now flex flex-col, with the textarea area filling the available height
via flex-1 and the message inside the same root.
* Disabled labels use text-m-muted (border-gray) instead of text-black/60
(dark) across InputText, Email, Password, Amount, Phone, Upload,
Autocomplete, TextArea, RichText. Also removes an unreachable
peer-[&:not(:placeholder-shown):not(:focus)]:text-black/60 rule that
twMerge was silently overriding with text-black.
* InputAutocomplete: eliminates four sources of visual jitter when
focusing / opening a field that already has a selected value.
- Drop peer-focus:-translate-y-[1.55rem] extra label translate.
- Drop the .grow-height:focus padding rule (no more height growth or
downward text shift on focus).
- Drop focus:pl-[11px] (no more 1px horizontal jump).
- Replace !border-b-0 with !border-b-transparent so the bottom border
still reserves its 1px while remaining invisible against the
dropdown.
* Select / SelectCheckbox: same anti-jitter treatment.
- Drop .grow-height:focus padding rule (~12px height growth gone).
- Replace !border-b-0 / !border-t-0 with !border-b-transparent /
!border-t-transparent across danger / success / primary branches.
* Button: default width 240px -> 200px to match the form button sizing
used across the app. Test updated to match.
Features
--------
* InputTextArea: scrollbar turns primary blue on focus
(scrollbar-color: rgb(var(--m-primary)) transparent), matching the
Select listbox styling.
* InputAutocomplete: new localFilter prop (default false). When enabled,
filters the options prop client-side based on the input value
(case-insensitive label.includes(query)), so static lists no longer
need a @search listener. Async/API usage keeps the existing behavior.
Playground "Simple statique" and "Avec icône à gauche" examples use
local-filter.
Playground
----------
* client.vue: tighter grid gap (gap-y-5) plus an example error on a
SelectCheckbox to visually exercise the message-space fix.
Tests
-----
All component test files include regression coverage for the above.
720/720 tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
219 lines
7.0 KiB
TypeScript
219 lines
7.0 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { mount } from '@vue/test-utils'
|
|
import type { DefineComponent } from 'vue'
|
|
import { Icon as IconifyIcon } from '@iconify/vue'
|
|
import Button from './Button.vue'
|
|
|
|
type ButtonProps = {
|
|
id?: string
|
|
label?: string
|
|
disabled?: boolean
|
|
buttonClass?: string
|
|
variant?: 'primary' | 'secondary' | 'tertiary' | 'danger'
|
|
iconName?: string
|
|
iconPosition?: 'left' | 'right'
|
|
iconSize?: string | number
|
|
}
|
|
|
|
const ButtonForTest = Button as DefineComponent<ButtonProps>
|
|
|
|
const mountComponent = (props: ButtonProps = {}, slots?: Record<string, string>) =>
|
|
mount(ButtonForTest, {
|
|
props,
|
|
slots,
|
|
global: {
|
|
stubs: {
|
|
IconifyIcon: {
|
|
template: '<span data-test="icon" v-bind="$attrs" />',
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
describe('MalioButton', () => {
|
|
it('renders a button with label', () => {
|
|
const wrapper = mountComponent({ label: 'Valider' })
|
|
|
|
expect(wrapper.find('button').exists()).toBe(true)
|
|
expect(wrapper.text()).toContain('Valider')
|
|
})
|
|
|
|
it('renders slot content over label prop', () => {
|
|
const wrapper = mountComponent({ label: 'Prop' }, { default: 'Slot content' })
|
|
|
|
expect(wrapper.text()).toContain('Slot content')
|
|
expect(wrapper.text()).not.toContain('Prop')
|
|
})
|
|
|
|
it('uses provided id on button', () => {
|
|
const wrapper = mountComponent({ id: 'custom-id' })
|
|
|
|
expect(wrapper.get('button').attributes('id')).toBe('custom-id')
|
|
})
|
|
|
|
it('generates an id when missing', () => {
|
|
const wrapper = mountComponent()
|
|
|
|
const buttonId = wrapper.get('button').attributes('id')
|
|
expect(buttonId?.startsWith('malio-button-')).toBe(true)
|
|
})
|
|
|
|
it('sets type="button" on the button', () => {
|
|
const wrapper = mountComponent()
|
|
|
|
expect(wrapper.get('button').attributes('type')).toBe('button')
|
|
})
|
|
|
|
it('emits click event when clicked', async () => {
|
|
const wrapper = mountComponent()
|
|
|
|
await wrapper.get('button').trigger('click')
|
|
|
|
expect(wrapper.emitted('click')).toHaveLength(1)
|
|
})
|
|
|
|
it('does not emit click when disabled', async () => {
|
|
const wrapper = mountComponent({ disabled: true })
|
|
|
|
await wrapper.get('button').trigger('click')
|
|
|
|
expect(wrapper.emitted('click')).toBeUndefined()
|
|
})
|
|
|
|
it('sets disabled attribute when disabled', () => {
|
|
const wrapper = mountComponent({ disabled: true })
|
|
|
|
expect(wrapper.get('button').attributes('disabled')).toBeDefined()
|
|
})
|
|
|
|
// --- Variant: Primary (default) ---
|
|
|
|
it('applies primary variant by default', () => {
|
|
const wrapper = mountComponent()
|
|
|
|
expect(wrapper.get('button').classes()).toContain('bg-m-btn-primary')
|
|
expect(wrapper.get('button').classes()).toContain('text-white')
|
|
expect(wrapper.get('button').classes()).toContain('cursor-pointer')
|
|
})
|
|
|
|
it('applies primary disabled styles', () => {
|
|
const wrapper = mountComponent({ disabled: true })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('bg-m-disabled')
|
|
expect(wrapper.get('button').classes()).toContain('text-white')
|
|
expect(wrapper.get('button').classes()).toContain('cursor-not-allowed')
|
|
})
|
|
|
|
// --- Variant: Secondary ---
|
|
|
|
it('applies secondary variant', () => {
|
|
const wrapper = mountComponent({ variant: 'secondary' })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('bg-m-btn-secondary')
|
|
expect(wrapper.get('button').classes()).toContain('text-white')
|
|
})
|
|
|
|
it('applies secondary disabled styles', () => {
|
|
const wrapper = mountComponent({ variant: 'secondary', disabled: true })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('bg-m-disabled')
|
|
expect(wrapper.get('button').classes()).toContain('cursor-not-allowed')
|
|
})
|
|
|
|
// --- Variant: Tertiary ---
|
|
|
|
it('applies tertiary variant with border and no background', () => {
|
|
const wrapper = mountComponent({ variant: 'tertiary' })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('border')
|
|
expect(wrapper.get('button').classes()).toContain('border-m-btn-primary')
|
|
expect(wrapper.get('button').classes()).toContain('text-m-btn-primary')
|
|
expect(wrapper.get('button').classes()).toContain('bg-transparent')
|
|
expect(wrapper.get('button').classes()).not.toContain('text-white')
|
|
})
|
|
|
|
it('applies tertiary disabled styles with border', () => {
|
|
const wrapper = mountComponent({ variant: 'tertiary', disabled: true })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('border')
|
|
expect(wrapper.get('button').classes()).toContain('border-m-disabled')
|
|
expect(wrapper.get('button').classes()).toContain('text-m-disabled')
|
|
expect(wrapper.get('button').classes()).toContain('bg-transparent')
|
|
})
|
|
|
|
// --- Variant: Danger ---
|
|
|
|
it('applies danger variant', () => {
|
|
const wrapper = mountComponent({ variant: 'danger' })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('bg-m-btn-danger')
|
|
expect(wrapper.get('button').classes()).toContain('text-white')
|
|
})
|
|
|
|
it('applies danger disabled styles', () => {
|
|
const wrapper = mountComponent({ variant: 'danger', disabled: true })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('bg-m-disabled')
|
|
expect(wrapper.get('button').classes()).toContain('cursor-not-allowed')
|
|
})
|
|
|
|
// --- Sizing ---
|
|
|
|
it('applies correct dimensions', () => {
|
|
const wrapper = mountComponent()
|
|
|
|
expect(wrapper.get('button').classes()).toContain('w-[200px]')
|
|
expect(wrapper.get('button').classes()).toContain('h-[40px]')
|
|
})
|
|
|
|
it('applies font styles', () => {
|
|
const wrapper = mountComponent()
|
|
|
|
expect(wrapper.get('button').classes()).toContain('text-base')
|
|
expect(wrapper.get('button').classes()).toContain('font-bold')
|
|
})
|
|
|
|
// --- buttonClass override ---
|
|
|
|
it('applies buttonClass', () => {
|
|
const wrapper = mountComponent({ buttonClass: 'w-full rounded-full' })
|
|
|
|
expect(wrapper.get('button').classes()).toContain('w-full')
|
|
expect(wrapper.get('button').classes()).toContain('rounded-full')
|
|
})
|
|
|
|
// --- Icon ---
|
|
|
|
it('renders icon on the right by default', () => {
|
|
const wrapper = mountComponent({ iconName: 'mdi:arrow-right' })
|
|
|
|
expect(wrapper.find('[data-test="icon-right"]').exists()).toBe(true)
|
|
expect(wrapper.find('[data-test="icon-left"]').exists()).toBe(false)
|
|
})
|
|
|
|
it('renders icon on the left when specified', () => {
|
|
const wrapper = mountComponent({ iconName: 'mdi:arrow-left', iconPosition: 'left' })
|
|
|
|
expect(wrapper.find('[data-test="icon-left"]').exists()).toBe(true)
|
|
expect(wrapper.find('[data-test="icon-right"]').exists()).toBe(false)
|
|
})
|
|
|
|
it('does not render icon when iconName is empty', () => {
|
|
const wrapper = mountComponent()
|
|
|
|
expect(wrapper.find('[data-test="icon-left"]').exists()).toBe(false)
|
|
expect(wrapper.find('[data-test="icon-right"]').exists()).toBe(false)
|
|
})
|
|
|
|
it('passes icon name and size to icon component', () => {
|
|
const wrapper = mount(ButtonForTest, {
|
|
props: { iconName: 'mdi:check', iconSize: 18 },
|
|
})
|
|
|
|
const iconComponent = wrapper.findComponent(IconifyIcon)
|
|
expect(iconComponent.props('icon')).toBe('mdi:check')
|
|
expect(iconComponent.props('width')).toBe(18)
|
|
expect(iconComponent.props('height')).toBe(18)
|
|
})
|
|
})
|