matthieu
0c9b563cae
Auto Tag Develop / tag (push) Successful in 9s
**MR stackée sur ERP-54** — cible = `feature/ERP-54-creer-entites-client-m1` (PAS `develop`). Tristan validera le stack en fin de chaîne. Branche l'API REST du répertoire clients (M1) sur l'entité `Client` d'ERP-54. ## Périmètre - **ClientProvider** : liste paginée (Paginator ORM aligné ERP-72, `?pagination=false`), exclusion archives+soft-delete par défaut (RG-1.24), `?includeArchived=true` (RG-1.25), tri `companyName ASC` (RG-1.26), filtres `?search` (fuzzy) + `?categoryType`, détail 404 si soft-deleted + embarque contacts/adresses/ribs. - **ClientProcessor** : normalisation (RG-1.18→1.21), 409 doublon nom (RG-1.16) + 409 restauration (RG-1.23), gating par onglet `accounting.manage`/`archive` + mode strict 403 (RG-1.28), archivage exclusif + `archivedAt` (RG-1.22), RG-1.01 / RG-1.03 (mutex + type catégorie) / RG-1.12 / RG-1.13 / RG-1.04. - **ClientReadGroupContextBuilder** : ajout conditionnel du groupe `client:read:accounting` selon `commercial.clients.accounting.view`. - **CategoryReferenceDenormalizer** : résout les IRI catégorie vers `Category` (dénormalisation impossible sur l'interface sinon). - **Contrats Shared** : `CategoryInterface::getCategoryTypeCode()`, `BusinessRoleAwareInterface` + `BusinessRoles::COMMERCIALE`. ## Coordination stack - Permissions `commercial.clients.*` **référencées** ici, déclarées en **ERP-59** (tests RBAC en **ERP-60**). - Rôle métier `commerciale` seedé par **ERP-74** (RG-1.04 dormante d'ici là). - Config globale pagination (itemsPerPage client / max 50) portée par **ERP-72**. - Référentiels comptables (PaymentType/Bank/...) exposés en **ERP-56** → RG-1.12/1.13 testées en unitaire ici (pas d'IRI référentiel disponible avant ERP-56). ## Tests 31 tests Commercial (intégration admin sur les RG métier + unitaires sur le gating / RG-1.04 / RG-1.12 / RG-1.13 / context builder). Suite complète verte (343 tests). Règle n°1 respectée (aucun import inter-modules dans Commercial). --------- Co-authored-by: tristan <tristan@yuno.malio.fr> Co-authored-by: Matthieu <contact@malio.fr> Co-authored-by: Matthieu <mtholot19@gmail.com> Reviewed-on: #31 Co-authored-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr> Co-committed-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr>
86 lines
2.8 KiB
PHP
86 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Module\Commercial\Unit;
|
|
|
|
use ApiPlatform\State\SerializerContextBuilderInterface;
|
|
use App\Module\Commercial\Domain\Entity\Client;
|
|
use App\Module\Commercial\Infrastructure\ApiPlatform\Serializer\ClientReadGroupContextBuilder;
|
|
use PHPUnit\Framework\TestCase;
|
|
use Symfony\Bundle\SecurityBundle\Security;
|
|
use Symfony\Component\HttpFoundation\Request;
|
|
|
|
/**
|
|
* Tests unitaires du context builder qui ajoute conditionnellement le groupe
|
|
* de lecture `client:read:accounting` selon la permission accounting.view
|
|
* (§ 2.7 / § 4.1 / § 4.2).
|
|
*
|
|
* @internal
|
|
*/
|
|
final class ClientReadGroupContextBuilderTest extends TestCase
|
|
{
|
|
public function testAddsAccountingGroupForClientReadWhenGranted(): void
|
|
{
|
|
$builder = $this->builder(
|
|
baseContext: ['resource_class' => Client::class, 'groups' => ['client:read', 'default:read']],
|
|
granted: true,
|
|
);
|
|
|
|
$context = $builder->createFromRequest(new Request(), true);
|
|
|
|
self::assertContains('client:read:accounting', $context['groups']);
|
|
}
|
|
|
|
public function testDoesNotAddAccountingGroupWhenNotGranted(): void
|
|
{
|
|
$builder = $this->builder(
|
|
baseContext: ['resource_class' => Client::class, 'groups' => ['client:read', 'default:read']],
|
|
granted: false,
|
|
);
|
|
|
|
$context = $builder->createFromRequest(new Request(), true);
|
|
|
|
self::assertNotContains('client:read:accounting', $context['groups']);
|
|
}
|
|
|
|
public function testDoesNotAddAccountingGroupOnWrite(): void
|
|
{
|
|
$builder = $this->builder(
|
|
baseContext: ['resource_class' => Client::class, 'groups' => ['client:write:main']],
|
|
granted: true,
|
|
);
|
|
|
|
// normalization = false -> ecriture : pas de groupe de lecture ajoute.
|
|
$context = $builder->createFromRequest(new Request(), false);
|
|
|
|
self::assertNotContains('client:read:accounting', $context['groups']);
|
|
}
|
|
|
|
public function testIgnoresOtherResources(): void
|
|
{
|
|
$builder = $this->builder(
|
|
baseContext: ['resource_class' => 'App\Other\Resource', 'groups' => ['other:read']],
|
|
granted: true,
|
|
);
|
|
|
|
$context = $builder->createFromRequest(new Request(), true);
|
|
|
|
self::assertSame(['other:read'], $context['groups']);
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $baseContext
|
|
*/
|
|
private function builder(array $baseContext, bool $granted): ClientReadGroupContextBuilder
|
|
{
|
|
$decorated = $this->createStub(SerializerContextBuilderInterface::class);
|
|
$decorated->method('createFromRequest')->willReturn($baseContext);
|
|
|
|
$security = $this->createStub(Security::class);
|
|
$security->method('isGranted')->willReturn($granted);
|
|
|
|
return new ClientReadGroupContextBuilder($decorated, $security);
|
|
}
|
|
}
|