120058049c
Auto Tag Develop / tag (push) Successful in 7s
Dernier wagon de la stack back M1. ERP-60 = polish stack + couverture de tests PHPUnit NON dépendante des rôles métier (cf. spec § 7 / § 8.1). ## Phase 0 — polish stack (déjà mergé dans les branches basses via rebase) - ERP-59 : route sidebar `/clients` (au lieu de `/commercial/clients`), cohérente avec `/suppliers`. - One-liner pagination Client abandonné : `pagination_client_enabled: true` est déjà le défaut global → `?pagination=false` marche déjà sur `/api/clients` (décision P7). ## Phase 1 — tests (combler les trous, zéro duplication) 8 nouvelles suites couvrant les RG non encore testées par ERP-55/56/57/58 : - `ClientFormulaireMainTest` — RG-1.02 (téléphone secondaire, max 2). - `ClientAddressTest` — RG-1.06/07/08 + RG-1.11 (CHECK BDD prospect/billing). - `ClientUniquenessTest` — RG-1.15/1.17 (Q4 : SIREN/email NON uniques). - `ClientArchiveTest` — **RG-1.23 : 409 restauration en conflit (gap P1)**. - `ClientAuditTest` — RG-1.27 (created* figés / updatedBy modificateur) + iban/bic présents dans le diff audité. - `ClientMigrationTest` — index partiel unique `uq_client_company_name_active` (1 seul) ; pas d'index siren/email. - `ClientSecurityTest` — 401 anonyme + 403 sans `commercial.clients.view`. - `ClientPatchStrictTest` — RG-1.28 (403 strict mix de groupes, fonctionnel). Cahier de test complet (mapping de TOUTES les RG → test) : `docs/specs/M1-clients/cahier-test-back-M1.md`. ## Délégué à ERP-74 (#493) Matrice RBAC différenciée (bureau/compta/commerciale/usine) + RG-1.04 fonctionnel — exigent les rôles métier seedés après le merge de la stack. ## Gaps documentés (cahier) - RG-1.29 validation écriture (catégorie type sur adresse → 422) non implémentée back (hors § 8.1, ticket test-only). - Violations CHECK adresse → rejet (≥400) sans mapping fin 422 (amélioration possible). ## Vérifs `make db-reset && make php-cs-fixer-allow-risky && make test` → **421 tests OK, 1386 assertions, 0 risky**. Nouveaux tests : 17, 71 assertions. --------- Co-authored-by: Matthieu <contact@malio.fr> Reviewed-on: #38 Co-authored-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr> Co-committed-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr>
254 lines
9.2 KiB
PHP
254 lines
9.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Module\Commercial\Api;
|
|
|
|
use App\Module\Commercial\Domain\Entity\TvaMode;
|
|
use PHPUnit\Framework\Attributes\DataProvider;
|
|
|
|
/**
|
|
* Tests fonctionnels des 4 referentiels comptables lecture seule (ERP-56) :
|
|
* tva_mode, payment_delay, payment_type, bank. Cf. spec-back M1 § 4.7.
|
|
*
|
|
* Couvre les criteres d'acceptation du ticket :
|
|
* - les 4 GetCollection repondent 200 avec le seed (CommercialReferentialFixtures) ;
|
|
* - tri par defaut position ASC puis label ASC ;
|
|
* - POST / PATCH / DELETE -> 405 (aucune operation d'ecriture declaree) ;
|
|
* - user authentifie sans commercial.clients.view -> 403 ;
|
|
* - anonyme -> 401 ;
|
|
* - pagination serveur active (ERP-72) + echappatoire ?pagination=false.
|
|
*
|
|
* @internal
|
|
*/
|
|
final class ReferentialApiTest extends AbstractCommercialApiTestCase
|
|
{
|
|
private const string LD = 'application/ld+json';
|
|
|
|
/**
|
|
* Endpoint => codes attendus dans le seed (sous-ensemble verifie present).
|
|
*
|
|
* @var array<string, list<string>>
|
|
*/
|
|
private const SEED = [
|
|
'/api/tva_modes' => ['FRANCE_VENTES', 'EXPORT_VENTES', 'INTRACOM_VENTES'],
|
|
'/api/payment_delays' => ['J15', 'J30', 'A_RECEPTION'],
|
|
'/api/payment_types' => ['VIREMENT', 'LCR', 'NON_SOUMISE', 'CHEQUE'],
|
|
'/api/banks' => ['SG', 'CIC', 'CA'],
|
|
];
|
|
|
|
/**
|
|
* Purge les eventuelles lignes de test inserees dans tva_mode (tri label).
|
|
* Les codes du seed ne commencent jamais par TEST_, donc cette purge ne
|
|
* touche pas les referentiels metier.
|
|
*/
|
|
protected function tearDown(): void
|
|
{
|
|
$this->getEm()
|
|
->createQuery('DELETE FROM '.TvaMode::class.' t WHERE t.code LIKE :prefix')
|
|
->setParameter('prefix', 'TEST\_%')
|
|
->execute()
|
|
;
|
|
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* Critere : chaque endpoint repond 200 et expose le seed (id, code, label,
|
|
* position) sous le groupe de lecture du referentiel.
|
|
*
|
|
* @param list<string> $expectedCodes
|
|
*/
|
|
#[DataProvider('endpointProvider')]
|
|
public function testCollectionReturns200WithSeed(string $endpoint, array $expectedCodes): void
|
|
{
|
|
$client = $this->createAdminClient();
|
|
$response = $client->request('GET', $endpoint.'?pagination=false', ['headers' => ['Accept' => self::LD]]);
|
|
|
|
self::assertResponseStatusCodeSame(200);
|
|
|
|
$members = $response->toArray()['member'];
|
|
$codes = array_map(static fn (array $m): string => $m['code'], $members);
|
|
|
|
foreach ($expectedCodes as $expected) {
|
|
self::assertContains($expected, $codes, $endpoint.' doit exposer le code seede '.$expected);
|
|
}
|
|
|
|
// Le DTO de lecture expose bien id / code / label / position.
|
|
$first = $members[0];
|
|
self::assertArrayHasKey('id', $first);
|
|
self::assertArrayHasKey('label', $first);
|
|
self::assertArrayHasKey('position', $first);
|
|
}
|
|
|
|
/**
|
|
* Critere : GET item repond 200 (recupere via un id reel de la collection).
|
|
*/
|
|
public function testGetItemReturns200(): void
|
|
{
|
|
$client = $this->createAdminClient();
|
|
|
|
$first = $client->request('GET', '/api/tva_modes?pagination=false', ['headers' => ['Accept' => self::LD]])
|
|
->toArray()['member'][0]
|
|
;
|
|
|
|
$client->request('GET', '/api/tva_modes/'.$first['id'], ['headers' => ['Accept' => self::LD]]);
|
|
self::assertResponseStatusCodeSame(200);
|
|
}
|
|
|
|
/**
|
|
* Critere : tri par defaut position ASC. Le seed tva_mode est ordonne
|
|
* FRANCE_VENTES (10) < EXPORT_VENTES (20) < INTRACOM_VENTES (30).
|
|
*/
|
|
public function testDefaultSortByPositionAsc(): void
|
|
{
|
|
$client = $this->createAdminClient();
|
|
|
|
$codes = array_map(
|
|
static fn (array $m): string => $m['code'],
|
|
$client->request('GET', '/api/tva_modes?pagination=false', ['headers' => ['Accept' => self::LD]])->toArray()['member'],
|
|
);
|
|
|
|
$expectedOrder = ['FRANCE_VENTES', 'EXPORT_VENTES', 'INTRACOM_VENTES'];
|
|
$filtered = array_values(array_intersect($codes, $expectedOrder));
|
|
|
|
self::assertSame(
|
|
$expectedOrder,
|
|
$filtered,
|
|
'Les modes de TVA doivent etre tries position ASC (§ 4.7).',
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Critere : a position egale, tri label ASC (departage). On insere deux
|
|
* lignes de test partageant la meme position, labels volontairement dans le
|
|
* desordre alphabetique ; le tearDown les purge ensuite.
|
|
*/
|
|
public function testTieBreakSortByLabelAsc(): void
|
|
{
|
|
$em = $this->getEm();
|
|
foreach ([['TEST_TIE_Z', 'ZZZ Tie'], ['TEST_TIE_A', 'AAA Tie']] as [$code, $label]) {
|
|
$mode = new TvaMode();
|
|
$mode->setCode($code);
|
|
$mode->setLabel($label);
|
|
$mode->setPosition(9000);
|
|
$em->persist($mode);
|
|
}
|
|
$em->flush();
|
|
|
|
$client = $this->createAdminClient();
|
|
$codes = array_map(
|
|
static fn (array $m): string => $m['code'],
|
|
$client->request('GET', '/api/tva_modes?pagination=false', ['headers' => ['Accept' => self::LD]])->toArray()['member'],
|
|
);
|
|
|
|
$tie = array_values(array_intersect($codes, ['TEST_TIE_A', 'TEST_TIE_Z']));
|
|
self::assertSame(
|
|
['TEST_TIE_A', 'TEST_TIE_Z'],
|
|
$tie,
|
|
'A position egale, le tri secondaire doit etre label ASC (§ 4.7).',
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Critere ERP-72 : la collection est paginee par defaut. Preuve : une page
|
|
* au-dela des donnees est vide (un provider non pagine ignorerait `page`).
|
|
* Avec ?pagination=false, le parametre `page` est ignore -> tout revient.
|
|
*/
|
|
public function testPaginationActiveAndClientToggle(): void
|
|
{
|
|
$client = $this->createAdminClient();
|
|
|
|
// Page 2 d'un referentiel tenant sur une page : vide -> pagination active.
|
|
$page2 = $client->request('GET', '/api/tva_modes?page=2', ['headers' => ['Accept' => self::LD]])->toArray();
|
|
self::assertArrayHasKey('totalItems', $page2);
|
|
self::assertSame([], $page2['member'], 'La page 2 doit etre vide : pagination serveur active.');
|
|
|
|
// ?pagination=false : `page` ignore, le seed complet est renvoye.
|
|
$all = $client->request('GET', '/api/tva_modes?pagination=false&page=2', ['headers' => ['Accept' => self::LD]])->toArray();
|
|
self::assertNotEmpty($all['member'], '?pagination=false doit desactiver la pagination (page ignoree).');
|
|
}
|
|
|
|
/**
|
|
* Critere : aucune operation d'ecriture n'est declaree -> POST sur la
|
|
* collection renvoie 405 Method Not Allowed sur les 4 referentiels.
|
|
*
|
|
* @param list<string> $expectedCodes
|
|
*/
|
|
#[DataProvider('endpointProvider')]
|
|
public function testPostReturns405(string $endpoint, array $expectedCodes): void
|
|
{
|
|
$client = $this->createAdminClient();
|
|
$client->request('POST', $endpoint, [
|
|
'headers' => ['Content-Type' => self::LD],
|
|
'json' => ['code' => 'X', 'label' => 'X', 'position' => 1],
|
|
]);
|
|
|
|
self::assertResponseStatusCodeSame(405);
|
|
}
|
|
|
|
/**
|
|
* Critere : PATCH et DELETE sur un item renvoient 405 (lecture seule).
|
|
*/
|
|
public function testPatchAndDeleteReturn405(): void
|
|
{
|
|
$client = $this->createAdminClient();
|
|
$first = $client->request('GET', '/api/tva_modes?pagination=false', ['headers' => ['Accept' => self::LD]])
|
|
->toArray()['member'][0]
|
|
;
|
|
$iri = '/api/tva_modes/'.$first['id'];
|
|
|
|
$client->request('PATCH', $iri, [
|
|
'headers' => ['Content-Type' => 'application/merge-patch+json'],
|
|
'json' => ['label' => 'Renamed'],
|
|
]);
|
|
self::assertResponseStatusCodeSame(405);
|
|
|
|
$client->request('DELETE', $iri);
|
|
self::assertResponseStatusCodeSame(405);
|
|
}
|
|
|
|
/**
|
|
* Critere : un utilisateur authentifie sans la permission
|
|
* commercial.clients.view obtient 403 sur les 4 endpoints.
|
|
*
|
|
* @param list<string> $expectedCodes
|
|
*/
|
|
#[DataProvider('endpointProvider')]
|
|
public function testForbiddenWithoutPermission(string $endpoint, array $expectedCodes): void
|
|
{
|
|
// User jetable portant une permission SANS rapport (existe en base mais
|
|
// ne donne pas commercial.clients.view).
|
|
$creds = $this->createUserWithPermission('core.users.view');
|
|
$client = $this->authenticatedClient($creds['username'], $creds['password']);
|
|
|
|
$client->request('GET', $endpoint, ['headers' => ['Accept' => self::LD]]);
|
|
self::assertResponseStatusCodeSame(403);
|
|
}
|
|
|
|
/**
|
|
* Critere : un appel anonyme (non authentifie) obtient 401 sur les 4
|
|
* endpoints.
|
|
*
|
|
* @param list<string> $expectedCodes
|
|
*/
|
|
#[DataProvider('endpointProvider')]
|
|
public function testUnauthorizedWhenAnonymous(string $endpoint, array $expectedCodes): void
|
|
{
|
|
$client = self::createClient();
|
|
$client->request('GET', $endpoint, ['headers' => ['Accept' => self::LD]]);
|
|
|
|
self::assertResponseStatusCodeSame(401);
|
|
}
|
|
|
|
/**
|
|
* @return iterable<string, array{string, list<string>}>
|
|
*/
|
|
public static function endpointProvider(): iterable
|
|
{
|
|
foreach (self::SEED as $endpoint => $codes) {
|
|
yield $endpoint => [$endpoint, $codes];
|
|
}
|
|
}
|
|
}
|