36e947fd8e
Auto Tag Develop / tag (push) Successful in 8s
## ERP-187 (1.7) — Tests PHPUnit RG-5.01→5.10 + capture contrat JSON
Couvre les règles de gestion du M5 (tickets de pesée) par des tests PHPUnit et capture la **réponse JSON réelle** (DoD § 4.0.bis) collée dans `spec-back.md` avant les écrans front.
### Tests unitaires (Processor / Normalizer / Callback — sans BDD ni HTTP)
- **NetWeightTest** (RG-5.05) : net = plein − vide, `null` si une pesée manque, recalcul au PATCH.
- **CounterpartyValidationTest** (RG-5.03) : présence du champ requis par branche (propertyPath `client`/`supplier`/`otherLabel`) + exclusivité (null-ification hors-branche).
- **ImmatriculationNormalizationTest** (RG-5.01/5.10) : masque `XX-000-XX`, « Tout format », mapping 422 sur `immatriculation`.
### Tests fonctionnels (API réelle)
- **WeighingTicketNumberingTest** (RG-5.02/5.09) : format `{siteCode}-TP-{NNNN}`, séquence par site, isolation inter-sites, immuabilité numéro/site au PATCH.
- **WeighingTicketSerializationContractTest** (DoD § 4.0.bis) : 4 pièges verts (client embarqué, `plateFreeFormat` présent, `number` formaté, `netWeight` = full − empty) + dump JSON via `WEIGHING_TICKET_DOD_DUMP`.
- **WeighingTicketRBACMatrixTest** (§ 5.2) : admin/bureau/usine OK, compta/commerciale 403, anonyme 401.
> DSD / stub pont bascule / endpoint pesée déjà couverts (ERP-184/185).
### DoD
- `spec-back.md § 4.0.bis` : **JSON réel** (liste + détail) collé, 4 pièges marqués ✅ — feu vert front.
### Vérifications
- `make test` complet **vert** : 848 tests, 6302 assertions (0 échec ; deprecations/notices PHPUnit seuls).
- `make php-cs-fixer-allow-risky` : 0 correction.
Empilée sur ERP-186 (stack M5).
---------
Co-authored-by: Matthieu <contact@malio.fr>
Reviewed-on: #137
161 lines
5.9 KiB
PHP
161 lines
5.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Module\Logistique\Api;
|
|
|
|
use ApiPlatform\Symfony\Bundle\Test\Client;
|
|
use App\Module\Core\Domain\Entity\Role;
|
|
use App\Module\Core\Domain\Entity\User;
|
|
use App\Module\Sites\Domain\Entity\Site;
|
|
use App\Tests\Module\Core\Api\AbstractApiTestCase;
|
|
|
|
/**
|
|
* Endpoint `POST /api/weighbridge_readings` (§ 4.2) — tests fonctionnels.
|
|
*
|
|
* Couvre le wiring securite/routage (que les tests unitaires ne voient pas) :
|
|
* - happy path AUTO / MANUAL avec site courant et permission `manage` ;
|
|
* - 403 sans la permission `manage` (RBAC § 5.2) ;
|
|
* - 422 si le mode est absent / invalide (validation de la ressource).
|
|
*
|
|
* Nettoyage manuel (pas de DAMA) : users/roles `test*` + compteurs DSD.
|
|
*
|
|
* @internal
|
|
*/
|
|
final class WeighbridgeReadingApiTest extends AbstractApiTestCase
|
|
{
|
|
protected function tearDown(): void
|
|
{
|
|
$em = $this->getEm();
|
|
$em->getConnection()->executeStatement('DELETE FROM weighbridge_dsd_counter');
|
|
$em->createQuery('DELETE FROM '.User::class.' u WHERE u.username LIKE :p')
|
|
->setParameter('p', 'testuser_%')->execute()
|
|
;
|
|
$em->createQuery('DELETE FROM '.Role::class.' r WHERE r.code LIKE :p')
|
|
->setParameter('p', 'test_%')->execute()
|
|
;
|
|
|
|
parent::tearDown();
|
|
}
|
|
|
|
public function testAutoWeighingReturnsWeightInBoundsAndDsd(): void
|
|
{
|
|
$client = $this->manageClientWithCurrentSite();
|
|
|
|
$response = $client->request('POST', '/api/weighbridge_readings', [
|
|
'headers' => ['Content-Type' => 'application/ld+json'],
|
|
'json' => ['mode' => 'AUTO'],
|
|
]);
|
|
|
|
self::assertResponseStatusCodeSame(200);
|
|
$data = $response->toArray();
|
|
|
|
self::assertSame('AUTO', $data['mode']);
|
|
self::assertIsInt($data['weight']);
|
|
self::assertGreaterThanOrEqual(10000, $data['weight']);
|
|
self::assertLessThanOrEqual(50000, $data['weight']);
|
|
self::assertIsInt($data['dsd']);
|
|
self::assertGreaterThanOrEqual(1, $data['dsd']);
|
|
// manualNumber est null en mode bascule (cle potentiellement omise si
|
|
// skip_null_values est actif — tolerant aux deux cas).
|
|
self::assertNull($data['manualNumber'] ?? null);
|
|
}
|
|
|
|
public function testManualWeighingKeepsWeightAndAllocatesDsd(): void
|
|
{
|
|
$client = $this->manageClientWithCurrentSite();
|
|
|
|
$response = $client->request('POST', '/api/weighbridge_readings', [
|
|
'headers' => ['Content-Type' => 'application/ld+json'],
|
|
'json' => ['mode' => 'MANUAL', 'weight' => 23187, 'manualNumber' => 'PAP-555'],
|
|
]);
|
|
|
|
self::assertResponseStatusCodeSame(200);
|
|
$data = $response->toArray();
|
|
|
|
self::assertSame('MANUAL', $data['mode']);
|
|
self::assertSame(23187, $data['weight']);
|
|
self::assertSame('PAP-555', $data['manualNumber']);
|
|
self::assertGreaterThanOrEqual(1, $data['dsd']);
|
|
}
|
|
|
|
public function testManagePermissionIsRequired(): void
|
|
{
|
|
// Un user portant uniquement `view` ne peut pas declencher de pesee.
|
|
$credentials = $this->createUserWithPermission('logistique.weighing_tickets.view');
|
|
$client = $this->authenticatedClient($credentials['username'], $credentials['password']);
|
|
|
|
$client->request('POST', '/api/weighbridge_readings', [
|
|
'headers' => ['Content-Type' => 'application/ld+json'],
|
|
'json' => ['mode' => 'AUTO'],
|
|
]);
|
|
|
|
self::assertResponseStatusCodeSame(403);
|
|
}
|
|
|
|
public function testInvalidModeIsRejected(): void
|
|
{
|
|
$client = $this->manageClientWithCurrentSite();
|
|
|
|
$response = $client->request('POST', '/api/weighbridge_readings', [
|
|
'headers' => ['Content-Type' => 'application/ld+json'],
|
|
'json' => ['mode' => 'INVALID'],
|
|
]);
|
|
|
|
// Garde-fou ERP-101 : la 422 doit cibler `mode` (Assert\Choice), pas juste
|
|
// un bon code HTTP — sinon une violation sur le mauvais champ passerait.
|
|
self::assertResponseStatusCodeSame(422);
|
|
self::assertViolationOnPath($response, 'mode');
|
|
}
|
|
|
|
public function testManualWeighingRequiresWeight(): void
|
|
{
|
|
$client = $this->manageClientWithCurrentSite();
|
|
|
|
$response = $client->request('POST', '/api/weighbridge_readings', [
|
|
'headers' => ['Content-Type' => 'application/ld+json'],
|
|
'json' => ['mode' => 'MANUAL'],
|
|
]);
|
|
|
|
// Garde-fou ERP-101 : la 422 doit cibler `weight` (Callback validateManualWeight).
|
|
self::assertResponseStatusCodeSame(422);
|
|
self::assertViolationOnPath($response, 'weight');
|
|
}
|
|
|
|
/**
|
|
* Garde-fou ERP-101 (miroir AbstractWeighingTicketApiTestCase) : une 422 doit
|
|
* porter une violation sur le `propertyPath` attendu, consommable inline par
|
|
* useFormErrors cote front, pas seulement le bon statut HTTP.
|
|
*/
|
|
private static function assertViolationOnPath(object $response, string $path): void
|
|
{
|
|
$paths = array_column($response->toArray(false)['violations'] ?? [], 'propertyPath');
|
|
|
|
self::assertContains(
|
|
$path,
|
|
$paths,
|
|
sprintf('Aucune violation sur "%s" (paths: %s).', $path, implode(', ', $paths)),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Cree un user non-admin portant `logistique.weighing_tickets.manage`, lui
|
|
* positionne un site courant (l'endpoint est cloisonne par site, § 2.3) et
|
|
* renvoie un client authentifie.
|
|
*/
|
|
private function manageClientWithCurrentSite(): Client
|
|
{
|
|
$credentials = $this->createUserWithPermission('logistique.weighing_tickets.manage');
|
|
|
|
$em = $this->getEm();
|
|
$user = $em->getRepository(User::class)->findOneBy(['username' => $credentials['username']]);
|
|
self::assertInstanceOf(User::class, $user);
|
|
|
|
$site = $em->getRepository(Site::class)->findAll()[0];
|
|
$user->setCurrentSite($site);
|
|
$em->flush();
|
|
|
|
return $this->authenticatedClient($credentials['username'], $credentials['password']);
|
|
}
|
|
}
|