Files
Starseed/tests/Module/FieldSales/Api/TourRouteApiTest.php
T
Matthieu f8793ab359
Pull Request — Quality gate / Backend (PHP CS + PHPUnit) (pull_request) Failing after 56s
Pull Request — Quality gate / Frontend (lint + Vitest + build) (pull_request) Failing after 21s
feat(field_sales) : carte interactive Leaflet + écran de planification de tournée (ERP-127)
- API visitable_tiers (provider DBAL bbox/q/type, paginé) pour les pins de la carte
- POST /tours/{id}/reorder (drag & drop) : renumérotation atomique + recompute
- Layer front field-sales : TourMap (pins, popup, polyline, sélection rectangle),
  liste d'étapes draggable (vuedraggable), composable de planification + Vitest
- Pages /tours, /tours/new, /tours/[id]/plan (split responsive, point custom géocodé)
- i18n FR, deep links Waze/Google/Apple, état 100% local
2026-06-11 17:38:40 +02:00

271 lines
11 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Tests\Module\FieldSales\Api;
use App\Module\Commercial\Domain\Entity\Client;
use App\Module\Commercial\Domain\Entity\ClientAddress;
use App\Module\Core\Domain\Entity\User;
use App\Module\FieldSales\Domain\Entity\Tour;
use App\Module\FieldSales\Domain\Entity\TourStop;
use DateTimeImmutable;
/**
* Tests fonctionnels du calcul de trajet, de l'optimisation et de la duplication
* (M6.4 — § 5 /compute /optimize /duplicate). Couvre RG-6.05 (exclusion sans
* coords), RG-6.11 (ETA), l'ordre plus proche voisin et RG-6.13 (duplication sans
* calculs).
*
* @internal
*/
final class TourRouteApiTest extends AbstractFieldSalesApiTestCase
{
private const string LD = 'application/ld+json';
/**
* RG-6.11 : ETA = depart + Σ trajets + Σ visites precedentes. RG-6.05 : une
* etape sans coordonnees est exclue (legs/eta null), les totaux ne la comptent
* pas.
*/
public function testComputeFillsEtaAndExcludesStopsWithoutCoords(): void
{
$client = $this->authenticatedClient('admin', 'admin');
$admin = $this->getUserByUsername('admin');
$tour = $this->seedTour($admin);
// 2 points geolocalises alignes (0,2° de latitude ≈ 22,2 km) + 1 etape
// sur Tiers dont l'adresse n'a pas de coordonnees (exclue, RG-6.05).
$this->seedCustomStop($tour, 0, 47.0, -1.0);
$this->seedCustomStop($tour, 1, 47.2, -1.0);
$tier = $this->seedClient('Sans coords');
$address = $this->seedClientAddressWithoutCoords($tier);
$this->seedTierStop($tour, $tier, $address, 2);
$body = $client->request('POST', '/api/tours/'.$tour->getId().'/compute', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
])->toArray();
$stops = $this->stopsByPosition($body);
// 1re etape = depart (aucun start_* sur la tournee) -> leg nul, eta = 08:00.
self::assertSame(0, $stops[0]['legDistanceM']);
self::assertStringContainsString('08:00:00', (string) $stops[0]['eta']);
// 2e etape : ~22,2 km, eta posterieure au depart (RG-6.11).
self::assertEqualsWithDelta(22_240, $stops[1]['legDistanceM'], 600);
self::assertNotNull($stops[1]['eta']);
self::assertStringContainsString('08:', (string) $stops[1]['eta']);
self::assertGreaterThan($stops[0]['eta'], $stops[1]['eta'], 'ETA croissante le long de la tournee.');
// 3e etape exclue (RG-6.05) : legs + eta restent null.
self::assertNull($stops[2]['legDistanceM'], 'Etape sans coords exclue (RG-6.05).');
self::assertNull($stops[2]['eta']);
// Totaux : seules les etapes geolocalisees comptent.
self::assertEqualsWithDelta(22_240, $body['totalDistanceM'], 600);
self::assertGreaterThan(0, $body['totalDurationS']);
}
/**
* /optimize reordonne les etapes selon le plus proche voisin depuis la 1re
* etape (pas de start_*) puis recompute.
*/
public function testOptimizeReordersStopsByNearestNeighbour(): void
{
$client = $this->authenticatedClient('admin', 'admin');
$admin = $this->getUserByUsername('admin');
$tour = $this->seedTour($admin);
// Depart = 1re etape (47.0). Fournies en desordre : la plus eloignee (47.3)
// en position 1, puis 47.2, puis la plus proche (47.1).
$this->seedCustomStop($tour, 0, 47.0, -1.0, 'Départ');
$this->seedCustomStop($tour, 1, 47.3, -1.0, 'Loin');
$this->seedCustomStop($tour, 2, 47.2, -1.0, 'Milieu');
$this->seedCustomStop($tour, 3, 47.1, -1.0, 'Proche');
$body = $client->request('POST', '/api/tours/'.$tour->getId().'/optimize', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
])->toArray();
$labels = array_map(
static fn (array $s) => $s['customLabel'],
$this->stopsByPosition($body),
);
self::assertSame(['Départ', 'Proche', 'Milieu', 'Loin'], $labels, 'Ordre plus proche voisin depuis le depart.');
}
/**
* RG-6.13 : la duplication copie depart + etapes a une nouvelle date, en
* draft, SANS les calculs (eta / legs recalcules ensuite).
*/
public function testDuplicateCopiesStopsWithoutComputedValues(): void
{
$client = $this->authenticatedClient('admin', 'admin');
$admin = $this->getUserByUsername('admin');
$tour = $this->seedTour($admin, 'Tournée à dupliquer');
$this->seedCustomStop($tour, 0, 47.0, -1.0, 'A');
$this->seedCustomStop($tour, 1, 47.2, -1.0, 'B');
// On calcule d'abord la source pour s'assurer qu'elle porte des eta/legs.
$client->request('POST', '/api/tours/'.$tour->getId().'/compute', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
]);
$body = $client->request('POST', '/api/tours/'.$tour->getId().'/duplicate', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
'json' => ['tourDate' => '2026-09-01'],
])->toArray();
self::assertResponseStatusCodeSame(201);
self::assertNotSame($tour->getId(), $body['id'], 'Une nouvelle tournee est creee.');
self::assertSame('draft', $body['status'], 'La copie repart en draft.');
self::assertStringStartsWith('2026-09-01', $body['tourDate']);
self::assertNull($body['totalDistanceM'], 'RG-6.13 : pas de totaux copies.');
$stops = $this->stopsByPosition($body);
self::assertCount(2, $stops);
self::assertSame(['A', 'B'], array_map(static fn (array $s) => $s['customLabel'], $stops));
self::assertNull($stops[0]['eta'], 'RG-6.13 : eta non copiee (recalculee ensuite).');
self::assertNull($stops[0]['legDistanceM'], 'RG-6.13 : legs non copies.');
}
public function testDuplicateRequiresTourDate(): void
{
$client = $this->authenticatedClient('admin', 'admin');
$admin = $this->getUserByUsername('admin');
$tour = $this->seedTour($admin);
$response = $client->request('POST', '/api/tours/'.$tour->getId().'/duplicate', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
'json' => [],
]);
self::assertResponseStatusCodeSame(422);
self::assertArrayHasKey('tourDate', $this->violationsByPath($response->toArray(false)));
}
/**
* /reorder applique l'ordre fourni (drag & drop) en renumerotant les
* positions sans heurter l'unique (tour_id, position), puis recompute.
*/
public function testReorderAppliesGivenOrderAndRecomputes(): void
{
$client = $this->authenticatedClient('admin', 'admin');
$admin = $this->getUserByUsername('admin');
$tour = $this->seedTour($admin);
$a = $this->seedCustomStop($tour, 0, 47.0, -1.0, 'A');
$b = $this->seedCustomStop($tour, 1, 47.1, -1.0, 'B');
$c = $this->seedCustomStop($tour, 2, 47.2, -1.0, 'C');
// Ordre inverse demande : C, B, A.
$body = $client->request('POST', '/api/tours/'.$tour->getId().'/reorder', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
'json' => ['stopIds' => [$c->getId(), $b->getId(), $a->getId()]],
])->toArray();
$stops = $this->stopsByPosition($body);
self::assertSame([0, 1, 2], array_map(static fn (array $s) => $s['position'], $stops));
self::assertSame(['C', 'B', 'A'], array_map(static fn (array $s) => $s['customLabel'], $stops));
// Recompute applique : la 1re etape est le depart (leg nul).
self::assertSame(0, $stops[0]['legDistanceM']);
self::assertNotNull($body['totalDistanceM']);
}
public function testReorderRequiresStopIds(): void
{
$client = $this->authenticatedClient('admin', 'admin');
$admin = $this->getUserByUsername('admin');
$tour = $this->seedTour($admin);
$response = $client->request('POST', '/api/tours/'.$tour->getId().'/reorder', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
'json' => [],
]);
self::assertResponseStatusCodeSame(422);
self::assertArrayHasKey('stopIds', $this->violationsByPath($response->toArray(false)));
}
public function testComputeRequiresManagePermission(): void
{
$creds = $this->createUserWithPermissions(['field_sales.tours.view']);
$client = $this->authenticatedClient($creds['username'], $creds['password']);
$user = $this->getUserByUsername($creds['username']);
$tour = $this->seedTour($user);
$client->request('POST', '/api/tours/'.$tour->getId().'/compute', [
'headers' => ['Content-Type' => self::LD, 'Accept' => self::LD],
]);
self::assertResponseStatusCodeSame(403, 'compute exige field_sales.tours.manage.');
}
// =================================================================
// Helpers de seed specifiques au calcul de trajet
// =================================================================
private function seedCustomStop(Tour $tour, int $position, float $lat, float $lng, string $label = 'Point libre'): TourStop
{
$em = $this->getEm();
$stop = new TourStop();
$stop->setTour($tour);
$stop->setTierType(TourStop::TIER_TYPE_CUSTOM);
$stop->setCustomLabel($label);
$stop->setCustomLatitude($lat);
$stop->setCustomLongitude($lng);
$stop->setPosition($position);
$em->persist($stop);
$em->flush();
return $stop;
}
private function seedTierStop(Tour $tour, Client $tier, ClientAddress $address, int $position): TourStop
{
$em = $this->getEm();
$stop = new TourStop();
$stop->setTour($tour);
$stop->setTierType('client');
$stop->setTierId($tier->getId());
$stop->setAddressId($address->getId());
$stop->setPosition($position);
$em->persist($stop);
$em->flush();
return $stop;
}
private function seedClientAddressWithoutCoords(Client $client): ClientAddress
{
$em = $this->getEm();
$address = new ClientAddress();
$address->setClient($client);
$address->setIsProspect(true);
$address->setPostalCode('44000');
$address->setCity('NANTES');
$address->setStreet('1 rue Sans Coords');
$em->persist($address);
$em->flush();
return $address;
}
/**
* Etapes de la reponse (item Tour) indexees par position croissante.
*
* @param array<string, mixed> $body
*
* @return list<array<string, mixed>>
*/
private function stopsByPosition(array $body): array
{
$stops = $body['stops'] ?? [];
usort($stops, static fn (array $a, array $b) => $a['position'] <=> $b['position']);
return array_values($stops);
}
}