6efe7aa8ea
Auto Tag Develop / tag (push) Successful in 9s
## Contexte Ticket Lesstime : [#52](https://project.malio-dev.fr/projects/6/tasks/463) Position dans le groupe M0 : 0.0 (prérequis transverse) ## Implémentation - 2 interfaces (`TimestampableInterface`, `BlamableInterface`) dans `Shared/Domain/Contract/` - 1 trait (`TimestampableBlamableTrait`) dans `Shared/Domain/Trait/` - 1 Subscriber Doctrine (`TimestampableBlamableSubscriber`) dans `Shared/Infrastructure/Doctrine/` - 1 ligne `resolve_target_entities` ajoutée à `config/packages/doctrine.yaml` (`UserInterface` → `User`) - 1 test architecture (`EntitiesAreTimestampableBlamableTest`) garde-fou L3 de la spec § 2.8.bis - 1 test unitaire (`TimestampableBlamableSubscriberTest`) 4 cas ## Décision EXCLUDED (cf. réponse review) Les 4 entités préexistantes (`User`, `Role`, `Permission`, `Site`) sont **whitelistées** dans `EXCLUDED` avec justification par entrée, plutôt que rétrofitées dans ce ticket. Le rétrofit de `User` et `Site` est documenté en **HP-9 / HP-10** (récursion Blamable + migration → décision archi scopée). Doc mise à jour : spec § 2.8.bis, § 9, et `.claude/rules/backend.md`. ## Tests - PHPUnit : 5 nouveaux tests, 0 échec, 0 risky (248 tests / 874 assertions au total) - php-cs-fixer : OK ## Reviewer suggéré - Tristan --------- Co-authored-by: Matthieu <mtholot19@gmail.com> Reviewed-on: #13 Co-authored-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr> Co-committed-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr>
160 lines
5.5 KiB
PHP
160 lines
5.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Shared\Infrastructure\Doctrine;
|
|
|
|
use App\Shared\Domain\Contract\BlamableInterface;
|
|
use App\Shared\Domain\Contract\TimestampableInterface;
|
|
use App\Shared\Domain\Trait\TimestampableBlamableTrait;
|
|
use App\Shared\Infrastructure\Doctrine\TimestampableBlamableSubscriber;
|
|
use DateTimeImmutable;
|
|
use Doctrine\ORM\EntityManagerInterface;
|
|
use Doctrine\ORM\Event\PrePersistEventArgs;
|
|
use Doctrine\ORM\Event\PreUpdateEventArgs;
|
|
use PHPUnit\Framework\TestCase;
|
|
use Symfony\Bundle\SecurityBundle\Security;
|
|
use Symfony\Component\Security\Core\User\UserInterface;
|
|
|
|
/**
|
|
* Tests unitaires du TimestampableBlamableSubscriber.
|
|
*
|
|
* On exerce directement prePersist / preUpdate avec un EntityManager et une
|
|
* Security stubbes — aucun boot de kernel, aucun acces BDD. Les entites de test
|
|
* sont des fixtures internes (cf. bas de fichier).
|
|
*
|
|
* @internal
|
|
*/
|
|
final class TimestampableBlamableSubscriberTest extends TestCase
|
|
{
|
|
public function testPrePersistWithUser(): void
|
|
{
|
|
$user = $this->createStub(UserInterface::class);
|
|
$subscriber = new TimestampableBlamableSubscriber($this->securityReturning($user));
|
|
$entity = new FullAuditableFixture();
|
|
|
|
$subscriber->prePersist($this->prePersistArgs($entity));
|
|
|
|
// Les 4 colonnes sont remplies : dates posees, blame = user courant.
|
|
self::assertInstanceOf(DateTimeImmutable::class, $entity->getCreatedAt());
|
|
self::assertInstanceOf(DateTimeImmutable::class, $entity->getUpdatedAt());
|
|
self::assertSame($entity->getCreatedAt(), $entity->getUpdatedAt());
|
|
self::assertSame($user, $entity->getCreatedBy());
|
|
self::assertSame($user, $entity->getUpdatedBy());
|
|
}
|
|
|
|
public function testPrePersistWithoutUser(): void
|
|
{
|
|
$subscriber = new TimestampableBlamableSubscriber($this->securityReturning(null));
|
|
$entity = new FullAuditableFixture();
|
|
|
|
$subscriber->prePersist($this->prePersistArgs($entity));
|
|
|
|
// Hors contexte HTTP (CLI / cron) : dates remplies, blame laisse a null.
|
|
self::assertInstanceOf(DateTimeImmutable::class, $entity->getCreatedAt());
|
|
self::assertInstanceOf(DateTimeImmutable::class, $entity->getUpdatedAt());
|
|
self::assertNull($entity->getCreatedBy());
|
|
self::assertNull($entity->getUpdatedBy());
|
|
}
|
|
|
|
public function testPreUpdate(): void
|
|
{
|
|
$user = $this->createStub(UserInterface::class);
|
|
$subscriber = new TimestampableBlamableSubscriber($this->securityReturning($user));
|
|
|
|
// On simule une entite deja persistee : createdAt fige dans le passe,
|
|
// createdBy positionne par une creation anterieure.
|
|
$createdAt = new DateTimeImmutable('2020-01-01 10:00:00');
|
|
$entity = new FullAuditableFixture();
|
|
$entity->setCreatedAt($createdAt);
|
|
$entity->setUpdatedAt($createdAt);
|
|
|
|
$subscriber->preUpdate($this->preUpdateArgs($entity));
|
|
|
|
// updatedAt avance, createdAt reste fige, updatedBy = user courant.
|
|
self::assertSame($createdAt, $entity->getCreatedAt());
|
|
self::assertGreaterThan($createdAt, $entity->getUpdatedAt());
|
|
self::assertSame($user, $entity->getUpdatedBy());
|
|
}
|
|
|
|
public function testPartialEntityTimestampableOnly(): void
|
|
{
|
|
$user = $this->createStub(UserInterface::class);
|
|
$subscriber = new TimestampableBlamableSubscriber($this->securityReturning($user));
|
|
$entity = new TimestampableOnlyFixture();
|
|
|
|
// Entite Timestampable mais NON Blamable : seules les dates sont posees,
|
|
// aucun appel de blame (et aucune erreur).
|
|
$subscriber->prePersist($this->prePersistArgs($entity));
|
|
|
|
self::assertInstanceOf(DateTimeImmutable::class, $entity->getCreatedAt());
|
|
self::assertInstanceOf(DateTimeImmutable::class, $entity->getUpdatedAt());
|
|
}
|
|
|
|
/**
|
|
* Security stubbee renvoyant l'utilisateur fourni (ou null).
|
|
*/
|
|
private function securityReturning(?UserInterface $user): Security
|
|
{
|
|
$security = $this->createStub(Security::class);
|
|
$security->method('getUser')->willReturn($user);
|
|
|
|
return $security;
|
|
}
|
|
|
|
private function prePersistArgs(object $entity): PrePersistEventArgs
|
|
{
|
|
return new PrePersistEventArgs($entity, $this->createStub(EntityManagerInterface::class));
|
|
}
|
|
|
|
private function preUpdateArgs(object $entity): PreUpdateEventArgs
|
|
{
|
|
$changeSet = [];
|
|
|
|
return new PreUpdateEventArgs($entity, $this->createStub(EntityManagerInterface::class), $changeSet);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Fixture interne : entite metier complete (Timestampable + Blamable) via le
|
|
* Trait reel teste.
|
|
*
|
|
* @internal
|
|
*/
|
|
final class FullAuditableFixture implements TimestampableInterface, BlamableInterface
|
|
{
|
|
use TimestampableBlamableTrait;
|
|
}
|
|
|
|
/**
|
|
* Fixture interne : entite Timestampable seule (sans Blamable), pour verifier
|
|
* la dissociation des deux contrats par le Subscriber.
|
|
*
|
|
* @internal
|
|
*/
|
|
final class TimestampableOnlyFixture implements TimestampableInterface
|
|
{
|
|
private ?DateTimeImmutable $createdAt = null;
|
|
private ?DateTimeImmutable $updatedAt = null;
|
|
|
|
public function getCreatedAt(): ?DateTimeImmutable
|
|
{
|
|
return $this->createdAt;
|
|
}
|
|
|
|
public function setCreatedAt(DateTimeImmutable $createdAt): void
|
|
{
|
|
$this->createdAt = $createdAt;
|
|
}
|
|
|
|
public function getUpdatedAt(): ?DateTimeImmutable
|
|
{
|
|
return $this->updatedAt;
|
|
}
|
|
|
|
public function setUpdatedAt(DateTimeImmutable $updatedAt): void
|
|
{
|
|
$this->updatedAt = $updatedAt;
|
|
}
|
|
}
|