MALIO-DEV/Starseed
3
0
Fork 0
Code Issues Pull Requests 14 Actions Packages Projects Releases Wiki Activity

feat(transport) : adresse unique par transporteur (OneToOne back + un seul bloc front) (ERP-172)

Browse Source
This commit is contained in:
Autin
2026-06-17 17:32:29 +02:00
parent 498cef8cc0
commit e76bd1dd63
14 changed files with 219 additions and 225 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Module/Transport/Api/AbstractCarrierApiTestCase.php
+1 -1
View File
@@ -149,7 +149,7 @@ abstract class AbstractCarrierApiTestCase extends AbstractApiTestCase
$address->setPostalCode('86000');
$address->setCity('Poitiers');
$address->setStreet('12 rue des Acacias');
$carrier->addAddress($address);
$carrier->setAddress($address);
$em->persist($address);
$contact = new CarrierContact();
tests/Module/Transport/Api/CarrierAddressApiTest.php
+25 -8
View File
@@ -13,7 +13,7 @@ use Symfony\Component\Console\Output\NullOutput;
/**
* Sous-ressource Adresse d'un transporteur (spec-back M4 § 4.5, ERP-159).
* POST /api/carriers/{id}/addresses, PATCH/DELETE /api/carrier_addresses/{id}.
* POST /api/carriers/{id}/address, PATCH/DELETE /api/carrier_addresses/{id}.
*
* Contrat verifie :
* - RG-4.06 : code postal hors ^[0-9]{4,5}$ -> 422 ;
@@ -55,7 +55,7 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
$carrier = $this->seedCarrierWithChartered('Cp Invalide', false);
$client = $this->createAdminClient();
$response = $client->request('POST', '/api/carriers/'.$carrier->getId().'/addresses', [
$response = $client->request('POST', '/api/carriers/'.$carrier->getId().'/address', [
'headers' => ['Content-Type' => self::LD],
'json' => ['postalCode' => '123'], // 3 chiffres -> Regex KO
]);
@@ -73,7 +73,7 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
$carrier = $this->seedCarrierWithChartered('Cp Ville Incoherents', false);
$client = $this->createAdminClient();
$client->request('POST', '/api/carriers/'.$carrier->getId().'/addresses', [
$client->request('POST', '/api/carriers/'.$carrier->getId().'/address', [
'headers' => ['Content-Type' => self::LD],
'json' => [
'postalCode' => '86000', // Poitiers
@@ -91,7 +91,7 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
$carrier = $this->seedCarrierWithChartered('Affrete Incomplet', true);
$client = $this->createAdminClient();
$response = $client->request('POST', '/api/carriers/'.$carrier->getId().'/addresses', [
$response = $client->request('POST', '/api/carriers/'.$carrier->getId().'/address', [
'headers' => ['Content-Type' => self::LD],
'json' => ['postalCode' => '86000'],
]);
@@ -107,7 +107,7 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
$carrier = $this->seedCarrierWithChartered('Affrete Complet', true);
$client = $this->createAdminClient();
$client->request('POST', '/api/carriers/'.$carrier->getId().'/addresses', [
$client->request('POST', '/api/carriers/'.$carrier->getId().'/address', [
'headers' => ['Content-Type' => self::LD],
'json' => [
'country' => 'France',
@@ -119,13 +119,30 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
self::assertResponseStatusCodeSame(201);
}
public function testSecondAddressReturns409(): void
{
// Adresse UNIQUE (ERP-172) : un 2e POST sur un transporteur qui a deja une
// adresse -> 409 explicite (garde CarrierAddressProcessor avant la contrainte
// d'unicite carrier_id).
$address = $this->seedAddress('Deja Une Adresse', false);
$carrier = $address->getCarrier();
self::assertNotNull($carrier);
$client = $this->createAdminClient();
$client->request('POST', '/api/carriers/'.$carrier->getId().'/address', [
'headers' => ['Content-Type' => self::LD],
'json' => ['postalCode' => '17000', 'city' => 'La Rochelle', 'street' => '2 rue Neuve'],
]);
self::assertResponseStatusCodeSame(409);
}
public function testPostAddressOnUnknownCarrierReturns404(): void
{
// Sous-ressource en read:false : le parent introuvable n'est plus intercepte
// en amont -> le processor doit lever un 404 explicite (sinon 500 au persist).
$client = $this->createAdminClient();
$client->request('POST', '/api/carriers/999999/addresses', [
$client->request('POST', '/api/carriers/999999/address', [
'headers' => ['Content-Type' => self::LD],
'json' => ['postalCode' => '86000', 'city' => 'Poitiers', 'street' => '1 rue X'],
]);
@@ -156,7 +173,7 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
self::assertNotNull($carrier);
$client = $this->authenticatedClient('commerciale', self::PWD); // view seul
$client->request('POST', '/api/carriers/'.$carrier->getId().'/addresses', [
$client->request('POST', '/api/carriers/'.$carrier->getId().'/address', [
'headers' => ['Content-Type' => self::LD],
'json' => ['postalCode' => '86000', 'city' => 'Poitiers', 'street' => '1 rue X'],
]);
@@ -201,7 +218,7 @@ final class CarrierAddressApiTest extends AbstractCarrierApiTestCase
$address->setPostalCode('86000');
$address->setCity('Poitiers');
$address->setStreet('12 rue des Acacias');
$carrier->addAddress($address);
$carrier->setAddress($address);
$em->persist($address);
$em->flush();
tests/Module/Transport/Api/CarrierSerializationContractTest.php
+4 -3
View File
@@ -93,8 +93,9 @@ final class CarrierSerializationContractTest extends AbstractCarrierApiTestCase
self::assertArrayHasKey('isChartered', $data);
self::assertFalse($data['isArchived']);
self::assertNotEmpty($data['addresses']);
self::assertSame('Poitiers', $data['addresses'][0]['city']);
// Adresse UNIQUE (OneToOne, ERP-172) : embarquee en OBJET (pas une liste).
self::assertIsArray($data['address']);
self::assertSame('Poitiers', $data['address']['city']);
self::assertNotEmpty($data['contacts']);
self::assertSame('Marie', $data['contacts'][0]['firstName']);
@@ -209,7 +210,7 @@ final class CarrierSerializationContractTest extends AbstractCarrierApiTestCase
self::assertArrayHasKey('member', $list);
self::assertArrayHasKey('qualimatCarrier', $detail);
self::assertArrayHasKey('addresses', $detail);
self::assertArrayHasKey('address', $detail);
self::assertArrayHasKey('contacts', $detail);
self::assertArrayHasKey('prices', $detail);