MALIO-DEV/Starseed
3
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat(transport) : adresse unique par transporteur (OneToOne back + un seul bloc front) (ERP-172)

Browse Source
This commit is contained in:
Autin
2026-06-17 17:32:29 +02:00
parent 498cef8cc0
commit e76bd1dd63
14 changed files with 219 additions and 225 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Module/Transport/Domain/Entity/Carrier.php
+13 -21
View File
@@ -198,10 +198,13 @@ class Carrier implements TimestampableInterface, BlamableInterface
#[Groups(['carrier:read', 'carrier:write:main'])]
private ?string $liotPlates = null;
// === Adresse UNIQUE (OneToOne) — EMBARQUEE dans le DETAIL (read-group sur le getter) ===
// Metier : un transporteur a au plus UNE adresse (decision metier ERP-172). La
// FK porte un index UNIQUE (cote CarrierAddress.carrier en OneToOne owning side).
#[ORM\OneToOne(mappedBy: 'carrier', targetEntity: CarrierAddress::class, cascade: ['persist', 'remove'], orphanRemoval: true)]
private ?CarrierAddress $address = null;
// === Sous-collections — EMBARQUEES dans le DETAIL (read-group sur le getter) ===
/** @var Collection<int, CarrierAddress> */
#[ORM\OneToMany(mappedBy: 'carrier', targetEntity: CarrierAddress::class, cascade: ['persist', 'remove'], orphanRemoval: true)]
private Collection $addresses;
/** @var Collection<int, CarrierContact> */
#[ORM\OneToMany(mappedBy: 'carrier', targetEntity: CarrierContact::class, cascade: ['persist', 'remove'], orphanRemoval: true)]
@@ -228,9 +231,8 @@ class Carrier implements TimestampableInterface, BlamableInterface
public function __construct()
{
$this->addresses = new ArrayCollection();
$this->contacts = new ArrayCollection();
$this->prices = new ArrayCollection();
$this->contacts = new ArrayCollection();
$this->prices = new ArrayCollection();
}
/**
@@ -409,32 +411,22 @@ class Carrier implements TimestampableInterface, BlamableInterface
return $this;
}
/** @return Collection<int, CarrierAddress> */
#[Groups(['carrier:item:read'])]
public function getAddresses(): Collection
public function getAddress(): ?CarrierAddress
{
return $this->addresses;
return $this->address;
}
public function addAddress(CarrierAddress $address): static
public function setAddress(?CarrierAddress $address): static
{
if (!$this->addresses->contains($address)) {
$this->addresses->add($address);
$this->address = $address;
if (null !== $address && $address->getCarrier() !== $this) {
$address->setCarrier($this);
}
return $this;
}
public function removeAddress(CarrierAddress $address): static
{
if ($this->addresses->removeElement($address) && $address->getCarrier() === $this) {
$address->setCarrier(null);
}
return $this;
}
/** @return Collection<int, CarrierContact> */
#[Groups(['carrier:item:read'])]
public function getContacts(): Collection
src/Module/Transport/Domain/Entity/CarrierAddress.php
+8 -7
View File
@@ -58,14 +58,13 @@ use Symfony\Component\Validator\Constraints as Assert;
normalizationContext: ['groups' => ['carrier:item:read', 'default:read']],
),
new Post(
uriTemplate: '/carriers/{carrierId}/addresses',
uriTemplate: '/carriers/{carrierId}/address',
uriVariables: [
'carrierId' => new Link(fromClass: Carrier::class, toProperty: 'carrier'),
],
// read:false : pas de stade lecture du parent. Le Link toProperty
// resoudrait l'enfant (SELECT CarrierAddress ... WHERE carrier = :id)
// et casse en NonUniqueResult des >= 2 enfants. Le parent est rattache
// manuellement par CarrierAddressProcessor::linkParent (404 si absent).
// read:false : pas de stade lecture du parent. Le parent est rattache
// manuellement par CarrierAddressProcessor::linkParent (404 si absent),
// qui refuse aussi une 2e adresse (RG metier : adresse UNIQUE — 409).
read: false,
security: "is_granted('transport.carriers.manage')",
normalizationContext: ['groups' => ['carrier:item:read', 'default:read']],
@@ -86,7 +85,9 @@ use Symfony\Component\Validator\Constraints as Assert;
)]
#[ORM\Entity]
#[ORM\Table(name: 'carrier_address')]
#[ORM\Index(name: 'idx_carrier_address_carrier', columns: ['carrier_id'])]
// Adresse UNIQUE par transporteur (OneToOne owning side) : contrainte d'unicite
// sur carrier_id (decision metier ERP-172).
#[ORM\UniqueConstraint(name: 'uniq_carrier_address_carrier', columns: ['carrier_id'])]
#[ORM\Index(name: 'idx_carrier_address_created_by', columns: ['created_by'])]
#[ORM\Index(name: 'idx_carrier_address_updated_by', columns: ['updated_by'])]
#[Auditable]
@@ -100,7 +101,7 @@ class CarrierAddress implements TimestampableInterface, BlamableInterface
#[Groups(['carrier:item:read'])]
private ?int $id = null;
#[ORM\ManyToOne(targetEntity: Carrier::class, inversedBy: 'addresses')]
#[ORM\OneToOne(targetEntity: Carrier::class, inversedBy: 'address')]
#[ORM\JoinColumn(name: 'carrier_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
private ?Carrier $carrier = null;
src/Module/Transport/Infrastructure/ApiPlatform/State/Processor/CarrierAddressProcessor.php
+27 -1
View File
@@ -6,12 +6,14 @@ namespace App\Module\Transport\Infrastructure\ApiPlatform\State\Processor;
use ApiPlatform\Metadata\DeleteOperationInterface;
use ApiPlatform\Metadata\Operation;
use ApiPlatform\Metadata\Post;
use ApiPlatform\State\ProcessorInterface;
use ApiPlatform\Validator\Exception\ValidationException;
use App\Module\Transport\Domain\Entity\Carrier;
use App\Module\Transport\Domain\Entity\CarrierAddress;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\DependencyInjection\Attribute\Autowire;
use Symfony\Component\HttpKernel\Exception\ConflictHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Validator\ConstraintViolation;
use Symfony\Component\Validator\ConstraintViolationList;
@@ -63,6 +65,7 @@ final class CarrierAddressProcessor implements ProcessorInterface
}
$this->linkParent($data, $uriVariables);
$this->guardSingleAddress($data, $operation);
$this->guardCharteredAddress($data);
return $this->persistProcessor->process($data, $operation, $uriVariables, $context);
@@ -70,7 +73,7 @@ final class CarrierAddressProcessor implements ProcessorInterface
/**
* Rattache l'adresse au transporteur parent de la sous-ressource POST
* (/carriers/{carrierId}/addresses) : la relation n'est pas peuplee
* (/carriers/{carrierId}/address) : la relation n'est pas peuplee
* automatiquement par le Link sur une ecriture. Sur PATCH, no-op.
*/
private function linkParent(CarrierAddress $address, array $uriVariables): void
@@ -98,6 +101,29 @@ final class CarrierAddressProcessor implements ProcessorInterface
$address->setCarrier($carrier);
}
/**
* Adresse UNIQUE par transporteur (decision metier ERP-172) : un POST sur un
* transporteur qui a deja une adresse -> 409 explicite (plutot qu'un 500 sur la
* contrainte d'unicite carrier_id). No-op sur PATCH (mise a jour de l'adresse
* existante). Lookup repository pour rester robuste a la synchro bidirectionnelle.
*/
private function guardSingleAddress(CarrierAddress $address, Operation $operation): void
{
if (!$operation instanceof Post) {
return;
}
$carrier = $address->getCarrier();
if (!$carrier instanceof Carrier) {
return;
}
$existing = $this->em->getRepository(CarrierAddress::class)->findOneBy(['carrier' => $carrier]);
if (null !== $existing && $existing->getId() !== $address->getId()) {
throw new ConflictHttpException('Ce transporteur a déjà une adresse.');
}
}
/**
* RG-4.05 : si le transporteur parent est affrete (isChartered), l'adresse doit
* porter Pays / Code postal / Ville / Adresse. Chaque champ manquant -> une
src/Module/Transport/Infrastructure/DataFixtures/CarrierFixtures.php
+2 -1
View File
@@ -189,7 +189,8 @@ class CarrierFixtures extends Fixture implements DependentFixtureInterface
$address->setPostalCode($postalCode);
$address->setCity($city);
$address->setStreet($street);
$carrier->addAddress($address);
// Adresse UNIQUE (OneToOne) — ERP-172.
$carrier->setAddress($address);
}
/**