MALIO-DEV/Starseed
3
0
Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

feat(catalog) : categories multi-types (M:N) + bouton Filtres liste (#75)
Auto Tag Develop / tag (push) Successful in 7s
Details

Browse Source 
## Contexte

Une `Category` ne pouvait appartenir qu'à **un seul** `CategoryType` (ManyToOne). Le besoin métier : plusieurs types par catégorie. Cette MR fait passer la relation en **ManyToMany** et ajoute le bouton **« Filtres »** à droite de la liste des catégories (modèle Répertoire Clients).

Slice vertical complet (le passage M:N casse mécaniquement le contrat inter-module `CategoryInterface`, consommé par la RG-2.10 fournisseurs).

## Volet A — Relation M:N
- `Category.categoryType` (ManyToOne) → `categoryTypes` (ManyToMany, jonction `category_category_type`). Au moins un type obligatoire (`Assert\\Count(min:1)`).
- **Unicité du nom GLOBALE** parmi les actifs (`uq_category_name_active`, remplace `uq_category_name_type_active`). Message 409 reformulé.
- Migration : table de jonction + backfill + drop colonne `category_type_id` + nouvel index. Validée **rejouable sur base fraîche**.
- Contrat Shared : `getCategoryTypeCode()` → `getCategoryTypeCodes(): array`. `Supplier`/`SupplierAddress`/`SupplierFixtures` revalident « contient FOURNISSEUR » (RG-2.10).
- Provider/Repository : filtre type via sous-requête `EXISTS` (ne tronque pas la collection embarquée), eager-load anti-N+1.

## Volet B — Bouton « Filtres »
- Drawer recherche par nom + types multi (OR). Compteur de filtres actifs. État local, jamais persisté en URL.
- Back : filtres `?name=` et `?typeId[]=` sur la collection.

## Front
- Multi-select `MalioSelectCheckbox`, `useCategoryForm` en `categoryTypeIds[]`, colonne « Types », clés i18n.

## Tests / vérifs
- `make test` : **582 tests, 2474 assertions, 0 échec** ✅
- `make nuxt-test` : **236 tests** ✅
- `make php-cs-fixer-allow-risky` ✅
- Migration rejouée sur base fraîche (`make db-reset`) ✅
- Nouveau `CategoryFilterTest` (name partiel + typeId[] OR + multi-type non dupliqué)

---------

Co-authored-by: Matthieu <contact@malio.fr>
Reviewed-on: #75
Co-authored-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr>
Co-committed-by: THOLOT DECHENE Matthieu <matthieu@yuno.malio.fr>
This commit was merged in pull request #75.
This commit is contained in:
THOLOT DECHENE Matthieu
2026-06-08 09:47:15 +00:00
committed by admin malio
parent 43b2251ef1
commit a9c14704b7
32 changed files with 913 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Module/Catalog/Api/AbstractCatalogApiTestCase.php
+10 -1
View File
@@ -70,11 +70,17 @@ abstract class AbstractCatalogApiTestCase extends AbstractApiTestCase
* cleanup. Si aucun type n'est fourni, un nouveau CategoryType est cree.
* Le flag $deletedAt permet de seeder directement une categorie
* soft-deleted (pour les tests RG-1.08 / RG-1.11).
*
* Multi-types (ManyToMany) : `$type` est le type principal (cree si null) ;
* `$additionalTypes` permet d'attacher d'autres types pour les cas multi.
*
* @param list<CategoryType> $additionalTypes
*/
protected function createCategory(
?string $name = null,
?CategoryType $type = null,
?DateTimeImmutable $deletedAt = null,
array $additionalTypes = [],
): Category {
$em = $this->getEm();
@@ -86,7 +92,10 @@ abstract class AbstractCatalogApiTestCase extends AbstractApiTestCase
// ERP-78 : code NOT NULL + unique parmi les actifs (uq_category_code).
// Nonce aleatoire -> unicite garantie entre seeds successifs du test.
$category->setCode('TEST_'.strtoupper($suffix));
$category->setCategoryType($type);
$category->addCategoryType($type);
foreach ($additionalTypes as $additionalType) {
$category->addCategoryType($additionalType);
}
if (null !== $deletedAt) {
$category->setDeletedAt($deletedAt);
}
tests/Module/Catalog/Api/CategoryAuditTest.php
+2 -2
View File
@@ -57,7 +57,7 @@ final class CategoryAuditTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'audit_create',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(201, $response->getStatusCode());
@@ -139,7 +139,7 @@ final class CategoryAuditTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'audit_manager',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(201, $response->getStatusCode());
tests/Module/Catalog/Api/CategoryCodeTest.php
+5 -5
View File
@@ -26,7 +26,7 @@ final class CategoryCodeTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'Agro-alimentaire',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
@@ -48,7 +48,7 @@ final class CategoryCodeTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'readonly',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
// Le client tente d'imposer un code : doit etre ignore.
'code' => 'CLIENT_FORGED',
],
@@ -65,13 +65,13 @@ final class CategoryCodeTest extends AbstractCatalogApiTestCase
$type = $this->createCategoryType();
$client = $this->createAdminClient();
// Deux noms differents (donc autorises par uq_category_name_type_active)
// Deux noms differents (donc autorises par uq_category_name_active)
// mais qui produisent le meme slug -> codes distincts (suffixe `_2`).
$first = $client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'Agro Plus',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
])->toArray();
@@ -79,7 +79,7 @@ final class CategoryCodeTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'Agro-Plus',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
])->toArray();
tests/Module/Catalog/Api/CategoryFilterTest.php
+137
View File
@@ -0,0 +1,137 @@
<?php
declare(strict_types=1);
namespace App\Tests\Module\Catalog\Api;
/**
* Tests des filtres de la liste admin sur GET /api/categories :
* - `?name=` : recherche partielle case-insensitive sur le nom ;
* - `?typeId[]=` : categories portant AU MOINS UN des types coches (OR), sans
* doublon meme pour une categorie multi-types ;
* - combinaison `?name=` + `?typeId[]=` (ET entre filtres).
*
* @internal
*/
final class CategoryFilterTest extends AbstractCatalogApiTestCase
{
/**
* @param array<int, array<string, mixed>> $members
*
* @return list<string>
*/
private function testNames(array $members): array
{
$names = array_map(static fn (array $m): string => $m['name'], $members);
$names = array_values(array_filter(
$names,
fn (string $n): bool => str_starts_with($n, self::TEST_CATEGORY_PREFIX),
));
sort($names);
return $names;
}
public function testNameFilterIsPartialAndCaseInsensitive(): void
{
$type = $this->createCategoryType();
$this->createCategory(self::TEST_CATEGORY_PREFIX.'Acier inox', $type);
$this->createCategory(self::TEST_CATEGORY_PREFIX.'Aluminium', $type);
$client = $this->createAdminClient();
$response = $client->request('GET', '/api/categories?name=ACIER&pagination=false');
self::assertSame(200, $response->getStatusCode());
self::assertSame(
[self::TEST_CATEGORY_PREFIX.'Acier inox'],
$this->testNames($response->toArray()['member']),
'Le filtre ?name= doit etre partiel et insensible a la casse.',
);
}
public function testTypeIdFilterReturnsCategoriesWithAtLeastOneType(): void
{
$typeA = $this->createCategoryType();
$typeB = $this->createCategoryType();
$typeC = $this->createCategoryType();
$this->createCategory(self::TEST_CATEGORY_PREFIX.'only_a', $typeA);
$this->createCategory(self::TEST_CATEGORY_PREFIX.'only_b', $typeB);
$this->createCategory(self::TEST_CATEGORY_PREFIX.'only_c', $typeC);
$client = $this->createAdminClient();
$response = $client->request(
'GET',
sprintf('/api/categories?typeId[]=%d&typeId[]=%d&pagination=false', $typeA->getId(), $typeB->getId()),
);
self::assertSame(200, $response->getStatusCode());
self::assertSame(
[
self::TEST_CATEGORY_PREFIX.'only_a',
self::TEST_CATEGORY_PREFIX.'only_b',
],
$this->testNames($response->toArray()['member']),
'Le filtre ?typeId[]= doit remonter les categories portant AU MOINS UN des types (OR).',
);
}
public function testMultiTypeCategoryAppearsOnceWhenFilteredByOneType(): void
{
// Une categorie portant deux types ne doit pas etre dupliquee quand on
// filtre sur l'un de ses types (la sous-requete EXISTS evite les doublons).
$typeA = $this->createCategoryType();
$typeB = $this->createCategoryType();
$this->createCategory(
self::TEST_CATEGORY_PREFIX.'multi',
$typeA,
null,
[$typeB],
);
$client = $this->createAdminClient();
$response = $client->request(
'GET',
sprintf('/api/categories?typeId[]=%d&pagination=false', $typeA->getId()),
);
self::assertSame(200, $response->getStatusCode());
$members = $response->toArray()['member'];
self::assertSame(
[self::TEST_CATEGORY_PREFIX.'multi'],
$this->testNames($members),
'La categorie multi-types ne doit apparaitre qu une seule fois.',
);
// Les deux types restent embarques (la collection n'est pas tronquee).
$multi = array_values(array_filter(
$members,
fn (array $m): bool => $m['name'] === self::TEST_CATEGORY_PREFIX.'multi',
))[0];
self::assertCount(2, $multi['categoryTypes'], 'Les 2 types doivent rester embarques malgre le filtre.');
}
public function testNameAndTypeIdFiltersCombine(): void
{
$typeA = $this->createCategoryType();
$typeB = $this->createCategoryType();
$this->createCategory(self::TEST_CATEGORY_PREFIX.'steel_a', $typeA);
$this->createCategory(self::TEST_CATEGORY_PREFIX.'steel_b', $typeB);
$this->createCategory(self::TEST_CATEGORY_PREFIX.'wood_a', $typeA);
$client = $this->createAdminClient();
$response = $client->request(
'GET',
sprintf('/api/categories?name=steel&typeId[]=%d&pagination=false', $typeA->getId()),
);
self::assertSame(200, $response->getStatusCode());
self::assertSame(
[self::TEST_CATEGORY_PREFIX.'steel_a'],
$this->testNames($response->toArray()['member']),
'Les filtres ?name= et ?typeId[]= doivent se combiner (ET).',
);
}
}
tests/Module/Catalog/Api/CategoryPermissionsTest.php
+4 -4
View File
@@ -66,7 +66,7 @@ final class CategoryPermissionsTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'forbidden',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -81,7 +81,7 @@ final class CategoryPermissionsTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'anon',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -96,7 +96,7 @@ final class CategoryPermissionsTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'admin_create',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -112,7 +112,7 @@ final class CategoryPermissionsTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'view_only',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
tests/Module/Catalog/Api/CategoryTimestampableBlamableTest.php
+3 -3
View File
@@ -69,7 +69,7 @@ final class CategoryTimestampableBlamableTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'tsb_admin',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(201, $response->getStatusCode());
@@ -140,7 +140,7 @@ final class CategoryTimestampableBlamableTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'tsb_patch',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(201, $response->getStatusCode());
@@ -220,7 +220,7 @@ final class CategoryTimestampableBlamableTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'tsb_delete',
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(201, $response->getStatusCode());
tests/Module/Catalog/Api/CategoryTypeCodeFilterTest.php
+4 -3
View File
@@ -47,9 +47,10 @@ final class CategoryTypeCodeFilterTest extends AbstractCatalogApiTestCase
'Le filtre ?typeCode= doit ne renvoyer QUE les categories du type demande.',
);
// Tous les types embarques doivent etre le type filtre.
// Chaque categorie remontee doit PORTER le type filtre (multi-types :
// la collection categoryTypes embarquee contient le code demande).
foreach ($members as $member) {
self::assertSame('TEST_FOURNISSEUR', $member['categoryType']['code']);
self::assertContains('TEST_FOURNISSEUR', array_column($member['categoryTypes'], 'code'));
}
}
@@ -68,7 +69,7 @@ final class CategoryTypeCodeFilterTest extends AbstractCatalogApiTestCase
self::assertArrayHasKey('member', $data);
foreach ($data['member'] as $member) {
self::assertSame('TEST_FOURNISSEUR', $member['categoryType']['code']);
self::assertContains('TEST_FOURNISSEUR', array_column($member['categoryTypes'], 'code'));
}
}
tests/Module/Catalog/Api/CategoryUniqueTest.php
+37 -37
View File
@@ -5,22 +5,22 @@ declare(strict_types=1);
namespace App\Tests\Module\Catalog\Api;
/**
* Tests RG-1.07 : unicite case-insensitive de (LOWER(name), category_type_id)
* parmi les categories non soft-deleted. L'index Postgres partiel
* `uq_category_name_type_active` est traduit en 409 Conflict par le
* CategoryProcessor.
* Tests RG-1.07 : unicite case-insensitive du nom GLOBALEMENT (LOWER(name))
* parmi les categories non soft-deleted. Depuis le passage en ManyToMany,
* l'unicite n'est plus liee au type. L'index Postgres partiel
* `uq_category_name_active` est traduit en 409 Conflict par le CategoryProcessor.
*
* Cas couverts :
* - doublon strict (meme name + meme type) → 409 ;
* - doublon case-insensitive (Vis / vis sur meme type) → 409 ;
* - meme name sur 2 types differents → les deux passent (pas de doublon) ;
* - recreation apres soft delete → 201 (l'index partiel libere le couple).
* - doublon strict (meme name) → 409 ;
* - doublon case-insensitive (Vis / VIS) → 409 ;
* - meme name avec des types differents → 409 (unicite GLOBALE) ;
* - recreation apres soft delete → 201 (l'index partiel libere le nom).
*
* @internal
*/
final class CategoryUniqueTest extends AbstractCatalogApiTestCase
{
public function testDuplicateNameSameTypeReturns409(): void
public function testDuplicateNameReturns409(): void
{
$type = $this->createCategoryType();
$client = $this->createAdminClient();
@@ -29,29 +29,29 @@ final class CategoryUniqueTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'unique',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'unique',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
// 2eme POST : meme name + meme type → doublon strict.
// 2eme POST : meme name → doublon (unicite globale).
$response = $client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'unique',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'unique',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(409, $response->getStatusCode());
// Message attendu par la spec RG-1.07.
// Message attendu par la spec RG-1.07 (reformulee, sans "pour ce type").
$payload = $response->toArray(false);
$description = $payload['description'] ?? $payload['detail'] ?? $payload['hydra:description'] ?? '';
self::assertStringContainsString(
'existe déjà pour ce type',
'existe déjà',
$description,
'Le message d\'erreur 409 doit citer la spec ("existe deja pour ce type").',
'Le message d\'erreur 409 doit citer la spec ("existe deja").',
);
}
@@ -64,8 +64,8 @@ final class CategoryUniqueTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'Vis',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'Vis',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
@@ -74,17 +74,17 @@ final class CategoryUniqueTest extends AbstractCatalogApiTestCase
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
// Meme prefix mais variation de casse → meme LOWER → collision.
'name' => self::TEST_CATEGORY_PREFIX.'VIS',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'VIS',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(409, $response->getStatusCode());
}
public function testSameNameDifferentTypeAllowed(): void
public function testSameNameDifferentTypeReturns409(): void
{
// RG-1.07 : la contrainte est SUR (name, type), pas sur name seul.
// Le meme nom doit etre acceptable sur deux types differents.
// RG-1.07 (reformulee) : l'unicite du nom est desormais GLOBALE — le
// meme nom sur deux types differents est un doublon.
$type1 = $this->createCategoryType();
$type2 = $this->createCategoryType();
$client = $this->createAdminClient();
@@ -92,27 +92,27 @@ final class CategoryUniqueTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'shared',
'categoryType' => '/api/category_types/'.$type1->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'shared',
'categoryTypes' => ['/api/category_types/'.$type1->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
$client->request('POST', '/api/categories', [
$response = $client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'shared',
'categoryType' => '/api/category_types/'.$type2->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'shared',
'categoryTypes' => ['/api/category_types/'.$type2->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
self::assertSame(409, $response->getStatusCode());
}
public function testRecreateAfterSoftDeleteAllowed(): void
{
// RG-1.07 : l'index Postgres est partiel (WHERE deleted_at IS NULL).
// Apres un soft delete, le couple (name, type) est libere et un
// nouveau POST identique doit reussir.
// Apres un soft delete, le nom est libere et un nouveau POST identique
// doit reussir.
$type = $this->createCategoryType();
$client = $this->createAdminClient();
@@ -120,8 +120,8 @@ final class CategoryUniqueTest extends AbstractCatalogApiTestCase
$response = $client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'recreate',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'recreate',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertSame(201, $response->getStatusCode());
@@ -131,12 +131,12 @@ final class CategoryUniqueTest extends AbstractCatalogApiTestCase
$client->request('DELETE', '/api/categories/'.$created['id']);
self::assertResponseStatusCodeSame(204);
// 3) recreation : meme name + meme type → autorise (couple libere).
// 3) recreation : meme name → autorise (nom libere par l'archivage).
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'recreate',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => self::TEST_CATEGORY_PREFIX.'recreate',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
tests/Module/Catalog/Api/CategoryValidationTest.php
+36 -33
View File
@@ -11,8 +11,8 @@ use App\Module\Catalog\Domain\Entity\Category;
* - RG-1.02 : `name` obligatoire (NotBlank) ;
* - RG-1.03 : `name` trim cote serveur via CategoryProcessor ;
* - RG-1.04 : `name` longueur 2..120 (Length) ;
* - RG-1.05 : `categoryType` obligatoire ;
* - RG-1.06 : `categoryType` doit pointer un type existant.
* - RG-1.05 : `categoryTypes` — au moins un type (Count min 1) ;
* - RG-1.06 : chaque IRI de `categoryTypes` doit pointer un type existant.
*
* @internal
*/
@@ -27,7 +27,7 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'categoryType' => '/api/category_types/'.$type->getId(),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
// name absent
],
]);
@@ -42,8 +42,8 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => '',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => '',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -59,8 +59,8 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => ' ',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => ' ',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -79,8 +79,8 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => $payloadName,
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => $payloadName,
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -103,8 +103,8 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => 'A',
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => 'A',
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -118,8 +118,8 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => str_repeat('a', 121),
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => str_repeat('a', 121),
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
@@ -140,71 +140,74 @@ final class CategoryValidationTest extends AbstractCatalogApiTestCase
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => $name,
'categoryType' => '/api/category_types/'.$type->getId(),
'name' => $name,
'categoryTypes' => ['/api/category_types/'.$type->getId()],
],
]);
self::assertResponseStatusCodeSame(201);
}
// ============ RG-1.05 — categoryType obligatoire ============
// ============ RG-1.05 — au moins un type (Count min 1) ============
public function testCategoryTypeRequiredReturns422(): void
public function testCategoryTypesRequiredReturns422(): void
{
$client = $this->createAdminClient();
$client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'no_type',
// categoryType absent
// categoryTypes absent -> collection vide -> Count(min:1) viole.
],
]);
self::assertResponseStatusCodeSame(422);
}
public function testCategoryTypeNullIsRejected(): void
public function testCategoryTypesEmptyReturns422(): void
{
// `categoryType: null` echoue a la deserialization IRI (API Platform
// renvoie 400) bien avant la validation Assert\NotNull. La spec § 4.3
// accepte les deux : on assert le contrat fort "ne passe pas en BDD".
// Tableau vide explicite : Assert\Count(min: 1) doit declencher 422 avec
// une violation sur le propertyPath `categoryTypes` (consommable inline).
$client = $this->createAdminClient();
$response = $client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'null_type',
'categoryType' => null,
'name' => self::TEST_CATEGORY_PREFIX.'empty_types',
'categoryTypes' => [],
],
]);
self::assertSame(422, $response->getStatusCode());
$payload = $response->toArray(false);
$violations = $payload['violations'] ?? $payload['hydra:violations'] ?? [];
$paths = array_column($violations, 'propertyPath');
self::assertContains(
$response->getStatusCode(),
[400, 422],
'categoryType=null doit etre rejete (400 deserialization ou 422 validation).',
'categoryTypes',
$paths,
'La violation Count doit porter le propertyPath `categoryTypes`.',
);
}
// ============ RG-1.06 — categoryType doit exister ============
// ============ RG-1.06 — chaque type doit exister ============
public function testCategoryTypeMustExistReturns4xx(): void
{
// IRI vers un id qui n'existe pas. API Platform peut renvoyer 400
// (resolution IRI echouee) ou 422 (validation NotNull declenchee).
// La spec § 4.3 accepte les deux : on assert le contrat "ne passe pas".
// (resolution IRI echouee) ou 422 (validation declenchee). La spec § 4.3
// accepte les deux : on assert le contrat "ne passe pas".
$client = $this->createAdminClient();
$response = $client->request('POST', '/api/categories', [
'headers' => ['Content-Type' => 'application/ld+json'],
'json' => [
'name' => self::TEST_CATEGORY_PREFIX.'ghost_type',
'categoryType' => '/api/category_types/9999999',
'name' => self::TEST_CATEGORY_PREFIX.'ghost_type',
'categoryTypes' => ['/api/category_types/9999999'],
],
]);
self::assertContains(
$response->getStatusCode(),
[400, 404, 422],
'IRI categoryType inexistante doit etre rejetee (400/404/422 selon API Platform).',
'IRI categoryTypes inexistante doit etre rejetee (400/404/422 selon API Platform).',
);
}
}
tests/Module/Commercial/Api/AbstractCommercialApiTestCase.php
+1 -1
View File
@@ -107,7 +107,7 @@ abstract class AbstractCommercialApiTestCase extends AbstractApiTestCase
$category = new Category();
$category->setName($name);
$category->setCode($effectiveCode);
$category->setCategoryType($this->clientCategoryType());
$category->addCategoryType($this->clientCategoryType());
$em->persist($category);
$em->flush();
tests/Module/Commercial/Api/AbstractSupplierApiTestCase.php
+1 -1
View File
@@ -77,7 +77,7 @@ abstract class AbstractSupplierApiTestCase extends AbstractCommercialApiTestCase
$category = new Category();
$category->setName(self::TEST_CATEGORY_PREFIX.'fr_'.strtolower($code));
$category->setCode($code);
$category->setCategoryType($this->supplierCategoryType());
$category->addCategoryType($this->supplierCategoryType());
$em->persist($category);
$em->flush();
tests/Module/Commercial/Domain/Entity/SupplierValidationTest.php
+23 -7
View File
@@ -55,6 +55,17 @@ final class SupplierValidationTest extends TestCase
self::assertContains('categories', $this->violationPaths($supplier));
}
public function testMultiTypeCategoryContainingFournisseurIsAccepted(): void
{
// RG-2.10 sous ManyToMany : une categorie qui PORTE FOURNISSEUR (parmi
// d'autres types) reste autorisee sur un fournisseur.
$supplier = new Supplier();
$supplier->setCompanyName('Recycla SAS');
$supplier->addCategory($this->category('CLIENT', 'FOURNISSEUR'));
self::assertNotContains('categories', $this->violationPaths($supplier));
}
// === RG-2.07 : Virement impose une banque ===
public function testVirementWithoutBankIsRejectedOnBankPath(): void
@@ -131,13 +142,17 @@ final class SupplierValidationTest extends TestCase
}
/**
* Double minimal de CategoryInterface (pas d'acces base) renvoyant le code de
* type de categorie voulu — seul element regarde par validateCategoryType.
* Double minimal de CategoryInterface (pas d'acces base) PORTANT les codes de
* type voulus — seul element regarde par validateCategoryType. Variadic pour
* couvrir le cas multi-types (ManyToMany).
*
* @return list<string> n'est pas le type de retour : helper renvoyant un double
*/
private function category(string $typeCode): CategoryInterface
private function category(string ...$typeCodes): CategoryInterface
{
return new class($typeCode) implements CategoryInterface {
public function __construct(private readonly string $typeCode) {}
return new class(array_values($typeCodes)) implements CategoryInterface {
/** @param list<string> $typeCodes */
public function __construct(private readonly array $typeCodes) {}
public function getId(): ?int
{
@@ -154,9 +169,10 @@ final class SupplierValidationTest extends TestCase
return 'TEST';
}
public function getCategoryTypeCode(): ?string
/** @return list<string> */
public function getCategoryTypeCodes(): array
{
return $this->typeCode;
return $this->typeCodes;
}
};
}