fix(commercial) : robust gating + strict category denormalizer + provider via EM (review ERP-55)

src/Module/Commercial/Infrastructure/ApiPlatform/State/Provider/ClientProvider.php

@@ -11,6 +11,7 @@ use ApiPlatform\State\Pagination\Pagination;
 use ApiPlatform\State\ProviderInterface;
 use App\Module\Commercial\Domain\Entity\Client;
 use App\Module\Commercial\Domain\Repository\ClientRepositoryInterface;
+use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\QueryBuilder;
 use Doctrine\ORM\Tools\Pagination\Paginator as DoctrinePaginator;
 use Symfony\Component\DependencyInjection\Attribute\Autowire;
@@ -45,6 +46,7 @@ final class ClientProvider implements ProviderInterface
         #[Autowire(service: 'App\Module\Commercial\Infrastructure\Doctrine\DoctrineClientRepository')]
         private readonly ClientRepositoryInterface $repository,
         private readonly Pagination $pagination,
+        private readonly EntityManagerInterface $em,
     ) {}
 
     public function provide(Operation $operation, array $uriVariables = [], array $context = []): Client|iterable|Paginator|null
@@ -73,7 +75,7 @@ final class ClientProvider implements ProviderInterface
         // Echappatoire ?pagination=false : collection complete sans Paginator
         // (cf. convention ERP-72 — utile pour un <select> cote front).
         if (!$this->pagination->isEnabled($operation, $context)) {
-            /** @var list<Client> $result */
+            // @var list<Client> $result
             return $qb->getQuery()->getResult();
         }
 
@@ -144,8 +146,13 @@ final class ClientProvider implements ProviderInterface
             return;
         }
 
-        $sub = $this->repository->createQueryBuilder('c2')
+        // Sous-requete construite via l'EntityManager (et non
+        // $repository->createQueryBuilder()) : createQueryBuilder() n'est pas
+        // declaree sur ClientRepositoryInterface, l'appeler exposerait un detail
+        // d'implementation Doctrine hors du contrat (fuite d'abstraction).
+        $sub = $this->em->createQueryBuilder()
             ->select('c2.id')
+            ->from(Client::class, 'c2')
             ->join('c2.categories', 'cat2')
             ->join('cat2.categoryType', 'ct2')
             ->where('ct2.code = :categoryType')