8313c759c6
Auto Tag Develop / tag (push) Successful in 9s
## Migration modular monolith DDD — Lesstime (0.1 → 3.3) Cette MR regroupe l'intégralité de la refonte en monolithe modulaire (strangler progressif, additif). Elle remplace les MR stackées de Phase 1 (#12–#16), désormais incluses ici. **Ne pas merger avant validation fonctionnelle** : branche destinée à être testée telle quelle. ### Périmètre — 9 modules sous `src/Module/` | Phase | Module | Contenu | |------|--------|---------| | 0.1 | (socle) | infrastructure modulaire, `ModuleInterface`, mapping Doctrine par module | | 0.2 | (socle front) | auto-détection des layers Nuxt sous `frontend/modules/*` | | 1.1 | **Core** | Identité (User/Auth), Notifications, Notifier | | 1.2 | Core | RBAC fin (permissions `module.resource.action`, sidebar gated) | | 1.3 | Core | Audit log (`#[Auditable]`, listener, provider DBAL) | | 2.1 | **TimeTracking** | TimeEntry + MCP + export | | 2.2 | **ProjectManagement** | cœur métier Projets/Tâches + 38 MCP tools | | 2.3 | **Absence** | demandes, soldes, policies, justificatifs | | 2.4 | **Directory** | Clients (migrés) + **Prospects** (nouveau, conversion → Client) | | 2.5 | **Mail** | intégration IMAP OVH + liens tâches | | 2.6 | **Integration** | Gitea / BookStack / Zimbra / Share | | 3.1 | **Reporting** | rapports transverses (DBAL read-only, 0 import inter-module) | | 3.2 | **ClientPortal** | portail client (ROLE_CLIENT cloisonné, tickets, notifications) | | 3.3 | (finition) | nettoyage legacy — `src/Entity` vide, app 100% modulaire | ### Architecture - Découplage inter-modules par **contrats** (`UserInterface`, `ProjectInterface`, `TaskInterface`, `TaskTagInterface`, `ClientInterface`, `ClientTicketInterface`, `LeaveProfileInterface`) + `resolve_target_entities` 100% modulaire (aucune cible legacy). - Repositories : interface `Domain/Repository` + implémentation `Infrastructure/Doctrine`, bindées. - Reporting en DBAL read-only pur (aucun import d'entité d'un autre module). - Chaque migration de module : déplacement à comportement préservé (API publique et noms d'outils MCP inchangés), migrations **additives** uniquement (zéro destructif). ### Sécurité - ROLE_CLIENT cloisonné : un utilisateur client n'accède qu'à `/portal` et à ses propres tickets (filtrés par `allowedProjects`), interdit sur toute l'API interne. - Correctif : interdiction pour un client de créer un lien vers le partage SMB (upload uniquement). ### QA non-régression (branche reconstruite from scratch) - Migrations from scratch + fixtures : OK. - Compilation dev + prod : OK. - **180 tests PHPUnit verts**, php-cs-fixer clean, ~96 routes, **66 outils MCP** tous sous `App\Module\*`. - Smoke test runtime multi-rôles (admin / ROLE_USER / ROLE_CLIENT) : 44 vérifications HTTP, **0 écart**, cloisonnement client étanche. - Build Nuxt OK, 9 layers, 0 import legacy résiduel. ### Points à arbitrer (hors périmètre de cette migration) - Durcissement MCP/IDOR pré-existant (`userId` explicite sans scoping sur certains tools TimeTracking/Absence/TaskDocument) — ticket dédié recommandé. - Validation fonctionnelle de **Prospect** et **ClientPortal** (conçus depuis les specs disque). - **Harmonisation visuelle Malio finale** (3.3) — finition esthétique inter-modules laissée au PO. --- ## ⚠️ Déploiement / migration des données — à ne pas oublier ### 1. Resynchroniser les séquences PostgreSQL après tout import/restore de dump Si la prod (ou tout environnement) est **montée depuis un dump** (`pg_restore` / `COPY`), les lignes sont chargées avec leurs `id` explicites **sans avancer les séquences** → au premier `INSERT` : `duplicate key value violates unique constraint "..._pkey"` (constaté en local sur `notification`, `task`, `time_entry`…). À lancer **juste après chaque restore/import** : ```sql DO $$ DECLARE r RECORD; maxid BIGINT; seq TEXT; BEGIN FOR r IN SELECT table_name, column_name FROM information_schema.columns WHERE table_schema='public' LOOP seq := pg_get_serial_sequence(quote_ident(r.table_name), r.column_name); IF seq IS NOT NULL THEN EXECUTE format('SELECT COALESCE(MAX(%I),0) FROM %I', r.column_name, r.table_name) INTO maxid; PERFORM setval(seq, GREATEST(maxid,1), maxid > 0); END IF; END LOOP; END $$; ``` > Ne concerne **pas** une prod qui tourne déjà (séquences avancées organiquement) — uniquement le cas restore/import. Idempotent, sans risque. ### 2. Fix dénormalisation des collections typées-contrat (code, inclus dans la branche) Les relations **to-many** typées par une interface `Shared\Domain\Contract\*` (`TimeEntry::tags` → `TaskTagInterface`, `Task::collaborators` → `UserInterface`) étaient **indénormalisables par API Platform** (mono-valué OK via IRI, collection KO) → **tout POST/PATCH portant une telle collection renvoyait 400/500**. Corrigé par un dénormaliseur générique `ContractRelationDenormalizer` (réutilise `resolve_target_entities`, zéro couplage par-entité) + test fonctionnel de non-régression. --------- Co-authored-by: Matthieu <contact@malio.fr> Reviewed-on: #17
273 lines
9.1 KiB
Vue
273 lines
9.1 KiB
Vue
<template>
|
|
<MalioDrawer v-model="isOpen">
|
|
<template #header>
|
|
<h2 class="text-xl font-bold">{{ isEditing ? $t('workflows.editWorkflow') : $t('workflows.addWorkflow') }}</h2>
|
|
</template>
|
|
<form class="flex flex-col gap-4" @submit.prevent="handleSubmit">
|
|
<MalioInputText
|
|
v-model="form.name"
|
|
:label="$t('workflows.name')"
|
|
input-class="w-full"
|
|
:error="touched.name && !form.name.trim() ? $t('workflows.name') + ' requis' : ''"
|
|
@blur="touched.name = true"
|
|
/>
|
|
|
|
<div class="flex items-center gap-2">
|
|
<input
|
|
id="isDefault"
|
|
v-model="form.isDefault"
|
|
type="checkbox"
|
|
class="h-4 w-4 rounded border-neutral-300 text-primary-500 focus:ring-primary-500"
|
|
/>
|
|
<label for="isDefault" class="text-sm font-medium text-neutral-700">
|
|
{{ $t('workflows.isDefault') }}
|
|
</label>
|
|
</div>
|
|
|
|
<div class="mt-2">
|
|
<div class="flex items-center justify-between">
|
|
<h3 class="text-sm font-bold text-neutral-900">{{ $t('workflows.statuses') }}</h3>
|
|
<MalioButton
|
|
type="button"
|
|
icon-name="mdi:plus"
|
|
icon-position="left"
|
|
button-class="w-auto px-3 py-1 text-xs"
|
|
:label="$t('workflows.addStatus')"
|
|
@click="addStatus"
|
|
/>
|
|
</div>
|
|
|
|
<div class="mt-3 flex flex-col gap-3">
|
|
<div
|
|
v-for="(s, idx) in form.statuses"
|
|
:key="idx"
|
|
class="rounded border border-neutral-200 p-3"
|
|
>
|
|
<div class="flex items-end gap-2">
|
|
<MalioInputText
|
|
v-model="s.label"
|
|
label="Libellé"
|
|
input-class="w-full"
|
|
/>
|
|
<MalioSelect
|
|
v-model="s.category"
|
|
:options="categoryOptions"
|
|
label="Catégorie"
|
|
group-class="w-48 shrink-0"
|
|
/>
|
|
<button
|
|
type="button"
|
|
class="h-10 px-2 text-red-600 hover:text-red-800"
|
|
aria-label="Supprimer"
|
|
@click="removeStatus(idx)"
|
|
>
|
|
<Icon name="mdi:delete" size="20" />
|
|
</button>
|
|
</div>
|
|
<div class="mt-2 flex items-center gap-3">
|
|
<ColorPicker v-model="s.color" />
|
|
<label class="ml-auto flex items-center gap-1 text-xs text-neutral-700">
|
|
<input v-model="s.isFinal" type="checkbox" class="h-3 w-3" />
|
|
{{ $t('archive.statusFinal') }}
|
|
</label>
|
|
<label class="flex flex-col text-xs text-neutral-700">
|
|
Position
|
|
<input
|
|
v-model.number="s.position"
|
|
type="number"
|
|
class="mt-1 h-9 w-16 rounded border border-neutral-300 px-2 text-sm"
|
|
/>
|
|
</label>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="mt-4 flex justify-end">
|
|
<MalioButton
|
|
label="Enregistrer"
|
|
button-class="w-auto px-6"
|
|
:disabled="isSubmitting"
|
|
@click="handleSubmit"
|
|
/>
|
|
</div>
|
|
</form>
|
|
</MalioDrawer>
|
|
</template>
|
|
|
|
<script setup lang="ts">
|
|
import type { Workflow, StatusCategory } from '~/modules/project-management/services/dto/workflow'
|
|
import { STATUS_CATEGORY_COLOR } from '~/modules/project-management/services/dto/workflow'
|
|
import type { TaskStatusWrite } from '~/modules/project-management/services/dto/task-status'
|
|
import { useWorkflowService } from '~/modules/project-management/services/workflows'
|
|
import { useTaskStatusService } from '~/modules/project-management/services/task-statuses'
|
|
|
|
const { t } = useI18n()
|
|
|
|
const props = defineProps<{
|
|
modelValue: boolean
|
|
item: Workflow | null
|
|
}>()
|
|
|
|
const emit = defineEmits<{
|
|
(e: 'update:modelValue', value: boolean): void
|
|
(e: 'saved'): void
|
|
}>()
|
|
|
|
const isOpen = computed({
|
|
get: () => props.modelValue,
|
|
set: v => emit('update:modelValue', v),
|
|
})
|
|
|
|
const isEditing = computed(() => !!props.item)
|
|
const isSubmitting = ref(false)
|
|
|
|
type StatusForm = {
|
|
id?: number
|
|
label: string
|
|
color: string
|
|
position: number
|
|
isFinal: boolean
|
|
category: StatusCategory
|
|
}
|
|
|
|
const form = reactive<{
|
|
name: string
|
|
isDefault: boolean
|
|
statuses: StatusForm[]
|
|
}>({
|
|
name: '',
|
|
isDefault: false,
|
|
statuses: [],
|
|
})
|
|
|
|
const touched = reactive({ name: false })
|
|
|
|
const categoryOptions: { value: StatusCategory, label: string }[] = [
|
|
{ value: 'todo', label: t('workflows.categories.todo') },
|
|
{ value: 'in_progress', label: t('workflows.categories.in_progress') },
|
|
{ value: 'blocked', label: t('workflows.categories.blocked') },
|
|
{ value: 'review', label: t('workflows.categories.review') },
|
|
{ value: 'done', label: t('workflows.categories.done') },
|
|
]
|
|
|
|
watch(() => props.modelValue, (open) => {
|
|
if (!open) return
|
|
if (props.item) {
|
|
form.name = props.item.name
|
|
form.isDefault = props.item.isDefault
|
|
form.statuses = props.item.statuses.map(s => ({
|
|
id: s.id,
|
|
label: s.label,
|
|
color: s.color,
|
|
position: s.position,
|
|
isFinal: s.isFinal,
|
|
category: s.category,
|
|
}))
|
|
} else {
|
|
form.name = ''
|
|
form.isDefault = false
|
|
form.statuses = []
|
|
}
|
|
touched.name = false
|
|
})
|
|
|
|
watch(() => form.statuses.map(s => s.category), (cats, prev) => {
|
|
if (!prev) return
|
|
cats.forEach((cat, i) => {
|
|
const s = form.statuses[i]
|
|
if (s && cat !== prev[i] && s.color === STATUS_CATEGORY_COLOR[prev[i] as StatusCategory]) {
|
|
s.color = STATUS_CATEGORY_COLOR[cat as StatusCategory]
|
|
}
|
|
})
|
|
})
|
|
|
|
function addStatus() {
|
|
form.statuses.push({
|
|
label: '',
|
|
color: STATUS_CATEGORY_COLOR.todo,
|
|
position: form.statuses.length,
|
|
isFinal: false,
|
|
category: 'todo',
|
|
})
|
|
}
|
|
|
|
function removeStatus(idx: number) {
|
|
form.statuses.splice(idx, 1)
|
|
}
|
|
|
|
const workflowService = useWorkflowService()
|
|
const statusService = useTaskStatusService()
|
|
|
|
async function handleSubmit() {
|
|
touched.name = true
|
|
if (!form.name.trim()) return
|
|
|
|
isSubmitting.value = true
|
|
try {
|
|
if (isEditing.value && props.item) {
|
|
await workflowService.update(props.item.id, {
|
|
name: form.name.trim(),
|
|
isDefault: form.isDefault,
|
|
position: props.item.position,
|
|
})
|
|
await syncStatuses(props.item)
|
|
} else {
|
|
const created = await workflowService.create({
|
|
name: form.name.trim(),
|
|
isDefault: form.isDefault,
|
|
position: 0,
|
|
})
|
|
for (const s of form.statuses) {
|
|
const payload: TaskStatusWrite = {
|
|
label: s.label,
|
|
color: s.color,
|
|
position: s.position,
|
|
isFinal: s.isFinal,
|
|
category: s.category,
|
|
workflow: `/api/workflows/${created.id}`,
|
|
}
|
|
await statusService.create(payload)
|
|
}
|
|
}
|
|
emit('saved')
|
|
isOpen.value = false
|
|
} finally {
|
|
isSubmitting.value = false
|
|
}
|
|
}
|
|
|
|
async function syncStatuses(workflow: Workflow) {
|
|
const existingIds = new Set(workflow.statuses.map(s => s.id))
|
|
const keptIds = new Set<number>()
|
|
|
|
for (const s of form.statuses) {
|
|
if (s.id) {
|
|
keptIds.add(s.id)
|
|
await statusService.update(s.id, {
|
|
label: s.label,
|
|
color: s.color,
|
|
position: s.position,
|
|
isFinal: s.isFinal,
|
|
category: s.category,
|
|
})
|
|
} else {
|
|
await statusService.create({
|
|
label: s.label,
|
|
color: s.color,
|
|
position: s.position,
|
|
isFinal: s.isFinal,
|
|
category: s.category,
|
|
workflow: `/api/workflows/${workflow.id}`,
|
|
})
|
|
}
|
|
}
|
|
|
|
for (const id of existingIds) {
|
|
if (id && !keptIds.has(id)) {
|
|
await statusService.remove(id)
|
|
}
|
|
}
|
|
}
|
|
</script>
|