Matthieu
23809f165e
Tranche 2 of LST-65. Mechanical, behaviour-preserving move of the core
business domain into src/Module/ProjectManagement/. API operations,
securities, uriTemplates and the 38 MCP tool names are all unchanged.
- 10 entities + 2 enums moved to Domain/{Entity,Enum}; intra-module
relations stay concrete, cross-module relations go through contracts
(Project.client -> ClientInterface, Task/TaskDocument users ->
UserInterface).
- 9 repositories split into Domain/Repository interfaces + Doctrine impls,
bound in services.yaml; consumers inject the interfaces. find() kept off
the interfaces (ServiceEntityRepository ?object compat) -> findById().
- State (7), MCP tools (38), controller, CalDavService/RecurrenceCalculator,
3 Doctrine listeners and SwitchWorkflowOutput moved under Infrastructure/.
- doctrine.yaml: ProjectManagement mapping + resolve_target_entities of the
3 module contracts repointed to the module (ClientInterface stays legacy).
- ProjectManagementModule registered (id project-management, 4 RBAC perms,
not re-wired); sidebar my-tasks/projects gated by the module.
- Legacy not-yet-modularised consumers (Mail/Gitea/BookStack, Serializer,
fixtures, tests) swapped to the module FQCN — transitional coupling to be
cleaned in 2.4/2.5/2.6.
159 tests green, mapping valid, no API route regression, cs-fixer clean.
76 lines
2.7 KiB
PHP
76 lines
2.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Unit\Mcp;
|
|
|
|
use App\Mcp\Schema\CoercingSchemaGenerator;
|
|
use App\Module\ProjectManagement\Infrastructure\Mcp\Tool\Task\CreateTaskTool;
|
|
use App\Module\ProjectManagement\Infrastructure\Mcp\Tool\Task\ListTasksTool;
|
|
use PHPUnit\Framework\TestCase;
|
|
use ReflectionMethod;
|
|
|
|
/**
|
|
* @internal
|
|
*/
|
|
class CoercingSchemaGeneratorTest extends TestCase
|
|
{
|
|
private CoercingSchemaGenerator $generator;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
$this->generator = new CoercingSchemaGenerator();
|
|
}
|
|
|
|
public function testNullableIntegerScalarAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(ListTasksTool::class, '__invoke'));
|
|
|
|
// ?int $projectId -> ["null","integer"] relaxed with "string".
|
|
self::assertSame(['null', 'integer', 'string'], $schema['properties']['projectId']['type']);
|
|
}
|
|
|
|
public function testRequiredIntegerScalarAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(ListTasksTool::class, '__invoke'));
|
|
|
|
// int $limit = 100 -> "integer" relaxed to ["integer","string"].
|
|
self::assertSame(['integer', 'string'], $schema['properties']['limit']['type']);
|
|
}
|
|
|
|
public function testBooleanScalarAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// ?bool $syncToCalendar -> ["boolean","null"] relaxed with "string".
|
|
$type = $schema['properties']['syncToCalendar']['type'];
|
|
self::assertContains('boolean', $type);
|
|
self::assertContains('string', $type);
|
|
self::assertContains('null', $type);
|
|
}
|
|
|
|
public function testArrayItemTypeAlsoAcceptsString(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// int[] $tagIds -> items {type: integer} relaxed to {type: [integer, string]}.
|
|
self::assertSame(['integer', 'string'], $schema['properties']['tagIds']['items']['type']);
|
|
}
|
|
|
|
public function testStringScalarIsLeftUntouched(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// string $title stays a plain string (no spurious relaxation).
|
|
self::assertSame('string', $schema['properties']['title']['type']);
|
|
}
|
|
|
|
public function testArrayContainerTypeIsNotRelaxed(): void
|
|
{
|
|
$schema = $this->generator->generate(new ReflectionMethod(CreateTaskTool::class, '__invoke'));
|
|
|
|
// The array container itself must not gain "string".
|
|
self::assertSame(['array', 'null'], $schema['properties']['tagIds']['type']);
|
|
}
|
|
}
|