Compare commits

..

14 Commits

Author SHA1 Message Date
gitea-actions 3daee6b278 chore: bump version to v0.4.54
Auto Tag Develop / tag (push) Successful in 6s
Build & Push Docker Image / build (push) Successful in 19s
2026-06-29 15:42:45 +00:00
matthieu aacf321ef7 Merge pull request 'fix(mail) : stop le spam GlitchTip de sync (UTF7 + dossiers fantômes)' (#34) from fix/mail-sync-folder-not-found-spam into develop
Auto Tag Develop / tag (push) Successful in 9s
Reviewed-on: #34
2026-06-29 15:42:35 +00:00
matthieu 823de28f56 Merge branch 'develop' into fix/mail-sync-folder-not-found-spam
Pull Request — Quality gate / Frontend (build) (pull_request) Successful in 42s
Pull Request — Quality gate / Backend (PHP CS + PHPUnit) (pull_request) Failing after 1m6s
2026-06-29 15:42:29 +00:00
Matthieu 0269bc6d28 fix(mail) : stop le spam GlitchTip de sync (double-encodage UTF7 + dossiers fantômes)
Pull Request — Quality gate / Frontend (build) (pull_request) Successful in 1m20s
Pull Request — Quality gate / Backend (PHP CS + PHPUnit) (pull_request) Successful in 1m44s
Deux causes racines généraient ~170 erreurs/cycle (toutes les 10 min) sur
la prod : "syncFolder[...] listMessages failed: Folder ... not found".

1. Double-encodage UTF7-IMAP : listFolders() stocke le chemin brut UTF7-IMAP,
   mais ImapMailProvider rappelait getFolder($path) qui ré-encode UTF8->UTF7-IMAP
   (webklex Client::getFolderByPath, utf7=false). Le caractère de shift "&" était
   ré-encodé, rendant introuvables les dossiers à accents/specials. Fix :
   getFolder($path, null, utf7: true) partout dans ImapMailProvider.

2. Dossiers fantômes jamais purgés : syncFolderStructure() gardait en DB les
   dossiers disparus du serveur, re-tentés à chaque cycle. Fix :
   syncFolderStructure() retourne le set des chemins présents sur le serveur ;
   doSyncAll() skip silencieusement les dossiers DB absents (conservés en DB
   pour les liens messages/tâches). Fallback historique si listFolders échoue.

Test : testSyncAllSkipsFoldersNoLongerPresentOnServer.
2026-06-29 17:33:59 +02:00
gitea-actions 968f59edc5 chore: bump version to v0.4.53
Auto Tag Develop / tag (push) Successful in 9s
Build & Push Docker Image / build (push) Successful in 2m57s
2026-06-29 09:57:44 +00:00
Matthieu 7001687194 feat(rbac) : gate la Messagerie (onglet layout + page /mail) par mail.access
Auto Tag Develop / tag (push) Successful in 8s
2026-06-29 11:57:36 +02:00
gitea-actions 4b51a3cc05 chore: bump version to v0.4.52
Auto Tag Develop / tag (push) Successful in 9s
Build & Push Docker Image / build (push) Successful in 41s
2026-06-29 09:55:20 +00:00
Matthieu 3b3683c791 feat(rbac) : gate la vue Documents par la permission integration.share.access
Auto Tag Develop / tag (push) Successful in 8s
2026-06-29 11:55:11 +02:00
gitea-actions 79bd47266a chore: bump version to v0.4.51
Auto Tag Develop / tag (push) Successful in 7s
Build & Push Docker Image / build (push) Successful in 25s
2026-06-29 09:36:04 +00:00
matthieu 8aa54c187b Merge pull request 'fix(rbac) : gate les listes Gitea/BookStack par projects.manage' (#33) from fix/rbac-integration-gating into develop
Auto Tag Develop / tag (push) Successful in 9s
2026-06-29 09:35:51 +00:00
Matthieu b61574bad2 fix(rbac) : gate les listes Gitea/BookStack par projects.manage (et non ROLE_USER)
Pull Request — Quality gate / Backend (PHP CS + PHPUnit) (pull_request) Failing after 52s
Pull Request — Quality gate / Frontend (build) (pull_request) Successful in 1m34s
Suite à la revue de sécurité : ROLE_ADMIN était trop strict (les ressources
sœurs sont en ROLE_USER) mais ROLE_USER brut est trop permissif — ces endpoints
listent TOUS les dépôts/étagères visibles par le token d'intégration global, sans
filtrage par utilisateur. Comme ils ne sont consommés que par le ProjectDrawer
(configuration du dépôt/étagère d'un projet), on les gate sur la permission métier
project-management.projects.manage. Les admins conservent l'accès via le bypass
ROLE_ADMIN du PermissionVoter.
2026-06-29 11:34:56 +02:00
Matthieu b8fa1d168d fix(rbac) : ouvre la liste des repos Gitea et des étagères BookStack aux ROLE_USER
GiteaRepository (/gitea/repositories) et BookStackShelf (/bookstack/shelves)
étaient gardés par ROLE_ADMIN alors que toutes leurs ressources sœurs (branches,
pull requests, recherche, liens) sont en ROLE_USER. Un utilisateur non-admin
pouvait donc consommer les sous-ressources mais récupérait un 403 en listant les
dépôts / étagères racines. Aligné sur ROLE_USER (les *Settings et *TestConnection
restent ROLE_ADMIN : configuration réservée à l'admin).
2026-06-29 11:34:56 +02:00
gitea-actions a2334789ae chore: bump version to v0.4.50
Auto Tag Develop / tag (push) Successful in 6s
Build & Push Docker Image / build (push) Successful in 42s
2026-06-29 09:01:08 +00:00
matthieu fc18200d63 Merge pull request 'fix(rbac) : rattache le rôle de base « user » et gate le frontend par permission' (#32) from fix/rbac-default-user-role into develop
Auto Tag Develop / tag (push) Successful in 7s
Reviewed-on: #32
2026-06-29 09:01:02 +00:00
8 changed files with 108 additions and 26 deletions
+1 -1
View File
@@ -1,2 +1,2 @@
parameters: parameters:
app.version: '0.4.49' app.version: '0.4.54'
+5 -1
View File
@@ -23,10 +23,14 @@
> 7. 139 connexions IMAP (une/dossier) → throttling OVH → réutilisation d'1 connexion (`closeConnection()` sur l'interface) + reconnexion ciblée après dossier en erreur. > 7. 139 connexions IMAP (une/dossier) → throttling OVH → réutilisation d'1 connexion (`closeConnection()` sur l'interface) + reconnexion ciblée après dossier en erreur.
> - Contrat front/back réaligné dans `frontend/services/mail.ts` (route `/mail/folders/{path}/messages`, mapping `messages→items`, `fromAddress→fromEmail`, détail plat→imbriqué). > - Contrat front/back réaligné dans `frontend/services/mail.ts` (route `/mail/folders/{path}/messages`, mapping `messages→items`, `fromAddress→fromEmail`, détail plat→imbriqué).
> >
> ### Bugs corrigés 2026-06-29 (spam GlitchTip `syncFolder[...] listMessages failed: Folder ... not found`)
> Deux causes racines, ~170 erreurs/cycle (toutes les 10 min) sur la prod :
> 1. **Double-encodage UTF7-IMAP** : `listFolders()` stocke `$folder->path` = nom **brut UTF7-IMAP** (webklex `Folder::$path`). `ImapMailProvider` appelait ensuite `$client->getFolder($path)` qui ré-encode UTF8→UTF7-IMAP (`Client::getFolderByPath`, `$utf7=false`) → le `&` (shift UTF7) est ré-encodé → dossiers à accents/specials introuvables. **Fix** : `getFolder($path, null, utf7: true)` partout dans `ImapMailProvider` (les paths sont déjà UTF7-IMAP). Résout les ~7 dossiers à encodage spécial qui étaient « skippés ».
> 2. **Dossiers fantômes jamais purgés** : `syncFolderStructure()` gardait en DB les dossiers disparus du serveur (Trash vidé, dossiers RH supprimés) → re-tentés à chaque cycle → `listMessages` → "not found" → log error en boucle. **Fix** : `syncFolderStructure()` retourne le set des chemins **présents sur le serveur** ; `doSyncAll()` skip silencieusement les dossiers DB absents de ce set (gardés en DB pour les liens messages/tâches, mais plus synchronisés). Si `listFolders` échoue (retour `null`), fallback = sync de tous les dossiers connus (comportement historique).
>
> ### Points en suspens / à savoir > ### Points en suspens / à savoir
> - **Mise à jour auto** = cron OS lançant `make mail-sync` toutes les 10 min (cf `docs/mail-cron-setup.md`). **Pas configuré en dev** — lancer à la main. > - **Mise à jour auto** = cron OS lançant `make mail-sync` toutes les 10 min (cf `docs/mail-cron-setup.md`). **Pas configuré en dev** — lancer à la main.
> - **Bouton "Actualiser"** : dispatch async Messenger (`MailSyncRequested → async`). Sans worker `messenger:consume async` qui tourne, les demandes s'empilent sans s'exécuter. En prod : supervisor. En dev : lancer un worker. > - **Bouton "Actualiser"** : dispatch async Messenger (`MailSyncRequested → async`). Sans worker `messenger:consume async` qui tourne, les demandes s'empilent sans s'exécuter. En prod : supervisor. En dev : lancer un worker.
> - **~7 dossiers/139** à encodage spécial (ex: `INBOX/RH/.../SÉBASTIEN` en UTF7-modifié) ou réponses vides sont skippés proprement et réessayés au cycle suivant. Edge case webklex non bloquant.
> - **Dépendance** : `webklex/php-imap ^6.2` tire des paquets Laravel (`illuminate/*` via `carbon ^3`) dans ce projet Symfony — fonctionnel mais à valider en review. > - **Dépendance** : `webklex/php-imap ^6.2` tire des paquets Laravel (`illuminate/*` via `carbon ^3`) dans ce projet Symfony — fonctionnel mais à valider en review.
> - 6 PHPUnit Notices (mocks sans expectations) non bloquantes. > - 6 PHPUnit Notices (mocks sans expectations) non bloquantes.
> >
+8 -5
View File
@@ -60,13 +60,16 @@ const { sections } = useSidebar()
const isEmployee = computed(() => Boolean(auth.user?.isEmployee)) const isEmployee = computed(() => Boolean(auth.user?.isEmployee))
const isMailVisible = computed(() => { const { can } = usePermissions()
const roles: string[] = auth.user?.roles ?? []
return roles.includes('ROLE_USER') || roles.includes('ROLE_ADMIN') // L'onglet Messagerie est rendu côté layout (hors sidebar backend) : il faut donc
}) // reproduire ici le gate de permission. ROLE_ADMIN bypasse via can().
const isMailVisible = computed(() => can('mail.access'))
const { enabled: shareEnabled, ensureLoaded: ensureShareStatus } = useShareStatus() const { enabled: shareEnabled, ensureLoaded: ensureShareStatus } = useShareStatus()
const isDocumentsVisible = computed(() => shareEnabled.value === true) // Documents = explorateur de partage : visible si le module est actif ET la
// permission d'accès au partage est accordée (alignement avec le middleware de page).
const isDocumentsVisible = computed(() => shareEnabled.value === true && can('integration.share.access'))
const currentProjectId = computed(() => { const currentProjectId = computed(() => {
const match = route.path.match(/^\/projects\/(\d+)/) const match = route.path.match(/^\/projects\/(\d+)/)
+1
View File
@@ -6,6 +6,7 @@ const { t } = useI18n()
const router = useRouter() const router = useRouter()
const route = useRoute() const route = useRoute()
definePageMeta({ middleware: ['permission'], permission: 'mail.access' })
useHead({ title: t('mail.title') }) useHead({ title: t('mail.title') })
// ─── Store ──────────────────────────────────────────────────────────────── // ─── Store ────────────────────────────────────────────────────────────────
+1
View File
@@ -85,6 +85,7 @@ import type { Breadcrumb, FileEntry } from '~/modules/integration/services/dto/s
import { useShareService } from '~/modules/integration/services/share' import { useShareService } from '~/modules/integration/services/share'
import { formatFileSize } from '~/utils/format' import { formatFileSize } from '~/utils/format'
definePageMeta({ middleware: ['permission'], permission: 'integration.share.access' })
useHead({ title: 'Documents' }) useHead({ title: 'Documents' })
const { browse, search } = useShareService() const { browse, search } = useShareService()
@@ -64,14 +64,22 @@ final class MailSyncService
} }
} }
public function syncFolderStructure(): void /**
* Synchronise the local folder list with the server.
*
* @return null|array<string, true> the set of folder paths currently present
* on the server, or null when the remote list
* could not be fetched (the caller then falls
* back to syncing every known folder)
*/
public function syncFolderStructure(): ?array
{ {
try { try {
$remoteFolders = $this->provider->listFolders(); $remoteFolders = $this->provider->listFolders();
} catch (MailProviderException $e) { } catch (MailProviderException $e) {
$this->logger->error('syncFolderStructure: listFolders failed: '.$e->getMessage()); $this->logger->error('syncFolderStructure: listFolders failed: '.$e->getMessage());
return; return null;
} }
$remotePathSet = []; $remotePathSet = [];
@@ -95,16 +103,7 @@ final class MailSyncService
$this->entityManager->flush(); $this->entityManager->flush();
$allDbFolders = $this->folderRepository->findAllOrderedByPath(); return $remotePathSet;
foreach ($allDbFolders as $dbFolder) {
if (!isset($remotePathSet[$dbFolder->getPath()])) {
$this->logger->warning(sprintf(
'syncFolderStructure: folder "%s" no longer exists on server — keeping in DB for safety',
$dbFolder->getPath()
));
}
}
} }
public function syncFolder(MailFolder $folder): MailSyncReport public function syncFolder(MailFolder $folder): MailSyncReport
@@ -259,7 +258,7 @@ final class MailSyncService
private function doSyncAll(DateTimeImmutable $startedAt): MailSyncReport private function doSyncAll(DateTimeImmutable $startedAt): MailSyncReport
{ {
$this->syncFolderStructure(); $remotePathSet = $this->syncFolderStructure();
$totalCreated = 0; $totalCreated = 0;
$totalUpdated = 0; $totalUpdated = 0;
@@ -270,6 +269,13 @@ final class MailSyncService
$folders = $this->folderRepository->findAllOrderedByPath(); $folders = $this->folderRepository->findAllOrderedByPath();
foreach ($folders as $folder) { foreach ($folders as $folder) {
// Skip folders that no longer exist on the server. They are kept in
// the DB (linked messages and tasks still reference them) but retrying
// listMessages every cycle only floods the logs with "Folder not found".
if (null !== $remotePathSet && !isset($remotePathSet[$folder->getPath()])) {
continue;
}
try { try {
$report = $this->syncFolder($folder); $report = $this->syncFolder($folder);
$totalCreated += $report->createdCount; $totalCreated += $report->createdCount;
@@ -103,7 +103,11 @@ final class ImapMailProvider implements MailProviderInterface
$client = $this->getClient(); $client = $this->getClient();
try { try {
$folder = $client->getFolder($folderPath); // Folder paths are stored exactly as the server returns them (raw
// UTF7-IMAP). Pass utf7: true so webklex matches them as-is instead of
// re-encoding UTF8 -> UTF7-IMAP, which double-encodes the "&" shift
// character and makes folders with accents/specials unresolvable.
$folder = $client->getFolder($folderPath, null, true);
if (null === $folder) { if (null === $folder) {
throw MailProviderException::operationFailed('listMessages', sprintf('Folder %s not found', $folderPath)); throw MailProviderException::operationFailed('listMessages', sprintf('Folder %s not found', $folderPath));
} }
@@ -138,7 +142,7 @@ final class ImapMailProvider implements MailProviderInterface
$client = $this->getClient(); $client = $this->getClient();
try { try {
$folder = $client->getFolder($folderPath); $folder = $client->getFolder($folderPath, null, true);
if (null === $folder) { if (null === $folder) {
throw MailProviderException::operationFailed('fetchMessage', sprintf('Folder %s not found', $folderPath)); throw MailProviderException::operationFailed('fetchMessage', sprintf('Folder %s not found', $folderPath));
} }
@@ -183,7 +187,7 @@ final class ImapMailProvider implements MailProviderInterface
$client = $this->getClient(); $client = $this->getClient();
try { try {
$folder = $client->getFolder($folderPath); $folder = $client->getFolder($folderPath, null, true);
if (null === $folder) { if (null === $folder) {
throw MailProviderException::operationFailed('markRead', sprintf('Folder %s not found', $folderPath)); throw MailProviderException::operationFailed('markRead', sprintf('Folder %s not found', $folderPath));
} }
@@ -213,7 +217,7 @@ final class ImapMailProvider implements MailProviderInterface
$client = $this->getClient(); $client = $this->getClient();
try { try {
$folder = $client->getFolder($folderPath); $folder = $client->getFolder($folderPath, null, true);
if (null === $folder) { if (null === $folder) {
throw MailProviderException::operationFailed('markFlagged', sprintf('Folder %s not found', $folderPath)); throw MailProviderException::operationFailed('markFlagged', sprintf('Folder %s not found', $folderPath));
} }
@@ -243,7 +247,7 @@ final class ImapMailProvider implements MailProviderInterface
$client = $this->getClient(); $client = $this->getClient();
try { try {
$folder = $client->getFolder($folderPath); $folder = $client->getFolder($folderPath, null, true);
if (null === $folder) { if (null === $folder) {
throw MailProviderException::operationFailed('moveMessage', sprintf('Folder %s not found', $folderPath)); throw MailProviderException::operationFailed('moveMessage', sprintf('Folder %s not found', $folderPath));
} }
@@ -269,7 +273,7 @@ final class ImapMailProvider implements MailProviderInterface
$client = $this->getClient(); $client = $this->getClient();
try { try {
$folder = $client->getFolder($folderPath); $folder = $client->getFolder($folderPath, null, true);
if (null === $folder) { if (null === $folder) {
throw MailProviderException::operationFailed('fetchAttachment', sprintf('Folder %s not found', $folderPath)); throw MailProviderException::operationFailed('fetchAttachment', sprintf('Folder %s not found', $folderPath));
} }
@@ -132,6 +132,69 @@ class MailSyncServiceTest extends TestCase
$service->syncFolderStructure(); $service->syncFolderStructure();
} }
public function testSyncAllSkipsFoldersNoLongerPresentOnServer(): void
{
$config = new MailConfiguration();
$config->setEnabled(true);
$configRepo = $this->createMock(MailConfigurationRepositoryInterface::class);
$configRepo->method('findSingleton')->willReturn($config);
// The server only exposes INBOX; "Trash/STALE" was deleted remotely but
// still lingers in the DB.
$inboxDto = new MailFolderDto(
path: 'INBOX',
displayName: 'Inbox',
parentPath: null,
unreadCount: 0,
totalCount: 0,
);
$inboxFolder = new MailFolder();
$inboxFolder->setPath('INBOX');
$staleFolder = new MailFolder();
$staleFolder->setPath('Trash/STALE');
$provider = $this->createMock(MailProviderInterface::class);
$provider->method('listFolders')->willReturn([$inboxDto]);
// listMessages must only ever be called for INBOX, never the stale folder.
$provider->expects(self::once())
->method('listMessages')
->with('INBOX', 5000, 0)
->willReturn([])
;
$folderRepo = $this->createMock(MailFolderRepositoryInterface::class);
$folderRepo->method('findByPath')->willReturn($inboxFolder);
$folderRepo->method('findAllOrderedByPath')->willReturn([$inboxFolder, $staleFolder]);
$messageRepo = $this->createMock(MailMessageRepositoryInterface::class);
$messageRepo->method('findMaxUidInFolder')->willReturn(0);
$messageRepo->method('findAllUidsByFolder')->willReturn([]);
$messageRepo->method('findLastNByFolder')->willReturn([]);
$em = $this->createMock(EntityManagerInterface::class);
$em->method('isOpen')->willReturn(true);
$lockFactory = $this->makeLockFactory();
$service = new MailSyncService(
provider: $provider,
configRepository: $configRepo,
folderRepository: $folderRepo,
messageRepository: $messageRepo,
entityManager: $em,
lockFactory: $lockFactory,
logger: new NullLogger(),
managerRegistry: $this->createMock(ManagerRegistry::class),
);
$report = $service->syncAll();
self::assertSame(1, $report->foldersScanned);
self::assertSame([], $report->errors);
}
public function testSyncFolderAbortsSuppressionWhenOver50Percent(): void public function testSyncFolderAbortsSuppressionWhenOver50Percent(): void
{ {
$config = new MailConfiguration(); $config = new MailConfiguration();