Compare commits
14 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 3daee6b278 | |||
| aacf321ef7 | |||
| 823de28f56 | |||
| 0269bc6d28 | |||
| 968f59edc5 | |||
| 7001687194 | |||
| 4b51a3cc05 | |||
| 3b3683c791 | |||
| 79bd47266a | |||
| 8aa54c187b | |||
| b61574bad2 | |||
| b8fa1d168d | |||
| a2334789ae | |||
| fc18200d63 |
+1
-1
@@ -1,2 +1,2 @@
|
|||||||
parameters:
|
parameters:
|
||||||
app.version: '0.4.49'
|
app.version: '0.4.54'
|
||||||
|
|||||||
@@ -23,10 +23,14 @@
|
|||||||
> 7. 139 connexions IMAP (une/dossier) → throttling OVH → réutilisation d'1 connexion (`closeConnection()` sur l'interface) + reconnexion ciblée après dossier en erreur.
|
> 7. 139 connexions IMAP (une/dossier) → throttling OVH → réutilisation d'1 connexion (`closeConnection()` sur l'interface) + reconnexion ciblée après dossier en erreur.
|
||||||
> - Contrat front/back réaligné dans `frontend/services/mail.ts` (route `/mail/folders/{path}/messages`, mapping `messages→items`, `fromAddress→fromEmail`, détail plat→imbriqué).
|
> - Contrat front/back réaligné dans `frontend/services/mail.ts` (route `/mail/folders/{path}/messages`, mapping `messages→items`, `fromAddress→fromEmail`, détail plat→imbriqué).
|
||||||
>
|
>
|
||||||
|
> ### Bugs corrigés 2026-06-29 (spam GlitchTip `syncFolder[...] listMessages failed: Folder ... not found`)
|
||||||
|
> Deux causes racines, ~170 erreurs/cycle (toutes les 10 min) sur la prod :
|
||||||
|
> 1. **Double-encodage UTF7-IMAP** : `listFolders()` stocke `$folder->path` = nom **brut UTF7-IMAP** (webklex `Folder::$path`). `ImapMailProvider` appelait ensuite `$client->getFolder($path)` qui ré-encode UTF8→UTF7-IMAP (`Client::getFolderByPath`, `$utf7=false`) → le `&` (shift UTF7) est ré-encodé → dossiers à accents/specials introuvables. **Fix** : `getFolder($path, null, utf7: true)` partout dans `ImapMailProvider` (les paths sont déjà UTF7-IMAP). Résout les ~7 dossiers à encodage spécial qui étaient « skippés ».
|
||||||
|
> 2. **Dossiers fantômes jamais purgés** : `syncFolderStructure()` gardait en DB les dossiers disparus du serveur (Trash vidé, dossiers RH supprimés) → re-tentés à chaque cycle → `listMessages` → "not found" → log error en boucle. **Fix** : `syncFolderStructure()` retourne le set des chemins **présents sur le serveur** ; `doSyncAll()` skip silencieusement les dossiers DB absents de ce set (gardés en DB pour les liens messages/tâches, mais plus synchronisés). Si `listFolders` échoue (retour `null`), fallback = sync de tous les dossiers connus (comportement historique).
|
||||||
|
>
|
||||||
> ### Points en suspens / à savoir
|
> ### Points en suspens / à savoir
|
||||||
> - **Mise à jour auto** = cron OS lançant `make mail-sync` toutes les 10 min (cf `docs/mail-cron-setup.md`). **Pas configuré en dev** — lancer à la main.
|
> - **Mise à jour auto** = cron OS lançant `make mail-sync` toutes les 10 min (cf `docs/mail-cron-setup.md`). **Pas configuré en dev** — lancer à la main.
|
||||||
> - **Bouton "Actualiser"** : dispatch async Messenger (`MailSyncRequested → async`). Sans worker `messenger:consume async` qui tourne, les demandes s'empilent sans s'exécuter. En prod : supervisor. En dev : lancer un worker.
|
> - **Bouton "Actualiser"** : dispatch async Messenger (`MailSyncRequested → async`). Sans worker `messenger:consume async` qui tourne, les demandes s'empilent sans s'exécuter. En prod : supervisor. En dev : lancer un worker.
|
||||||
> - **~7 dossiers/139** à encodage spécial (ex: `INBOX/RH/.../SÉBASTIEN` en UTF7-modifié) ou réponses vides sont skippés proprement et réessayés au cycle suivant. Edge case webklex non bloquant.
|
|
||||||
> - **Dépendance** : `webklex/php-imap ^6.2` tire des paquets Laravel (`illuminate/*` via `carbon ^3`) dans ce projet Symfony — fonctionnel mais à valider en review.
|
> - **Dépendance** : `webklex/php-imap ^6.2` tire des paquets Laravel (`illuminate/*` via `carbon ^3`) dans ce projet Symfony — fonctionnel mais à valider en review.
|
||||||
> - 6 PHPUnit Notices (mocks sans expectations) non bloquantes.
|
> - 6 PHPUnit Notices (mocks sans expectations) non bloquantes.
|
||||||
>
|
>
|
||||||
|
|||||||
@@ -60,13 +60,16 @@ const { sections } = useSidebar()
|
|||||||
|
|
||||||
const isEmployee = computed(() => Boolean(auth.user?.isEmployee))
|
const isEmployee = computed(() => Boolean(auth.user?.isEmployee))
|
||||||
|
|
||||||
const isMailVisible = computed(() => {
|
const { can } = usePermissions()
|
||||||
const roles: string[] = auth.user?.roles ?? []
|
|
||||||
return roles.includes('ROLE_USER') || roles.includes('ROLE_ADMIN')
|
// L'onglet Messagerie est rendu côté layout (hors sidebar backend) : il faut donc
|
||||||
})
|
// reproduire ici le gate de permission. ROLE_ADMIN bypasse via can().
|
||||||
|
const isMailVisible = computed(() => can('mail.access'))
|
||||||
|
|
||||||
const { enabled: shareEnabled, ensureLoaded: ensureShareStatus } = useShareStatus()
|
const { enabled: shareEnabled, ensureLoaded: ensureShareStatus } = useShareStatus()
|
||||||
const isDocumentsVisible = computed(() => shareEnabled.value === true)
|
// Documents = explorateur de partage : visible si le module est actif ET la
|
||||||
|
// permission d'accès au partage est accordée (alignement avec le middleware de page).
|
||||||
|
const isDocumentsVisible = computed(() => shareEnabled.value === true && can('integration.share.access'))
|
||||||
|
|
||||||
const currentProjectId = computed(() => {
|
const currentProjectId = computed(() => {
|
||||||
const match = route.path.match(/^\/projects\/(\d+)/)
|
const match = route.path.match(/^\/projects\/(\d+)/)
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ const { t } = useI18n()
|
|||||||
const router = useRouter()
|
const router = useRouter()
|
||||||
const route = useRoute()
|
const route = useRoute()
|
||||||
|
|
||||||
|
definePageMeta({ middleware: ['permission'], permission: 'mail.access' })
|
||||||
useHead({ title: t('mail.title') })
|
useHead({ title: t('mail.title') })
|
||||||
|
|
||||||
// ─── Store ────────────────────────────────────────────────────────────────
|
// ─── Store ────────────────────────────────────────────────────────────────
|
||||||
|
|||||||
@@ -85,6 +85,7 @@ import type { Breadcrumb, FileEntry } from '~/modules/integration/services/dto/s
|
|||||||
import { useShareService } from '~/modules/integration/services/share'
|
import { useShareService } from '~/modules/integration/services/share'
|
||||||
import { formatFileSize } from '~/utils/format'
|
import { formatFileSize } from '~/utils/format'
|
||||||
|
|
||||||
|
definePageMeta({ middleware: ['permission'], permission: 'integration.share.access' })
|
||||||
useHead({ title: 'Documents' })
|
useHead({ title: 'Documents' })
|
||||||
|
|
||||||
const { browse, search } = useShareService()
|
const { browse, search } = useShareService()
|
||||||
|
|||||||
@@ -64,14 +64,22 @@ final class MailSyncService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
public function syncFolderStructure(): void
|
/**
|
||||||
|
* Synchronise the local folder list with the server.
|
||||||
|
*
|
||||||
|
* @return null|array<string, true> the set of folder paths currently present
|
||||||
|
* on the server, or null when the remote list
|
||||||
|
* could not be fetched (the caller then falls
|
||||||
|
* back to syncing every known folder)
|
||||||
|
*/
|
||||||
|
public function syncFolderStructure(): ?array
|
||||||
{
|
{
|
||||||
try {
|
try {
|
||||||
$remoteFolders = $this->provider->listFolders();
|
$remoteFolders = $this->provider->listFolders();
|
||||||
} catch (MailProviderException $e) {
|
} catch (MailProviderException $e) {
|
||||||
$this->logger->error('syncFolderStructure: listFolders failed: '.$e->getMessage());
|
$this->logger->error('syncFolderStructure: listFolders failed: '.$e->getMessage());
|
||||||
|
|
||||||
return;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
$remotePathSet = [];
|
$remotePathSet = [];
|
||||||
@@ -95,16 +103,7 @@ final class MailSyncService
|
|||||||
|
|
||||||
$this->entityManager->flush();
|
$this->entityManager->flush();
|
||||||
|
|
||||||
$allDbFolders = $this->folderRepository->findAllOrderedByPath();
|
return $remotePathSet;
|
||||||
|
|
||||||
foreach ($allDbFolders as $dbFolder) {
|
|
||||||
if (!isset($remotePathSet[$dbFolder->getPath()])) {
|
|
||||||
$this->logger->warning(sprintf(
|
|
||||||
'syncFolderStructure: folder "%s" no longer exists on server — keeping in DB for safety',
|
|
||||||
$dbFolder->getPath()
|
|
||||||
));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
public function syncFolder(MailFolder $folder): MailSyncReport
|
public function syncFolder(MailFolder $folder): MailSyncReport
|
||||||
@@ -259,7 +258,7 @@ final class MailSyncService
|
|||||||
|
|
||||||
private function doSyncAll(DateTimeImmutable $startedAt): MailSyncReport
|
private function doSyncAll(DateTimeImmutable $startedAt): MailSyncReport
|
||||||
{
|
{
|
||||||
$this->syncFolderStructure();
|
$remotePathSet = $this->syncFolderStructure();
|
||||||
|
|
||||||
$totalCreated = 0;
|
$totalCreated = 0;
|
||||||
$totalUpdated = 0;
|
$totalUpdated = 0;
|
||||||
@@ -270,6 +269,13 @@ final class MailSyncService
|
|||||||
$folders = $this->folderRepository->findAllOrderedByPath();
|
$folders = $this->folderRepository->findAllOrderedByPath();
|
||||||
|
|
||||||
foreach ($folders as $folder) {
|
foreach ($folders as $folder) {
|
||||||
|
// Skip folders that no longer exist on the server. They are kept in
|
||||||
|
// the DB (linked messages and tasks still reference them) but retrying
|
||||||
|
// listMessages every cycle only floods the logs with "Folder not found".
|
||||||
|
if (null !== $remotePathSet && !isset($remotePathSet[$folder->getPath()])) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$report = $this->syncFolder($folder);
|
$report = $this->syncFolder($folder);
|
||||||
$totalCreated += $report->createdCount;
|
$totalCreated += $report->createdCount;
|
||||||
|
|||||||
@@ -103,7 +103,11 @@ final class ImapMailProvider implements MailProviderInterface
|
|||||||
$client = $this->getClient();
|
$client = $this->getClient();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$folder = $client->getFolder($folderPath);
|
// Folder paths are stored exactly as the server returns them (raw
|
||||||
|
// UTF7-IMAP). Pass utf7: true so webklex matches them as-is instead of
|
||||||
|
// re-encoding UTF8 -> UTF7-IMAP, which double-encodes the "&" shift
|
||||||
|
// character and makes folders with accents/specials unresolvable.
|
||||||
|
$folder = $client->getFolder($folderPath, null, true);
|
||||||
if (null === $folder) {
|
if (null === $folder) {
|
||||||
throw MailProviderException::operationFailed('listMessages', sprintf('Folder %s not found', $folderPath));
|
throw MailProviderException::operationFailed('listMessages', sprintf('Folder %s not found', $folderPath));
|
||||||
}
|
}
|
||||||
@@ -138,7 +142,7 @@ final class ImapMailProvider implements MailProviderInterface
|
|||||||
$client = $this->getClient();
|
$client = $this->getClient();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$folder = $client->getFolder($folderPath);
|
$folder = $client->getFolder($folderPath, null, true);
|
||||||
if (null === $folder) {
|
if (null === $folder) {
|
||||||
throw MailProviderException::operationFailed('fetchMessage', sprintf('Folder %s not found', $folderPath));
|
throw MailProviderException::operationFailed('fetchMessage', sprintf('Folder %s not found', $folderPath));
|
||||||
}
|
}
|
||||||
@@ -183,7 +187,7 @@ final class ImapMailProvider implements MailProviderInterface
|
|||||||
$client = $this->getClient();
|
$client = $this->getClient();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$folder = $client->getFolder($folderPath);
|
$folder = $client->getFolder($folderPath, null, true);
|
||||||
if (null === $folder) {
|
if (null === $folder) {
|
||||||
throw MailProviderException::operationFailed('markRead', sprintf('Folder %s not found', $folderPath));
|
throw MailProviderException::operationFailed('markRead', sprintf('Folder %s not found', $folderPath));
|
||||||
}
|
}
|
||||||
@@ -213,7 +217,7 @@ final class ImapMailProvider implements MailProviderInterface
|
|||||||
$client = $this->getClient();
|
$client = $this->getClient();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$folder = $client->getFolder($folderPath);
|
$folder = $client->getFolder($folderPath, null, true);
|
||||||
if (null === $folder) {
|
if (null === $folder) {
|
||||||
throw MailProviderException::operationFailed('markFlagged', sprintf('Folder %s not found', $folderPath));
|
throw MailProviderException::operationFailed('markFlagged', sprintf('Folder %s not found', $folderPath));
|
||||||
}
|
}
|
||||||
@@ -243,7 +247,7 @@ final class ImapMailProvider implements MailProviderInterface
|
|||||||
$client = $this->getClient();
|
$client = $this->getClient();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$folder = $client->getFolder($folderPath);
|
$folder = $client->getFolder($folderPath, null, true);
|
||||||
if (null === $folder) {
|
if (null === $folder) {
|
||||||
throw MailProviderException::operationFailed('moveMessage', sprintf('Folder %s not found', $folderPath));
|
throw MailProviderException::operationFailed('moveMessage', sprintf('Folder %s not found', $folderPath));
|
||||||
}
|
}
|
||||||
@@ -269,7 +273,7 @@ final class ImapMailProvider implements MailProviderInterface
|
|||||||
$client = $this->getClient();
|
$client = $this->getClient();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
$folder = $client->getFolder($folderPath);
|
$folder = $client->getFolder($folderPath, null, true);
|
||||||
if (null === $folder) {
|
if (null === $folder) {
|
||||||
throw MailProviderException::operationFailed('fetchAttachment', sprintf('Folder %s not found', $folderPath));
|
throw MailProviderException::operationFailed('fetchAttachment', sprintf('Folder %s not found', $folderPath));
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -132,6 +132,69 @@ class MailSyncServiceTest extends TestCase
|
|||||||
$service->syncFolderStructure();
|
$service->syncFolderStructure();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function testSyncAllSkipsFoldersNoLongerPresentOnServer(): void
|
||||||
|
{
|
||||||
|
$config = new MailConfiguration();
|
||||||
|
$config->setEnabled(true);
|
||||||
|
|
||||||
|
$configRepo = $this->createMock(MailConfigurationRepositoryInterface::class);
|
||||||
|
$configRepo->method('findSingleton')->willReturn($config);
|
||||||
|
|
||||||
|
// The server only exposes INBOX; "Trash/STALE" was deleted remotely but
|
||||||
|
// still lingers in the DB.
|
||||||
|
$inboxDto = new MailFolderDto(
|
||||||
|
path: 'INBOX',
|
||||||
|
displayName: 'Inbox',
|
||||||
|
parentPath: null,
|
||||||
|
unreadCount: 0,
|
||||||
|
totalCount: 0,
|
||||||
|
);
|
||||||
|
|
||||||
|
$inboxFolder = new MailFolder();
|
||||||
|
$inboxFolder->setPath('INBOX');
|
||||||
|
|
||||||
|
$staleFolder = new MailFolder();
|
||||||
|
$staleFolder->setPath('Trash/STALE');
|
||||||
|
|
||||||
|
$provider = $this->createMock(MailProviderInterface::class);
|
||||||
|
$provider->method('listFolders')->willReturn([$inboxDto]);
|
||||||
|
// listMessages must only ever be called for INBOX, never the stale folder.
|
||||||
|
$provider->expects(self::once())
|
||||||
|
->method('listMessages')
|
||||||
|
->with('INBOX', 5000, 0)
|
||||||
|
->willReturn([])
|
||||||
|
;
|
||||||
|
|
||||||
|
$folderRepo = $this->createMock(MailFolderRepositoryInterface::class);
|
||||||
|
$folderRepo->method('findByPath')->willReturn($inboxFolder);
|
||||||
|
$folderRepo->method('findAllOrderedByPath')->willReturn([$inboxFolder, $staleFolder]);
|
||||||
|
|
||||||
|
$messageRepo = $this->createMock(MailMessageRepositoryInterface::class);
|
||||||
|
$messageRepo->method('findMaxUidInFolder')->willReturn(0);
|
||||||
|
$messageRepo->method('findAllUidsByFolder')->willReturn([]);
|
||||||
|
$messageRepo->method('findLastNByFolder')->willReturn([]);
|
||||||
|
|
||||||
|
$em = $this->createMock(EntityManagerInterface::class);
|
||||||
|
$em->method('isOpen')->willReturn(true);
|
||||||
|
$lockFactory = $this->makeLockFactory();
|
||||||
|
|
||||||
|
$service = new MailSyncService(
|
||||||
|
provider: $provider,
|
||||||
|
configRepository: $configRepo,
|
||||||
|
folderRepository: $folderRepo,
|
||||||
|
messageRepository: $messageRepo,
|
||||||
|
entityManager: $em,
|
||||||
|
lockFactory: $lockFactory,
|
||||||
|
logger: new NullLogger(),
|
||||||
|
managerRegistry: $this->createMock(ManagerRegistry::class),
|
||||||
|
);
|
||||||
|
|
||||||
|
$report = $service->syncAll();
|
||||||
|
|
||||||
|
self::assertSame(1, $report->foldersScanned);
|
||||||
|
self::assertSame([], $report->errors);
|
||||||
|
}
|
||||||
|
|
||||||
public function testSyncFolderAbortsSuppressionWhenOver50Percent(): void
|
public function testSyncFolderAbortsSuppressionWhenOver50Percent(): void
|
||||||
{
|
{
|
||||||
$config = new MailConfiguration();
|
$config = new MailConfiguration();
|
||||||
|
|||||||
Reference in New Issue
Block a user