fix(security) : add role checks on Gitea API resources and all MCP tools

- GiteaBranch, GiteaBranchName, GiteaPullRequest: require ROLE_USER
- All 22 MCP tools: require ROLE_USER (ROLE_ADMIN for users/clients listing)

Tickets: T-002, T-007

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

src/Mcp/Tool/Task/CreateTaskTool.php

@@ -17,6 +17,8 @@ use App\Repository\UserRepository;
 use Doctrine\ORM\EntityManagerInterface;
 use InvalidArgumentException;
 use Mcp\Capability\Attribute\McpTool;
+use Symfony\Bundle\SecurityBundle\Security;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 
 use function sprintf;
 
@@ -33,6 +35,7 @@ class CreateTaskTool
         private readonly TaskGroupRepository $taskGroupRepository,
         private readonly TaskTagRepository $taskTagRepository,
         private readonly UserRepository $userRepository,
+        private readonly Security $security,
     ) {}
 
     public function __invoke(
@@ -46,6 +49,10 @@ class CreateTaskTool
         ?int $groupId = null,
         ?array $tagIds = null,
     ): string {
+        if (!$this->security->isGranted('ROLE_USER')) {
+            throw new AccessDeniedException('Access denied: ROLE_USER required.');
+        }
+
         $project = $this->projectRepository->find($projectId);
         if (null === $project) {
             throw new InvalidArgumentException(sprintf('Project with ID %d not found.', $projectId));
@@ -54,7 +61,6 @@ class CreateTaskTool
         $task = new Task();
         $task->setProject($project);
         $task->setTitle($title);
-        $task->setNumber($this->taskRepository->findMaxNumberByProjectForUpdate($project) + 1);
 
         if (null !== $description) {
             $task->setDescription($description);
@@ -104,8 +110,11 @@ class CreateTaskTool
             }
         }
 
-        $this->entityManager->persist($task);
-        $this->entityManager->flush();
+        $this->entityManager->wrapInTransaction(function () use ($task, $project): void {
+            $task->setNumber($this->taskRepository->findMaxNumberByProjectForUpdate($project) + 1);
+            $this->entityManager->persist($task);
+            $this->entityManager->flush();
+        });
 
         return json_encode([
             'id'          => $task->getId(),

src/Mcp/Tool/Task/DeleteTaskTool.php

@@ -8,6 +8,8 @@ use App\Repository\TaskRepository;
 use Doctrine\ORM\EntityManagerInterface;
 use InvalidArgumentException;
 use Mcp\Capability\Attribute\McpTool;
+use Symfony\Bundle\SecurityBundle\Security;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 
 use function sprintf;
 
@@ -17,10 +19,15 @@ class DeleteTaskTool
     public function __construct(
         private readonly TaskRepository $taskRepository,
         private readonly EntityManagerInterface $entityManager,
+        private readonly Security $security,
     ) {}
 
     public function __invoke(int $id): string
     {
+        if (!$this->security->isGranted('ROLE_USER')) {
+            throw new AccessDeniedException('Access denied: ROLE_USER required.');
+        }
+
         $task = $this->taskRepository->find($id);
 
         if (null === $task) {

src/Mcp/Tool/Task/GetTaskTool.php

@@ -8,6 +8,8 @@ use App\Mcp\Tool\Serializer;
 use App\Repository\TaskRepository;
 use InvalidArgumentException;
 use Mcp\Capability\Attribute\McpTool;
+use Symfony\Bundle\SecurityBundle\Security;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 
 use function sprintf;
 
@@ -16,10 +18,15 @@ class GetTaskTool
 {
     public function __construct(
         private readonly TaskRepository $taskRepository,
+        private readonly Security $security,
     ) {}
 
     public function __invoke(int $id): string
     {
+        if (!$this->security->isGranted('ROLE_USER')) {
+            throw new AccessDeniedException('Access denied: ROLE_USER required.');
+        }
+
         $task = $this->taskRepository->find($id);
 
         if (null === $task) {

src/Mcp/Tool/Task/ListTasksTool.php

@@ -7,12 +7,15 @@ namespace App\Mcp\Tool\Task;
 use App\Mcp\Tool\Serializer;
 use App\Repository\TaskRepository;
 use Mcp\Capability\Attribute\McpTool;
+use Symfony\Bundle\SecurityBundle\Security;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 
 #[McpTool(name: 'list-tasks', description: 'List tasks with optional filters by project, status, assignee, priority, group, tags, and archive state. Returns max 100 results by default, use filters to narrow down.')]
 class ListTasksTool
 {
     public function __construct(
         private readonly TaskRepository $taskRepository,
+        private readonly Security $security,
     ) {}
 
     public function __invoke(
@@ -25,6 +28,10 @@ class ListTasksTool
         bool $archived = false,
         int $limit = 100,
     ): string {
+        if (!$this->security->isGranted('ROLE_USER')) {
+            throw new AccessDeniedException('Access denied: ROLE_USER required.');
+        }
+
         $limit = min($limit, 200);
 
         $qb = $this->taskRepository->createQueryBuilder('t')

src/Mcp/Tool/Task/UpdateTaskTool.php

@@ -15,6 +15,8 @@ use App\Repository\UserRepository;
 use Doctrine\ORM\EntityManagerInterface;
 use InvalidArgumentException;
 use Mcp\Capability\Attribute\McpTool;
+use Symfony\Bundle\SecurityBundle\Security;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 
 use function sprintf;
 
@@ -30,6 +32,7 @@ class UpdateTaskTool
         private readonly TaskGroupRepository $taskGroupRepository,
         private readonly TaskTagRepository $taskTagRepository,
         private readonly UserRepository $userRepository,
+        private readonly Security $security,
     ) {}
 
     public function __invoke(
@@ -44,6 +47,10 @@ class UpdateTaskTool
         ?array $tagIds = null,
         ?bool $archived = null,
     ): string {
+        if (!$this->security->isGranted('ROLE_USER')) {
+            throw new AccessDeniedException('Access denied: ROLE_USER required.');
+        }
+
         $task = $this->taskRepository->find($id);
 
         if (null === $task) {