Migration modular monolith DDD (0.1 → 3.3) (#17)
Auto Tag Develop / tag (push) Successful in 9s
Auto Tag Develop / tag (push) Successful in 9s
## Migration modular monolith DDD — Lesstime (0.1 → 3.3) Cette MR regroupe l'intégralité de la refonte en monolithe modulaire (strangler progressif, additif). Elle remplace les MR stackées de Phase 1 (#12–#16), désormais incluses ici. **Ne pas merger avant validation fonctionnelle** : branche destinée à être testée telle quelle. ### Périmètre — 9 modules sous `src/Module/` | Phase | Module | Contenu | |------|--------|---------| | 0.1 | (socle) | infrastructure modulaire, `ModuleInterface`, mapping Doctrine par module | | 0.2 | (socle front) | auto-détection des layers Nuxt sous `frontend/modules/*` | | 1.1 | **Core** | Identité (User/Auth), Notifications, Notifier | | 1.2 | Core | RBAC fin (permissions `module.resource.action`, sidebar gated) | | 1.3 | Core | Audit log (`#[Auditable]`, listener, provider DBAL) | | 2.1 | **TimeTracking** | TimeEntry + MCP + export | | 2.2 | **ProjectManagement** | cœur métier Projets/Tâches + 38 MCP tools | | 2.3 | **Absence** | demandes, soldes, policies, justificatifs | | 2.4 | **Directory** | Clients (migrés) + **Prospects** (nouveau, conversion → Client) | | 2.5 | **Mail** | intégration IMAP OVH + liens tâches | | 2.6 | **Integration** | Gitea / BookStack / Zimbra / Share | | 3.1 | **Reporting** | rapports transverses (DBAL read-only, 0 import inter-module) | | 3.2 | **ClientPortal** | portail client (ROLE_CLIENT cloisonné, tickets, notifications) | | 3.3 | (finition) | nettoyage legacy — `src/Entity` vide, app 100% modulaire | ### Architecture - Découplage inter-modules par **contrats** (`UserInterface`, `ProjectInterface`, `TaskInterface`, `TaskTagInterface`, `ClientInterface`, `ClientTicketInterface`, `LeaveProfileInterface`) + `resolve_target_entities` 100% modulaire (aucune cible legacy). - Repositories : interface `Domain/Repository` + implémentation `Infrastructure/Doctrine`, bindées. - Reporting en DBAL read-only pur (aucun import d'entité d'un autre module). - Chaque migration de module : déplacement à comportement préservé (API publique et noms d'outils MCP inchangés), migrations **additives** uniquement (zéro destructif). ### Sécurité - ROLE_CLIENT cloisonné : un utilisateur client n'accède qu'à `/portal` et à ses propres tickets (filtrés par `allowedProjects`), interdit sur toute l'API interne. - Correctif : interdiction pour un client de créer un lien vers le partage SMB (upload uniquement). ### QA non-régression (branche reconstruite from scratch) - Migrations from scratch + fixtures : OK. - Compilation dev + prod : OK. - **180 tests PHPUnit verts**, php-cs-fixer clean, ~96 routes, **66 outils MCP** tous sous `App\Module\*`. - Smoke test runtime multi-rôles (admin / ROLE_USER / ROLE_CLIENT) : 44 vérifications HTTP, **0 écart**, cloisonnement client étanche. - Build Nuxt OK, 9 layers, 0 import legacy résiduel. ### Points à arbitrer (hors périmètre de cette migration) - Durcissement MCP/IDOR pré-existant (`userId` explicite sans scoping sur certains tools TimeTracking/Absence/TaskDocument) — ticket dédié recommandé. - Validation fonctionnelle de **Prospect** et **ClientPortal** (conçus depuis les specs disque). - **Harmonisation visuelle Malio finale** (3.3) — finition esthétique inter-modules laissée au PO. --- ## ⚠️ Déploiement / migration des données — à ne pas oublier ### 1. Resynchroniser les séquences PostgreSQL après tout import/restore de dump Si la prod (ou tout environnement) est **montée depuis un dump** (`pg_restore` / `COPY`), les lignes sont chargées avec leurs `id` explicites **sans avancer les séquences** → au premier `INSERT` : `duplicate key value violates unique constraint "..._pkey"` (constaté en local sur `notification`, `task`, `time_entry`…). À lancer **juste après chaque restore/import** : ```sql DO $$ DECLARE r RECORD; maxid BIGINT; seq TEXT; BEGIN FOR r IN SELECT table_name, column_name FROM information_schema.columns WHERE table_schema='public' LOOP seq := pg_get_serial_sequence(quote_ident(r.table_name), r.column_name); IF seq IS NOT NULL THEN EXECUTE format('SELECT COALESCE(MAX(%I),0) FROM %I', r.column_name, r.table_name) INTO maxid; PERFORM setval(seq, GREATEST(maxid,1), maxid > 0); END IF; END LOOP; END $$; ``` > Ne concerne **pas** une prod qui tourne déjà (séquences avancées organiquement) — uniquement le cas restore/import. Idempotent, sans risque. ### 2. Fix dénormalisation des collections typées-contrat (code, inclus dans la branche) Les relations **to-many** typées par une interface `Shared\Domain\Contract\*` (`TimeEntry::tags` → `TaskTagInterface`, `Task::collaborators` → `UserInterface`) étaient **indénormalisables par API Platform** (mono-valué OK via IRI, collection KO) → **tout POST/PATCH portant une telle collection renvoyait 400/500**. Corrigé par un dénormaliseur générique `ContractRelationDenormalizer` (réutilise `resolve_target_entities`, zéro couplage par-entité) + test fonctionnel de non-régression. --------- Co-authored-by: Matthieu <contact@malio.fr> Reviewed-on: #17
This commit was merged in pull request #17.
This commit is contained in:
@@ -4,28 +4,32 @@ declare(strict_types=1);
|
||||
|
||||
namespace App\DataFixtures;
|
||||
|
||||
use App\Entity\AbsenceBalance;
|
||||
use App\Entity\AbsencePolicy;
|
||||
use App\Entity\AbsenceRequest;
|
||||
use App\Entity\Client;
|
||||
use App\Entity\MailConfiguration;
|
||||
use App\Entity\Project;
|
||||
use App\Entity\Task;
|
||||
use App\Entity\TaskEffort;
|
||||
use App\Entity\TaskGroup;
|
||||
use App\Entity\TaskPriority;
|
||||
use App\Entity\TaskRecurrence;
|
||||
use App\Entity\TaskStatus;
|
||||
use App\Entity\TaskTag;
|
||||
use App\Entity\TimeEntry;
|
||||
use App\Entity\User;
|
||||
use App\Entity\Workflow;
|
||||
use App\Entity\ZimbraConfiguration;
|
||||
use App\Enum\AbsenceStatus;
|
||||
use App\Enum\AbsenceType;
|
||||
use App\Enum\ContractType;
|
||||
use App\Enum\RecurrenceType;
|
||||
use App\Enum\StatusCategory;
|
||||
use App\Module\Absence\Domain\Entity\AbsenceBalance;
|
||||
use App\Module\Absence\Domain\Entity\AbsencePolicy;
|
||||
use App\Module\Absence\Domain\Entity\AbsenceRequest;
|
||||
use App\Module\Absence\Domain\Enum\AbsenceStatus;
|
||||
use App\Module\Absence\Domain\Enum\AbsenceType;
|
||||
use App\Module\Core\Application\Rbac\RbacSeeder;
|
||||
use App\Module\Core\Domain\Entity\User;
|
||||
use App\Module\Core\Domain\Enum\ContractType;
|
||||
use App\Module\Directory\Domain\Entity\Address;
|
||||
use App\Module\Directory\Domain\Entity\Client;
|
||||
use App\Module\Directory\Domain\Entity\Prospect;
|
||||
use App\Module\Directory\Domain\Enum\ProspectStatus;
|
||||
use App\Module\Integration\Domain\Entity\ZimbraConfiguration;
|
||||
use App\Module\Mail\Domain\Entity\MailConfiguration;
|
||||
use App\Module\ProjectManagement\Domain\Entity\Project;
|
||||
use App\Module\ProjectManagement\Domain\Entity\Task;
|
||||
use App\Module\ProjectManagement\Domain\Entity\TaskEffort;
|
||||
use App\Module\ProjectManagement\Domain\Entity\TaskGroup;
|
||||
use App\Module\ProjectManagement\Domain\Entity\TaskPriority;
|
||||
use App\Module\ProjectManagement\Domain\Entity\TaskRecurrence;
|
||||
use App\Module\ProjectManagement\Domain\Entity\TaskStatus;
|
||||
use App\Module\ProjectManagement\Domain\Entity\TaskTag;
|
||||
use App\Module\ProjectManagement\Domain\Entity\Workflow;
|
||||
use App\Module\ProjectManagement\Domain\Enum\RecurrenceType;
|
||||
use App\Module\ProjectManagement\Domain\Enum\StatusCategory;
|
||||
use App\Module\TimeTracking\Domain\Entity\TimeEntry;
|
||||
use DateTimeImmutable;
|
||||
use DateTimeZone;
|
||||
use Doctrine\Bundle\FixturesBundle\Fixture;
|
||||
@@ -36,6 +40,7 @@ class AppFixtures extends Fixture
|
||||
{
|
||||
public function __construct(
|
||||
private readonly UserPasswordHasherInterface $passwordHasher,
|
||||
private readonly RbacSeeder $rbacSeeder,
|
||||
) {}
|
||||
|
||||
public function load(ObjectManager $manager): void
|
||||
@@ -79,29 +84,102 @@ class AppFixtures extends Fixture
|
||||
$clientLiot->setName('LIOT');
|
||||
$clientLiot->setEmail('contact@liot.fr');
|
||||
$clientLiot->setPhone('05 50 50 50 50');
|
||||
$clientLiot->setStreet('14 allée d\'argenson');
|
||||
$clientLiot->setCity('Poitiers');
|
||||
$clientLiot->setPostalCode('86100');
|
||||
$manager->persist($clientLiot);
|
||||
|
||||
$addressLiot = new Address();
|
||||
$addressLiot->setLabel('Principale');
|
||||
$addressLiot->setStreet('14 allée d\'argenson');
|
||||
$addressLiot->setCity('Poitiers');
|
||||
$addressLiot->setPostalCode('86100');
|
||||
$addressLiot->setCountry('FR');
|
||||
$addressLiot->setClient($clientLiot);
|
||||
$manager->persist($addressLiot);
|
||||
|
||||
$clientAcme = new Client();
|
||||
$clientAcme->setName('ACME Corp');
|
||||
$clientAcme->setEmail('contact@acme.com');
|
||||
$clientAcme->setPhone('01 23 45 67 89');
|
||||
$clientAcme->setStreet('10 rue de la Paix');
|
||||
$clientAcme->setCity('Paris');
|
||||
$clientAcme->setPostalCode('75002');
|
||||
$manager->persist($clientAcme);
|
||||
|
||||
$addressAcme = new Address();
|
||||
$addressAcme->setLabel('Principale');
|
||||
$addressAcme->setStreet('10 rue de la Paix');
|
||||
$addressAcme->setCity('Paris');
|
||||
$addressAcme->setPostalCode('75002');
|
||||
$addressAcme->setCountry('FR');
|
||||
$addressAcme->setClient($clientAcme);
|
||||
$manager->persist($addressAcme);
|
||||
|
||||
$clientNova = new Client();
|
||||
$clientNova->setName('Nova Tech');
|
||||
$clientNova->setEmail('info@novatech.io');
|
||||
$clientNova->setPhone('04 56 78 90 12');
|
||||
$clientNova->setStreet('5 avenue Jean Jaurès');
|
||||
$clientNova->setCity('Lyon');
|
||||
$clientNova->setPostalCode('69007');
|
||||
$manager->persist($clientNova);
|
||||
|
||||
$addressNova = new Address();
|
||||
$addressNova->setLabel('Principale');
|
||||
$addressNova->setStreet('5 avenue Jean Jaurès');
|
||||
$addressNova->setCity('Lyon');
|
||||
$addressNova->setPostalCode('69007');
|
||||
$addressNova->setCountry('FR');
|
||||
$addressNova->setClient($clientNova);
|
||||
$manager->persist($addressNova);
|
||||
|
||||
// Prospects
|
||||
$prospectLead = new Prospect();
|
||||
$prospectLead->setName('Marie Dupont');
|
||||
$prospectLead->setCompany('Atelier Dupont');
|
||||
$prospectLead->setEmail('marie@atelier-dupont.fr');
|
||||
$prospectLead->setPhone('06 11 22 33 44');
|
||||
$prospectLead->setStatus(ProspectStatus::New);
|
||||
$prospectLead->setSource('Site web');
|
||||
$prospectLead->setNotes('Demande de devis via le formulaire de contact.');
|
||||
$manager->persist($prospectLead);
|
||||
|
||||
$addressLead = new Address();
|
||||
$addressLead->setLabel('Principale');
|
||||
$addressLead->setCity('Nantes');
|
||||
$addressLead->setPostalCode('44000');
|
||||
$addressLead->setCountry('FR');
|
||||
$addressLead->setProspect($prospectLead);
|
||||
$manager->persist($addressLead);
|
||||
|
||||
$prospectQualified = new Prospect();
|
||||
$prospectQualified->setName('Jean Martin');
|
||||
$prospectQualified->setCompany('Martin & Fils');
|
||||
$prospectQualified->setEmail('contact@martin-fils.fr');
|
||||
$prospectQualified->setPhone('07 55 66 77 88');
|
||||
$prospectQualified->setStatus(ProspectStatus::Qualified);
|
||||
$prospectQualified->setSource('Salon professionnel');
|
||||
$manager->persist($prospectQualified);
|
||||
|
||||
$addressQualified = new Address();
|
||||
$addressQualified->setLabel('Principale');
|
||||
$addressQualified->setStreet('22 rue du Commerce');
|
||||
$addressQualified->setCity('Bordeaux');
|
||||
$addressQualified->setPostalCode('33000');
|
||||
$addressQualified->setCountry('FR');
|
||||
$addressQualified->setProspect($prospectQualified);
|
||||
$manager->persist($addressQualified);
|
||||
|
||||
$prospectWon = new Prospect();
|
||||
$prospectWon->setName('Sophie Bernard');
|
||||
$prospectWon->setCompany('ACME Corp');
|
||||
$prospectWon->setEmail('contact@acme.com');
|
||||
$prospectWon->setPhone('01 23 45 67 89');
|
||||
$prospectWon->setStatus(ProspectStatus::Won);
|
||||
$prospectWon->setSource('Recommandation');
|
||||
$prospectWon->setConvertedClient($clientAcme);
|
||||
$manager->persist($prospectWon);
|
||||
|
||||
$addressWon = new Address();
|
||||
$addressWon->setLabel('Principale');
|
||||
$addressWon->setCity('Paris');
|
||||
$addressWon->setPostalCode('75002');
|
||||
$addressWon->setCountry('FR');
|
||||
$addressWon->setProspect($prospectWon);
|
||||
$manager->persist($addressWon);
|
||||
|
||||
// Workflow par défaut
|
||||
$standardWorkflow = new Workflow();
|
||||
$standardWorkflow->setName('Standard');
|
||||
@@ -751,5 +829,9 @@ class AppFixtures extends Fixture
|
||||
$manager->persist($pendingMarriage);
|
||||
|
||||
$manager->flush();
|
||||
|
||||
// Seed des rôles système RBAC (admin, user). Idempotent ; aucune matrice
|
||||
// métier attachée (cf. Décision 4 : les modules métier arrivent en 2.x).
|
||||
$this->rbacSeeder->ensureSystemRoles();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user