MALIO-DEV/Lesstime
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 32 Wiki Activity

fix(gitea) : propagate API errors instead of silently returning empty results

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
THOLOT DECHENE Matthieu
2026-03-15 18:58:55 +01:00
parent 63e4af785e
commit 4c19b68156
5 changed files with 36 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/State/GiteaBranchProvider.php
View File

@@ -12,6 +12,7 @@ use App\Entity\Task;
use App\Exception\GiteaApiException;
use App\Service\GiteaApiService;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
final readonly class GiteaBranchProvider implements ProviderInterface
{
@@ -40,8 +41,8 @@ final readonly class GiteaBranchProvider implements ProviderInterface
try {
$branches = $this->giteaApiService->listBranches($project, $taskCode);
} catch (GiteaApiException) {
return [];
} catch (GiteaApiException $e) {
throw new BadRequestHttpException($e->getMessage(), $e);
}
$result = [];
@@ -58,6 +59,7 @@ final readonly class GiteaBranchProvider implements ProviderInterface
'date' => $c['commit']['author']['date'] ?? $c['created'] ?? '',
], $commits);
} catch (GiteaApiException) {
// Commits fetch failure should not block branch listing
$dto->commits = [];
}

5
src/State/GiteaPullRequestProvider.php
View File

@@ -11,6 +11,7 @@ use App\Entity\Task;
use App\Exception\GiteaApiException;
use App\Service\GiteaApiService;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
final readonly class GiteaPullRequestProvider implements ProviderInterface
{
@@ -35,8 +36,8 @@ final readonly class GiteaPullRequestProvider implements ProviderInterface
try {
$prs = $this->giteaApiService->listPullRequests($project, $taskCode);
} catch (GiteaApiException) {
return [];
} catch (GiteaApiException $e) {
throw new BadRequestHttpException($e->getMessage(), $e);
}
return array_map(static function (array $pr): GiteaPullRequest {

5
src/State/GiteaRepositoryProvider.php
View File

@@ -9,6 +9,7 @@ use ApiPlatform\State\ProviderInterface;
use App\ApiResource\GiteaRepository;
use App\Exception\GiteaApiException;
use App\Service\GiteaApiService;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
final readonly class GiteaRepositoryProvider implements ProviderInterface
{
@@ -20,8 +21,8 @@ final readonly class GiteaRepositoryProvider implements ProviderInterface
{
try {
$repos = $this->giteaApiService->listRepositories();
} catch (GiteaApiException) {
return [];
} catch (GiteaApiException $e) {
throw new BadRequestHttpException($e->getMessage(), $e);
}
return array_map(static function (array $repo): GiteaRepository {