fix(gitea) : propagate API errors instead of silently returning empty results

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

src/Service/GiteaApiService.php

@@ -12,6 +12,7 @@ use App\Repository\GiteaConfigurationRepository;
 use Symfony\Component\String\Slugger\AsciiSlugger;
 use Symfony\Component\String\Slugger\SluggerInterface;
 use Symfony\Contracts\HttpClient\Exception\ExceptionInterface;
+use Symfony\Contracts\HttpClient\Exception\HttpExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 use Throwable;
 
@@ -215,6 +216,22 @@ final readonly class GiteaApiService
         }
     }
 
+    private function extractGiteaError(HttpExceptionInterface $e): string
+    {
+        try {
+            $body = $e->getResponse()->getContent(false);
+            $data = json_decode($body, true);
+
+            if (is_array($data)) {
+                return $data['message'] ?? $data['error'] ?? $body;
+            }
+
+            return $body ?: 'Unknown Gitea error';
+        } catch (ExceptionInterface) {
+            return 'Gitea API error (HTTP '.$e->getResponse()->getStatusCode().')';
+        }
+    }
+
     private function assertProjectHasRepo(Project $project): void
     {
         if (!$project->hasGiteaRepo()) {
@@ -240,6 +257,10 @@ final readonly class GiteaApiService
             $response = $this->httpClient->request($method, rtrim($config->getUrl(), '/').$path, $options);
 
             return $response->toArray();
+        } catch (HttpExceptionInterface $e) {
+            $message = $this->extractGiteaError($e);
+
+            throw new GiteaApiException($message, $e->getResponse()->getStatusCode(), $e);
         } catch (ExceptionInterface $e) {
             throw new GiteaApiException('Gitea API error: '.$e->getMessage(), 0, $e);
         }

src/State/GiteaBranchProvider.php

@@ -12,6 +12,7 @@ use App\Entity\Task;
 use App\Exception\GiteaApiException;
 use App\Service\GiteaApiService;
 use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 final readonly class GiteaBranchProvider implements ProviderInterface
 {
@@ -40,8 +41,8 @@ final readonly class GiteaBranchProvider implements ProviderInterface
 
         try {
             $branches = $this->giteaApiService->listBranches($project, $taskCode);
-        } catch (GiteaApiException) {
-            return [];
+        } catch (GiteaApiException $e) {
+            throw new BadRequestHttpException($e->getMessage(), $e);
         }
 
         $result = [];
@@ -58,6 +59,7 @@ final readonly class GiteaBranchProvider implements ProviderInterface
                     'date'    => $c['commit']['author']['date'] ?? $c['created'] ?? '',
                 ], $commits);
             } catch (GiteaApiException) {
+                // Commits fetch failure should not block branch listing
                 $dto->commits = [];
             }
 

src/State/GiteaPullRequestProvider.php

@@ -11,6 +11,7 @@ use App\Entity\Task;
 use App\Exception\GiteaApiException;
 use App\Service\GiteaApiService;
 use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 final readonly class GiteaPullRequestProvider implements ProviderInterface
 {
@@ -35,8 +36,8 @@ final readonly class GiteaPullRequestProvider implements ProviderInterface
 
         try {
             $prs = $this->giteaApiService->listPullRequests($project, $taskCode);
-        } catch (GiteaApiException) {
-            return [];
+        } catch (GiteaApiException $e) {
+            throw new BadRequestHttpException($e->getMessage(), $e);
         }
 
         return array_map(static function (array $pr): GiteaPullRequest {

src/State/GiteaRepositoryProvider.php

@@ -9,6 +9,7 @@ use ApiPlatform\State\ProviderInterface;
 use App\ApiResource\GiteaRepository;
 use App\Exception\GiteaApiException;
 use App\Service\GiteaApiService;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 final readonly class GiteaRepositoryProvider implements ProviderInterface
 {
@@ -20,8 +21,8 @@ final readonly class GiteaRepositoryProvider implements ProviderInterface
     {
         try {
             $repos = $this->giteaApiService->listRepositories();
-        } catch (GiteaApiException) {
-            return [];
+        } catch (GiteaApiException $e) {
+            throw new BadRequestHttpException($e->getMessage(), $e);
         }
 
         return array_map(static function (array $repo): GiteaRepository {