From d49c317c49c4c20a945fdbe0084eb043ca06d8d1 Mon Sep 17 00:00:00 2001
From: Matthieu <mtholot19@gmail.com>
Date: Thu, 16 Apr 2026 10:45:21 +0200
Subject: [PATCH] fix(frontend) : ERP-26/27 - review fixes: shared types,
 accents i18n, escape key, self-edit refresh, row-clickable guard

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 frontend/i18n/locales/fr.json                 | 36 +++++++++----------
 .../core/components/EffectivePermissions.vue  |  9 ++---
 .../core/components/PermissionGroup.vue       |  8 +----
 .../core/components/RoleDeleteModal.vue       |  8 +++++
 .../modules/core/components/RoleDrawer.vue    | 17 +--------
 .../core/components/UserRbacDrawer.vue        | 36 +++----------------
 frontend/modules/core/pages/admin/roles.vue   | 20 ++---------
 frontend/modules/core/pages/admin/users.vue   |  8 +----
 frontend/shared/types/rbac.ts                 | 31 ++++++++++++++++
 9 files changed, 70 insertions(+), 103 deletions(-)
 create mode 100644 frontend/shared/types/rbac.ts

diff --git a/frontend/i18n/locales/fr.json b/frontend/i18n/locales/fr.json
index 8d4c92e..998f3dc 100644
--- a/frontend/i18n/locales/fr.json
+++ b/frontend/i18n/locales/fr.json
@@ -24,7 +24,7 @@
             "suppliers": "Répertoire fournisseurs"
         },
         "core": {
-            "roles": "Gestion des roles",
+            "roles": "Gestion des rôles",
             "users": "Utilisateurs"
         }
     },
@@ -63,33 +63,33 @@
     },
     "admin": {
         "roles": {
-            "title": "Gestion des roles",
-            "newRole": "Nouveau role",
-            "editRole": "Modifier le role",
-            "createRole": "Creer un role",
-            "noRoles": "Aucun role configure",
+            "title": "Gestion des rôles",
+            "newRole": "Nouveau rôle",
+            "editRole": "Modifier le rôle",
+            "createRole": "Créer un rôle",
+            "noRoles": "Aucun rôle configuré",
             "table": {
-                "label": "Libelle",
+                "label": "Libellé",
                 "code": "Code",
                 "permissions": "Permissions",
-                "system": "Systeme",
+                "system": "Système",
                 "actions": "Actions"
             },
             "form": {
-                "label": "Libelle",
+                "label": "Libellé",
                 "code": "Code",
                 "description": "Description",
                 "permissions": "Permissions"
             },
             "delete": {
-                "title": "Supprimer le role",
-                "message": "Etes-vous sur de vouloir supprimer le role \"{label}\" ? Cette action est irreversible.",
-                "systemTooltip": "Role systeme non supprimable"
+                "title": "Supprimer le rôle",
+                "message": "Êtes-vous sûr de vouloir supprimer le rôle \"{label}\" ? Cette action est irréversible.",
+                "systemTooltip": "Rôle système non supprimable"
             },
             "toast": {
-                "created": "Role cree avec succes",
-                "updated": "Role mis a jour avec succes",
-                "deleted": "Role supprime avec succes"
+                "created": "Rôle créé avec succès",
+                "updated": "Rôle mis à jour avec succès",
+                "deleted": "Rôle supprimé avec succès"
             },
             "permissions": {
                 "selectAll": "Tout selectionner",
@@ -110,16 +110,16 @@
                 "title": "Permissions de {username}",
                 "selfWarning": "Vous modifiez vos propres droits",
                 "adminToggle": "Administrateur (bypass total)",
-                "rolesSection": "Roles",
+                "rolesSection": "Rôles",
                 "directPermissionsSection": "Permissions directes",
-                "summarySection": "Resume des permissions effectives",
+                "summarySection": "Résumé des permissions effectives",
                 "noEffectivePermissions": "Aucune permission effective",
                 "sourceRole": "via {role}",
                 "sourceDirect": "Direct",
                 "lastAdminWarning": "Impossible de retirer le statut administrateur du dernier admin"
             },
             "toast": {
-                "updated": "Permissions mises a jour avec succes"
+                "updated": "Permissions mises à jour avec succès"
             }
         }
     }
diff --git a/frontend/modules/core/components/EffectivePermissions.vue b/frontend/modules/core/components/EffectivePermissions.vue
index 98646ec..1e6bcab 100644
--- a/frontend/modules/core/components/EffectivePermissions.vue
+++ b/frontend/modules/core/components/EffectivePermissions.vue
@@ -40,14 +40,9 @@
 </template>
 
 <script setup lang="ts">
-const { t } = useI18n()
+import type { EffectivePermission } from '~/shared/types/rbac'
 
-interface EffectivePermission {
-    code: string
-    label: string
-    module: string
-    sources: string[]
-}
+const { t } = useI18n()
 
 const props = defineProps<{
     permissions: EffectivePermission[]
diff --git a/frontend/modules/core/components/PermissionGroup.vue b/frontend/modules/core/components/PermissionGroup.vue
index 1288a22..8eb589f 100644
--- a/frontend/modules/core/components/PermissionGroup.vue
+++ b/frontend/modules/core/components/PermissionGroup.vue
@@ -30,13 +30,7 @@
 </template>
 
 <script setup lang="ts">
-interface Permission {
-    id: number
-    code: string
-    label: string
-    module: string
-    orphan: boolean
-}
+import type { Permission } from '~/shared/types/rbac'
 
 const props = defineProps<{
     module: string
diff --git a/frontend/modules/core/components/RoleDeleteModal.vue b/frontend/modules/core/components/RoleDeleteModal.vue
index 5f611bd..f9be735 100644
--- a/frontend/modules/core/components/RoleDeleteModal.vue
+++ b/frontend/modules/core/components/RoleDeleteModal.vue
@@ -55,6 +55,14 @@ function cancel() {
 function confirm() {
     emit('confirm')
 }
+
+// Fermer la modale avec la touche Escape
+function onKeydown(e: KeyboardEvent) {
+    if (e.key === 'Escape') cancel()
+}
+
+onMounted(() => document.addEventListener('keydown', onKeydown))
+onUnmounted(() => document.removeEventListener('keydown', onKeydown))
 </script>
 
 <style scoped>
diff --git a/frontend/modules/core/components/RoleDrawer.vue b/frontend/modules/core/components/RoleDrawer.vue
index a774fbf..7933ef8 100644
--- a/frontend/modules/core/components/RoleDrawer.vue
+++ b/frontend/modules/core/components/RoleDrawer.vue
@@ -70,22 +70,7 @@
 </template>
 
 <script setup lang="ts">
-interface Permission {
-    id: number
-    code: string
-    label: string
-    module: string
-    orphan: boolean
-}
-
-interface Role {
-    id: number
-    code: string
-    label: string
-    description: string | null
-    isSystem: boolean
-    permissions: (Permission | string)[]
-}
+import type { Permission, Role } from '~/shared/types/rbac'
 
 interface PermissionModule {
     module: string
diff --git a/frontend/modules/core/components/UserRbacDrawer.vue b/frontend/modules/core/components/UserRbacDrawer.vue
index a215f6a..2ec4ce1 100644
--- a/frontend/modules/core/components/UserRbacDrawer.vue
+++ b/frontend/modules/core/components/UserRbacDrawer.vue
@@ -91,37 +91,7 @@
 </template>
 
 <script setup lang="ts">
-interface Permission {
-    id: number
-    code: string
-    label: string
-    module: string
-    orphan: boolean
-}
-
-interface Role {
-    id: number
-    code: string
-    label: string
-    description: string | null
-    isSystem: boolean
-    permissions: (Permission | string)[]
-}
-
-interface UserListItem {
-    id: number
-    username: string
-    isAdmin: boolean
-    roles: string[]
-    directPermissions: string[]
-}
-
-interface EffectivePermission {
-    code: string
-    label: string
-    module: string
-    sources: string[]
-}
+import type { Permission, Role, UserListItem, EffectivePermission } from '~/shared/types/rbac'
 
 interface PermissionModule {
     module: string
@@ -276,6 +246,10 @@ async function handleSave() {
         }, {
             toastSuccessMessage: t('admin.users.toast.updated'),
         })
+        // Rafraichir les donnees du user courant si auto-edition
+        if (isSelfEdit.value) {
+            await auth.refreshUser()
+        }
         emit('saved')
         emit('update:modelValue', false)
     } finally {
diff --git a/frontend/modules/core/pages/admin/roles.vue b/frontend/modules/core/pages/admin/roles.vue
index ec81460..a1d3699 100644
--- a/frontend/modules/core/pages/admin/roles.vue
+++ b/frontend/modules/core/pages/admin/roles.vue
@@ -19,7 +19,7 @@
             :columns="columns"
             :items="roleItems"
             :total-items="roles.length"
-            :row-clickable="true"
+            :row-clickable="canManage"
             :empty-message="t('admin.roles.noRoles')"
             @row-click="onRowClick"
         >
@@ -76,26 +76,12 @@
 </template>
 
 <script setup lang="ts">
-interface Permission {
-    id: number
-    code: string
-    label: string
-    module: string
-    orphan: boolean
-}
-
-interface Role {
-    id: number
-    code: string
-    label: string
-    description: string | null
-    isSystem: boolean
-    permissions: (Permission | string)[]
-}
+import type { Role } from '~/shared/types/rbac'
 
 const { t } = useI18n()
 const api = useApi()
 const { can } = usePermissions()
+const canManage = can('core.roles.manage')
 
 useHead({ title: t('admin.roles.title') })
 
diff --git a/frontend/modules/core/pages/admin/users.vue b/frontend/modules/core/pages/admin/users.vue
index 8f496dd..e0905cd 100644
--- a/frontend/modules/core/pages/admin/users.vue
+++ b/frontend/modules/core/pages/admin/users.vue
@@ -48,13 +48,7 @@
 </template>
 
 <script setup lang="ts">
-interface UserListItem {
-    id: number
-    username: string
-    isAdmin: boolean
-    roles: string[]
-    directPermissions: string[]
-}
+import type { UserListItem } from '~/shared/types/rbac'
 
 const { t } = useI18n()
 const api = useApi()
diff --git a/frontend/shared/types/rbac.ts b/frontend/shared/types/rbac.ts
new file mode 100644
index 0000000..d80a4d1
--- /dev/null
+++ b/frontend/shared/types/rbac.ts
@@ -0,0 +1,31 @@
+export interface Permission {
+    id: number
+    code: string
+    label: string
+    module: string
+    orphan: boolean
+}
+
+export interface Role {
+    id: number
+    code: string
+    label: string
+    description: string | null
+    isSystem: boolean
+    permissions: (Permission | string)[]
+}
+
+export interface UserListItem {
+    id: number
+    username: string
+    isAdmin: boolean
+    roles: string[]
+    directPermissions: string[]
+}
+
+export interface EffectivePermission {
+    code: string
+    label: string
+    module: string
+    sources: string[]
+}