refactor(core) : RBAC Task 1 - polish apres revue qualite

- Permission : guards constructeur (code/label/module non vides, code avec point)
- Permission::revive() reutilise updateMetadata() pour eviter la duplication
- Suppression de SystemRolesTest (tautologique, ne capture aucun comportement)
- Role::permissions : commentaire explicite sur la raison du fetch EAGER
- Alignement des types de retour sur static (style User.php)
- Nouveau test Role::addPermission avec permissions distinctes

Ticket #343 - Task 1 polish (revue qualite).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matthieu
2026-04-14 16:37:53 +02:00
parent f0ea9201f5
commit 0fc0b57e37
5 changed files with 84 additions and 35 deletions

View File

@@ -37,6 +37,18 @@ final class RoleTest extends TestCase
self::assertSame(1, $role->getPermissions()->count());
}
public function testAddPermissionAddsMultipleDistinct(): void
{
$role = new Role('custom', 'Custom');
$permissionView = new Permission('core.users.view', 'Voir', 'core');
$permissionEdit = new Permission('core.users.edit', 'Editer', 'core');
$role->addPermission($permissionView);
$role->addPermission($permissionEdit);
self::assertSame(2, $role->getPermissions()->count());
}
public function testRemovePermissionRemovesWhenPresent(): void
{
$role = new Role('custom', 'Custom');